vrr/spawn
2
0
Fork 0
mirror of https://github.com/OpenRouterTeam/spawn.git synced 2026-05-19 16:39:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

test: remove conditional-expect anti-patterns from 3 test files (#2525)

Browse source 
Replace `if (!r.ok) { expect(...) }` and `if (result.ok) { return }` guards
with unconditional assertions using toThrow() or toMatchObject(). These
conditional blocks silently skipped assertions when the condition evaluated
the wrong way, providing false confidence. Also remove now-unused tryCatch
imports from prompt-file-security.test.ts and security.test.ts.

Co-authored-by: spawn-qa-bot <qa@openrouter.ai>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
A 2026-03-12 02:21:20 -07:00 • committed by GitHub
parent 7278638a31
commit afff57db5b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 12 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

17
packages/cli/src/__tests__/prompt-file-security.test.ts
View file

@ -1,5 +1,4 @@
import { describe, expect, it } from "bun:test";
import { tryCatch } from "@openrouter/spawn-shared";
import { validatePromptFilePath, validatePromptFileStats } from "../security.js";
describe("validatePromptFilePath", () => {
@ -82,12 +81,8 @@ describe("validatePromptFilePath", () => {
});
it("should include helpful error message about exfiltration risk", () => {
const r = tryCatch(() => validatePromptFilePath("/home/user/.ssh/id_rsa"));
expect(r.ok).toBe(false);
if (!r.ok) {
expect(r.error.message).toContain("sent to the agent");
expect(r.error.message).toContain("plain text file");
}
expect(() => validatePromptFilePath("/home/user/.ssh/id_rsa")).toThrow("sent to the agent");
expect(() => validatePromptFilePath("/home/user/.ssh/id_rsa")).toThrow("plain text file");
});
it("should reject SSH key files by filename pattern anywhere in path", () => {
@ -144,11 +139,7 @@ describe("validatePromptFileStats", () => {
isFile: () => true,
size: 5 * 1024 * 1024,
};
const r = tryCatch(() => validatePromptFileStats("large.bin", stats));
expect(r.ok).toBe(false);
if (!r.ok) {
expect(r.error.message).toContain("5.0MB");
expect(r.error.message).toContain("maximum is 1MB");
}
expect(() => validatePromptFileStats("large.bin", stats)).toThrow("5.0MB");
expect(() => validatePromptFileStats("large.bin", stats)).toThrow("maximum is 1MB");
});
});

9
packages/cli/src/__tests__/security.test.ts
View file

@ -1,5 +1,4 @@
import { describe, expect, it } from "bun:test";
import { tryCatch } from "@openrouter/spawn-shared";
import { validateIdentifier, validatePrompt, validateScriptContent } from "../security.js";
/**
@ -431,12 +430,8 @@ describe("validatePrompt", () => {
});
it("should provide helpful error message for command substitution", () => {
const r = tryCatch(() => validatePrompt("Run $(echo test)"));
expect(r.ok).toBe(false);
if (!r.ok) {
expect(r.error.message).toContain("shell syntax");
expect(r.error.message).toContain("plain English");
}
expect(() => validatePrompt("Run $(echo test)")).toThrow("shell syntax");
expect(() => validatePrompt("Run $(echo test)")).toThrow("plain English");
});
it("should detect multiple dangerous patterns", () => {

12
packages/cli/src/__tests__/with-retry-result.test.ts
View file

@ -149,12 +149,12 @@ describe("wrapSshCall", () => {
it("wraps non-Error rejects into Error for Err", async () => {
const result = await wrapSshCall(Promise.reject("string error"));
expect(result.ok).toBe(false);
if (result.ok) {
return;
}
expect(result.error).toBeInstanceOf(Error);
expect(result.error.message).toBe("string error");
expect(result).toMatchObject({
ok: false,
error: {
message: "string error",
},
});
});
});