vrr/spawn
2
0
Fork 0
mirror of https://github.com/OpenRouterTeam/spawn.git synced 2026-05-20 01:11:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

test: consolidate wasteful one-per-flag tests in unknown-flags suite (#2029)

Browse source 
Remove 18 redundant/theatrical tests from unknown-flags.test.ts:

- Removed duplicate 'should detect --verbose as unknown' test (same name,
  same assertion, nearly identical inputs as the test 28 lines above it)
- Consolidated 14 individual 'allows known flags' tests — each called
  findUnknownFlag([flag]) with a single flag and expected null — into one
  data-driven loop over all 17 flags; same coverage, 13 fewer test cases
- Removed 'should contain --name flag' which is fully subsumed by the
  immediately following 'should contain all expected flags' test that
  already verifies --name along with 22 other flags

Co-authored-by: spawn-qa-bot <qa@openrouter.ai>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
A 2026-02-28 12:42:04 -08:00 • committed by GitHub
parent 912d8305c5
commit a8b7bb7fb9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 30 additions and 169 deletions
Download patch file Download diff file Expand all files Collapse all files

2
packages/cli/package.json
View file

@ -1,6 +1,6 @@
{
"name": "@openrouter/spawn",
"version": "0.11.10",
"version": "0.11.11",
"type": "module",
"bin": {
"spawn": "cli.js"

197
packages/cli/src/__tests__/unknown-flags.test.ts
View file

@ -19,7 +19,7 @@ describe("Unknown Flag Detection", () => {
).toBe("--json");
});
it("should detect --verbose as unknown", () => {
it("should detect --verbose as unknown (middle position)", () => {
expect(
findUnknownFlag([
"claude",
@ -47,16 +47,6 @@ describe("Unknown Flag Detection", () => {
).toBe("--force");
});
it("should detect --verbose as unknown", () => {
expect(
findUnknownFlag([
"claude",
"sprite",
"--verbose",
]),
).toBe("--verbose");
});
it("should detect unknown flag at the beginning", () => {
expect(
findUnknownFlag([
@ -78,159 +68,34 @@ describe("Unknown Flag Detection", () => {
});
describe("allows known flags", () => {
it("should allow --help", () => {
expect(
findUnknownFlag([
"list",
"--help",
]),
).toBeNull();
});
it("should allow -h", () => {
expect(
findUnknownFlag([
"agents",
"-h",
]),
).toBeNull();
});
it("should allow --version", () => {
expect(
findUnknownFlag([
"--version",
]),
).toBeNull();
});
it("should allow -v", () => {
expect(
findUnknownFlag([
"-v",
]),
).toBeNull();
});
it("should allow -V", () => {
expect(
findUnknownFlag([
"-V",
]),
).toBeNull();
});
it("should allow --prompt (already extracted, but still known)", () => {
expect(
findUnknownFlag([
"--prompt",
]),
).toBeNull();
});
it("should allow -p", () => {
expect(
findUnknownFlag([
"-p",
]),
).toBeNull();
});
it("should allow --prompt-file", () => {
expect(
findUnknownFlag([
"--prompt-file",
]),
).toBeNull();
});
it("should allow -f (short form of --prompt-file)", () => {
expect(
findUnknownFlag([
"-f",
]),
).toBeNull();
});
it("should allow --dry-run", () => {
expect(
findUnknownFlag([
"claude",
"sprite",
"--dry-run",
]),
).toBeNull();
});
it("should allow -n (short form of --dry-run)", () => {
expect(
findUnknownFlag([
"claude",
"sprite",
"-n",
]),
).toBeNull();
});
it("should allow --default (used by spawn pick)", () => {
expect(
findUnknownFlag([
"--default",
"us-central1-a",
]),
).toBeNull();
});
it("should allow --output", () => {
expect(
findUnknownFlag([
"claude",
"sprite",
"--output",
"json",
]),
).toBeNull();
});
it("should allow --headless", () => {
expect(
findUnknownFlag([
"claude",
"sprite",
"--headless",
]),
).toBeNull();
});
it("should allow --debug", () => {
expect(
findUnknownFlag([
"claude",
"sprite",
"--debug",
]),
).toBeNull();
});
it("should allow --name", () => {
expect(
findUnknownFlag([
"claude",
"sprite",
"--name",
"my-box",
]),
).toBeNull();
});
it("should allow --reauth", () => {
expect(
findUnknownFlag([
"claude",
"aws",
"--reauth",
]),
).toBeNull();
it("should return null for all known flags", () => {
const knownFlagsToTest = [
"--help",
"-h",
"--version",
"-v",
"-V",
"--prompt",
"-p",
"--prompt-file",
"-f",
"--dry-run",
"-n",
"--default",
"--output",
"--headless",
"--debug",
"--name",
"--reauth",
];
for (const flag of knownFlagsToTest) {
expect(
findUnknownFlag([
flag,
]),
`expected ${flag} to be allowed`,
).toBeNull();
}
});
});
@ -321,10 +186,6 @@ describe("Unknown Flag Detection", () => {
});
describe("KNOWN_FLAGS completeness", () => {
it("should contain --name flag", () => {
expect(KNOWN_FLAGS.has("--name")).toBe(true);
});
it("should contain all expected flags", () => {
const expected = [
"--help",