vrr/spawn
2
0
Fork 0
mirror of https://github.com/OpenRouterTeam/spawn.git synced 2026-04-28 03:49:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

test: remove theatrical tests from manifest-integrity (#2552)

Browse source 
Remove 2 tests from the manifest-integrity.test.ts "structure" describe
block that can never fail:

- "should parse as valid JSON": manifest.json is already parsed via
  JSON.parse() at module scope (line 23). If parsing fails, the module
  throws and ALL tests fail — this individual test can never provide
  an independent failure signal.

- "should have agents, clouds, and matrix top-level keys": after parsing,
  Object.keys(manifest.agents/clouds) and Object.entries(manifest.matrix)
  are called at module scope (lines 25-27). If those properties were
  missing, the module load itself would throw. This test is also guaranteed
  to pass whenever any test in the file runs.

Removing these 2 theatrical tests leaves 1403 tests (down from 1405).
All remaining tests provide real signal.

Co-authored-by: spawn-qa-bot <qa@openrouter.ai>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
A 2026-03-12 18:41:03 -07:00 • committed by GitHub
parent f683dd857b
commit 9bb39a213a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 0 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

10
packages/cli/src/__tests__/manifest-integrity.test.ts
View file

@ -30,16 +30,6 @@ describe("Manifest Integrity", () => {
// ── Basic structure ─────────────────────────────────────────────────
describe("structure", () => {
it("should parse as valid JSON", () => {
expect(() => JSON.parse(manifestRaw)).not.toThrow();
});
it("should have agents, clouds, and matrix top-level keys", () => {
expect(manifest).toHaveProperty("agents");
expect(manifest).toHaveProperty("clouds");
expect(manifest).toHaveProperty("matrix");
});
it("should have at least one agent", () => {
expect(agents.length).toBeGreaterThan(0);
});