From 8eb5f8476cf729365df651cf52d4bc801e2272d4 Mon Sep 17 00:00:00 2001 From: A <258483684+la14-1@users.noreply.github.com> Date: Tue, 3 Mar 2026 23:35:43 -0800 Subject: [PATCH] chore: rename fixture files from snake_case to kebab-case (#2167) Renames create_server, delete_server, ssh_keys, and server_types fixture JSON files to kebab-case for consistency with codebase conventions. Updates _metadata.json keys and qa-fixtures-prompt naming convention accordingly. Co-authored-by: lab <6723574+louisgv@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) --- .claude/skills/setup-agent-team/qa-fixtures-prompt.md | 6 +++--- fixtures/digitalocean/_metadata.json | 6 +++--- .../{create_server.json => create-server.json} | 0 .../{delete_server.json => delete-server.json} | 0 fixtures/digitalocean/{ssh_keys.json => ssh-keys.json} | 0 fixtures/hetzner/_metadata.json | 8 ++++---- .../hetzner/{create_server.json => create-server.json} | 0 .../hetzner/{delete_server.json => delete-server.json} | 0 fixtures/hetzner/{server_types.json => server-types.json} | 0 fixtures/hetzner/{ssh_keys.json => ssh-keys.json} | 0 10 files changed, 10 insertions(+), 10 deletions(-) rename fixtures/digitalocean/{create_server.json => create-server.json} (100%) rename fixtures/digitalocean/{delete_server.json => delete-server.json} (100%) rename fixtures/digitalocean/{ssh_keys.json => ssh-keys.json} (100%) rename fixtures/hetzner/{create_server.json => create-server.json} (100%) rename fixtures/hetzner/{delete_server.json => delete-server.json} (100%) rename fixtures/hetzner/{server_types.json => server-types.json} (100%) rename fixtures/hetzner/{ssh_keys.json => ssh-keys.json} (100%) diff --git a/.claude/skills/setup-agent-team/qa-fixtures-prompt.md b/.claude/skills/setup-agent-team/qa-fixtures-prompt.md index c1eeb665..b9156f11 100644 --- a/.claude/skills/setup-agent-team/qa-fixtures-prompt.md +++ b/.claude/skills/setup-agent-team/qa-fixtures-prompt.md @@ -65,7 +65,7 @@ For any other cloud directories found, read their TypeScript module in `packages For each successful API response: 1. Validate it is valid JSON: `echo "$response" | jq . > /dev/null 2>&1` 2. Pretty-print and save: `echo "$response" | jq . > fixtures/{cloud}/{endpoint}.json` -3. Name convention: `ssh_keys.json`, `server_types.json`, `regions.json`, `account.json` +3. Name convention: kebab-case — `ssh-keys.json`, `server-types.json`, `regions.json`, `account.json` ## Step 5 — Update Metadata @@ -75,8 +75,8 @@ Create or update `fixtures/{cloud}/_metadata.json` for each cloud: { "recorded_at": "2024-01-15T12:00:00Z", "endpoints": { - "ssh_keys": "https://api.provider.com/v1/ssh_keys", - "server_types": "https://api.provider.com/v1/server_types" + "ssh-keys": "https://api.provider.com/v1/ssh_keys", + "server-types": "https://api.provider.com/v1/server_types" } } ``` diff --git a/fixtures/digitalocean/_metadata.json b/fixtures/digitalocean/_metadata.json index f6bbc772..99656d65 100644 --- a/fixtures/digitalocean/_metadata.json +++ b/fixtures/digitalocean/_metadata.json @@ -3,11 +3,11 @@ "recorded_at": "2026-02-11T03:07:38Z", "fixtures": { "account": {"endpoint": "/account", "recorded_at": "2026-02-11T03:07:30Z"}, - "ssh_keys": {"endpoint": "/account/keys", "recorded_at": "2026-02-11T03:07:30Z"}, + "ssh-keys": {"endpoint": "/account/keys", "recorded_at": "2026-02-11T03:07:30Z"}, "droplets": {"endpoint": "/droplets", "recorded_at": "2026-02-11T03:07:31Z"}, "sizes": {"endpoint": "/sizes", "recorded_at": "2026-02-11T03:07:31Z"}, "regions": {"endpoint": "/regions", "recorded_at": "2026-02-11T03:07:32Z"}, - "create_server": {"endpoint": "POST /droplets", "type": "live", "recorded_at": "2026-02-11T03:07:34Z"}, - "delete_server": {"endpoint": "DELETE /droplets/{id}", "type": "live", "recorded_at": "2026-02-11T03:07:38Z"} + "create-server": {"endpoint": "POST /droplets", "type": "live", "recorded_at": "2026-02-11T03:07:34Z"}, + "delete-server": {"endpoint": "DELETE /droplets/{id}", "type": "live", "recorded_at": "2026-02-11T03:07:38Z"} } } diff --git a/fixtures/digitalocean/create_server.json b/fixtures/digitalocean/create-server.json similarity index 100% rename from fixtures/digitalocean/create_server.json rename to fixtures/digitalocean/create-server.json diff --git a/fixtures/digitalocean/delete_server.json b/fixtures/digitalocean/delete-server.json similarity index 100% rename from fixtures/digitalocean/delete_server.json rename to fixtures/digitalocean/delete-server.json diff --git a/fixtures/digitalocean/ssh_keys.json b/fixtures/digitalocean/ssh-keys.json similarity index 100% rename from fixtures/digitalocean/ssh_keys.json rename to fixtures/digitalocean/ssh-keys.json diff --git a/fixtures/hetzner/_metadata.json b/fixtures/hetzner/_metadata.json index 07003342..93fa16e4 100644 --- a/fixtures/hetzner/_metadata.json +++ b/fixtures/hetzner/_metadata.json @@ -2,12 +2,12 @@ "cloud": "hetzner", "recorded_at": "2026-02-11T03:07:29Z", "fixtures": { - "server_types": {"endpoint": "/server_types?per_page=50", "recorded_at": "2026-02-11T03:07:22Z"}, + "server-types": {"endpoint": "/server_types?per_page=50", "recorded_at": "2026-02-11T03:07:22Z"}, "datacenters": {"endpoint": "/datacenters", "recorded_at": "2026-02-14T00:00:00Z"}, "locations": {"endpoint": "/locations", "recorded_at": "2026-02-11T03:07:23Z"}, - "ssh_keys": {"endpoint": "/ssh_keys", "recorded_at": "2026-02-11T03:07:24Z"}, + "ssh-keys": {"endpoint": "/ssh_keys", "recorded_at": "2026-02-11T03:07:24Z"}, "servers": {"endpoint": "/servers", "recorded_at": "2026-02-11T03:07:25Z"}, - "create_server": {"endpoint": "POST /servers", "type": "live", "recorded_at": "2026-02-11T03:07:26Z"}, - "delete_server": {"endpoint": "DELETE /servers/{id}", "type": "live", "recorded_at": "2026-02-11T03:07:29Z"} + "create-server": {"endpoint": "POST /servers", "type": "live", "recorded_at": "2026-02-11T03:07:26Z"}, + "delete-server": {"endpoint": "DELETE /servers/{id}", "type": "live", "recorded_at": "2026-02-11T03:07:29Z"} } } diff --git a/fixtures/hetzner/create_server.json b/fixtures/hetzner/create-server.json similarity index 100% rename from fixtures/hetzner/create_server.json rename to fixtures/hetzner/create-server.json diff --git a/fixtures/hetzner/delete_server.json b/fixtures/hetzner/delete-server.json similarity index 100% rename from fixtures/hetzner/delete_server.json rename to fixtures/hetzner/delete-server.json diff --git a/fixtures/hetzner/server_types.json b/fixtures/hetzner/server-types.json similarity index 100% rename from fixtures/hetzner/server_types.json rename to fixtures/hetzner/server-types.json diff --git a/fixtures/hetzner/ssh_keys.json b/fixtures/hetzner/ssh-keys.json similarity index 100% rename from fixtures/hetzner/ssh_keys.json rename to fixtures/hetzner/ssh-keys.json