From 83d68c6a37edb6863e566630bc6896e8eeea04ac Mon Sep 17 00:00:00 2001 From: A <258483684+la14-1@users.noreply.github.com> Date: Tue, 3 Mar 2026 08:51:59 -0800 Subject: [PATCH] refactor: Remove dead code and stale references (#2137) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove `cleanup_stale_apps()` in `sh/e2e/lib/cleanup.sh` which was dead code — defined but never called. The E2E orchestrator (`e2e.sh`) invokes `cloud_cleanup_stale` directly on the active cloud driver; the wrapper function and its file served no purpose. Also remove the corresponding `source` call in `e2e.sh`. Co-authored-by: spawn-qa-bot Co-authored-by: Claude Sonnet 4.6 Co-authored-by: L <6723574+louisgv@users.noreply.github.com> --- sh/e2e/e2e.sh | 1 - sh/e2e/lib/cleanup.sh | 13 ------------- 2 files changed, 14 deletions(-) delete mode 100644 sh/e2e/lib/cleanup.sh diff --git a/sh/e2e/e2e.sh b/sh/e2e/e2e.sh index 9c3d492e..c17bd1a8 100755 --- a/sh/e2e/e2e.sh +++ b/sh/e2e/e2e.sh @@ -30,7 +30,6 @@ source "${SCRIPT_DIR}/lib/common.sh" source "${SCRIPT_DIR}/lib/provision.sh" source "${SCRIPT_DIR}/lib/verify.sh" source "${SCRIPT_DIR}/lib/teardown.sh" -source "${SCRIPT_DIR}/lib/cleanup.sh" # --------------------------------------------------------------------------- # All supported clouds (excluding local — no infra to provision) diff --git a/sh/e2e/lib/cleanup.sh b/sh/e2e/lib/cleanup.sh deleted file mode 100644 index 3e56936e..00000000 --- a/sh/e2e/lib/cleanup.sh +++ /dev/null @@ -1,13 +0,0 @@ -#!/bin/bash -# e2e/lib/cleanup.sh — Find and destroy stale e2e-* instances (cloud-agnostic) -set -eo pipefail - -# --------------------------------------------------------------------------- -# cleanup_stale_apps -# -# Delegates to the active cloud driver's stale cleanup function. -# --------------------------------------------------------------------------- -cleanup_stale_apps() { - log_header "Cleaning up stale e2e instances (${ACTIVE_CLOUD})" - cloud_cleanup_stale -}