vrr/spawn
2
0
Fork 0
mirror of https://github.com/OpenRouterTeam/spawn.git synced 2026-05-02 13:50:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

refactor: extract ensure_multi_credentials to reduce duplication across 5 providers (#468)

Browse source 
Add a generic ensure_multi_credentials() helper to shared/common.sh that
handles the env-var/config-file/prompt/test/save flow for providers needing
multiple credentials. This eliminates ~270 lines of duplicated logic across
contabo, netcup, ramnode, ionos, and upcloud, replacing it with single
function calls.

Each provider's ensure_*_credentials() function is now 3-8 lines instead
of 30-65 lines.

Agent: complexity-hunter

Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
A 2026-02-11 07:48:32 -08:00 • committed by GitHub
parent e38a75ea17
commit 79e3b887c9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 144 additions and 273 deletions
Download patch file Download diff file Expand all files Collapse all files

50
ramnode/lib/common.sh
View file

@ -121,51 +121,11 @@ test_ramnode_credentials() {
# Ensure RamNode credentials are available
ensure_ramnode_credentials() {
# Check for required environment variables
if [[ -n "${RAMNODE_USERNAME:-}" && -n "${RAMNODE_PASSWORD:-}" && -n "${RAMNODE_PROJECT_ID:-}" ]]; then
if test_ramnode_credentials; then
return 0
fi
fi
# Try to load from config file (single python3 call instead of 3)
local config_file="$HOME/.config/spawn/ramnode.json"
local creds
if creds=$(_load_json_config_fields "$config_file" username password project_id); then
local saved_user saved_pass saved_pid
{ read -r saved_user; read -r saved_pass; read -r saved_pid; } <<< "${creds}"
if [[ -n "$saved_user" ]] && [[ -n "$saved_pass" ]] && [[ -n "$saved_pid" ]]; then
log_info "Loading RamNode credentials from $config_file..."
export RAMNODE_USERNAME="$saved_user" RAMNODE_PASSWORD="$saved_pass" RAMNODE_PROJECT_ID="$saved_pid"
if test_ramnode_credentials; then
return 0
fi
fi
fi
# Prompt for credentials
log_warn "RamNode OpenStack credentials not found"
log_info ""
log_info "Get credentials from: https://manage.ramnode.com/ → Cloud → API Users"
log_info ""
RAMNODE_USERNAME=$(safe_read "Enter RamNode username: ") || return 1
RAMNODE_PASSWORD=$(safe_read "Enter RamNode password: ") || return 1
RAMNODE_PROJECT_ID=$(safe_read "Enter RamNode project ID: ") || return 1
export RAMNODE_USERNAME RAMNODE_PASSWORD RAMNODE_PROJECT_ID
if ! test_ramnode_credentials; then
log_error "Invalid credentials"
return 1
fi
_save_json_config "$config_file" \
username "$RAMNODE_USERNAME" \
password "$RAMNODE_PASSWORD" \
project_id "$RAMNODE_PROJECT_ID"
return 0
ensure_multi_credentials "RamNode" "$HOME/.config/spawn/ramnode.json" \
"https://manage.ramnode.com/ -> Cloud -> API Users" test_ramnode_credentials \
"RAMNODE_USERNAME:username:Username" \
"RAMNODE_PASSWORD:password:Password" \
"RAMNODE_PROJECT_ID:project_id:Project ID"
}
# Check if SSH key is registered with RamNode