vrr/spawn
2
0
Fork 0
mirror of https://github.com/OpenRouterTeam/spawn.git synced 2026-05-25 14:54:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

refactor: extract ensure_multi_credentials to reduce duplication across 5 providers (#468)

Browse source 
Add a generic ensure_multi_credentials() helper to shared/common.sh that
handles the env-var/config-file/prompt/test/save flow for providers needing
multiple credentials. This eliminates ~270 lines of duplicated logic across
contabo, netcup, ramnode, ionos, and upcloud, replacing it with single
function calls.

Each provider's ensure_*_credentials() function is now 3-8 lines instead
of 30-65 lines.

Agent: complexity-hunter

Co-authored-by: A <6723574+louisgv@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
A 2026-02-11 07:48:32 -08:00 • committed by GitHub
parent e38a75ea17
commit 79e3b887c9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 144 additions and 273 deletions
Download patch file Download diff file Expand all files Collapse all files

58
ionos/lib/common.sh
View file

@ -72,60 +72,12 @@ test_ionos_credentials() {
return 0
}
# Try loading IONOS credentials from config file
# Returns 0 if loaded, 1 otherwise
_ionos_load_config_credentials() {
local config_file="$1"
local creds
creds=$(_load_json_config_fields "$config_file" username password) || return 1
local saved_user saved_pass
{ read -r saved_user; read -r saved_pass; } <<< "${creds}"
if [[ -z "$saved_user" ]] || [[ -z "$saved_pass" ]]; then
return 1
fi
log_info "Loading IONOS credentials from $config_file"
export IONOS_USERNAME="$saved_user" IONOS_PASSWORD="$saved_pass"
}
# Prompt user for IONOS credentials interactively
# Returns 0 on success (exports credentials), 1 on failure
_ionos_prompt_credentials() {
log_warn "IONOS Cloud credentials not found"
echo ""
log_info "Get credentials at: https://dcd.ionos.com/ → Management → Users & Keys"
echo ""
IONOS_USERNAME=$(safe_read "Enter IONOS username (email): ") || return 1
IONOS_PASSWORD=$(safe_read "Enter IONOS password/API key: ") || return 1
export IONOS_USERNAME IONOS_PASSWORD
}
# Ensure IONOS credentials are available (env vars → config file → prompt+save)
# Ensure IONOS credentials are available (env vars -> config file -> prompt+save)
ensure_ionos_credentials() {
local config_file="$HOME/.config/spawn/ionos.json"
# Try env vars, then config file, then prompt
if [[ -z "${IONOS_USERNAME:-}" ]] || [[ -z "${IONOS_PASSWORD:-}" ]]; then
_ionos_load_config_credentials "$config_file" || true
fi
local need_save=false
if [[ -z "${IONOS_USERNAME:-}" ]] || [[ -z "${IONOS_PASSWORD:-}" ]]; then
_ionos_prompt_credentials || return 1
need_save=true
fi
log_info "Testing IONOS credentials..."
if ! test_ionos_credentials; then
log_error "Invalid IONOS credentials. Please check IONOS_USERNAME and IONOS_PASSWORD."
return 1
fi
if [[ "$need_save" == "true" ]]; then
_save_json_config "$config_file" username "$IONOS_USERNAME" password "$IONOS_PASSWORD"
fi
ensure_multi_credentials "IONOS" "$HOME/.config/spawn/ionos.json" \
"https://dcd.ionos.com/ -> Management -> Users & Keys" test_ionos_credentials \
"IONOS_USERNAME:username:Username (email)" \
"IONOS_PASSWORD:password:Password/API Key"
}
# Check if SSH key is registered with IONOS