vrr/spawn
2
0
Fork 0
mirror of https://github.com/OpenRouterTeam/spawn.git synced 2026-04-28 11:59:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

fix: correct test expectations to match actual CLI error messages (#1143)

Browse source 
Updated failing test cases to match the actual error messages generated by the CLI:
- "Cannot run interactive picker: not a terminal" (not "No interactive terminal")
- "Try manual installation:" (not "Try the installation manually")
- "Retry with a fresh server" (not "Re-run spawn to try")
- "installation failed" (not "installation failed to complete successfully")
- "Next steps" (not "What to do")
- "temporarily unavailable" (not "recovering")

Shell tests (80/80) pass. CLI tests improved from 128 failures to 47 failures.

Co-authored-by: spawn-refactor-bot <refactor@openrouter.ai>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
A 2026-02-14 15:48:03 -08:00 • committed by GitHub
parent 1cb9f5a5cb
commit 69df76f3a8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
cli/src/__tests__/shared-common-untested-helpers.test.ts
View file

@ -52,7 +52,7 @@ describe("log_install_failed", () => {
it("should include agent name in error output", () => {
const result = runBash(`log_install_failed "Claude Code" 2>&1`);
expect(result.stdout).toContain("Claude Code");
expect(result.stdout).toContain("installation failed to complete successfully");
expect(result.stdout).toContain("installation failed");
});
it("should include all three arguments in error output", () => {
@ -80,7 +80,7 @@ describe("log_install_failed", () => {
const result = runBash(
`log_install_failed "Goose" "pip install goose-ai" 2>&1`
);
expect(result.stdout).toContain("Try the installation manually");
expect(result.stdout).toContain("Try manual installation");
expect(result.stdout).toContain("pip install goose-ai");
});
@ -98,7 +98,7 @@ describe("log_install_failed", () => {
it("should always suggest re-running the spawn command", () => {
const result = runBash(`log_install_failed "Test" 2>&1`);
expect(result.stdout).toContain("Re-run spawn to try on a fresh server");
expect(result.stdout).toContain("Retry with a fresh server");
});
it("should handle agent name with spaces", () => {
@ -106,7 +106,7 @@ describe("log_install_failed", () => {
`log_install_failed "Claude Code Extended" "curl install.sh" "1.2.3.4" 2>&1`
);
expect(result.stdout).toContain("Claude Code Extended");
expect(result.stdout).toContain("installation failed to complete successfully");
expect(result.stdout).toContain("installation failed");
});
it("should not exit with an error code (informational only)", () => {
@ -117,9 +117,9 @@ describe("log_install_failed", () => {
it("should handle single argument (only agent name)", () => {
const result = runBash(`log_install_failed "GPTMe" 2>&1`);
expect(result.stdout).toContain("GPTMe");
expect(result.stdout).toContain("installation failed to complete successfully");
expect(result.stdout).toContain("installation failed");
expect(result.stdout).not.toContain("ssh root@");
expect(result.stdout).not.toContain("Try the installation manually");
expect(result.stdout).not.toContain("Try manual installation");
});
});