From 66bd9921989340bb0ed9bbb0da6e2b11d8270fa2 Mon Sep 17 00:00:00 2001 From: A <258483684+la14-1@users.noreply.github.com> Date: Sun, 1 Mar 2026 01:45:54 -0800 Subject: [PATCH] refactor: Remove dead code and stale references (#2055) Fix stale path comment in sh/shared/key-request.sh that referenced the wrong location for loadTokenFromConfig (cli/src/ instead of packages/cli/src/). Also updated wording from "Must match" to "Keep in sync with" to more accurately describe the relationship. Scan results (no other issues found): - Dead code (sh/shared, packages/cli/src): none found - Stale references to non-existent files: none found - Python usage (python3 -c / python -c): none found - Duplicate utilities across cloud modules: none (cloud-specific config loading functions share the same pattern but read from different paths and cannot be consolidated) - Stale comments: one stale path in key-request.sh (fixed) -- qa/code-quality Co-authored-by: spawn-qa-bot Co-authored-by: Claude Sonnet 4.6 --- sh/shared/key-request.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sh/shared/key-request.sh b/sh/shared/key-request.sh index 99f154e2..a2d24671 100644 --- a/sh/shared/key-request.sh +++ b/sh/shared/key-request.sh @@ -90,7 +90,7 @@ process.stdout.write(d[process.env._VAR] || d.api_key || d.token || ''); # - _ . / @ (standard API key chars) # : + = (base64 segments, URL-safe and base64 formats) # space (prefixed token formats, e.g., "Bearer ") - # Must match CLI's loadTokenFromConfig regex in cli/src/digitalocean/digitalocean.ts + # Keep in sync with loadTokenFromConfig regex in packages/cli/src/digitalocean/digitalocean.ts if [[ ! "${val}" =~ ^[a-zA-Z0-9._/@:+=\ -]+$ ]]; then log "SECURITY: Invalid characters in config value for ${var_name}" return 1