From 5b1c3f777ecad30e86c58c752bb18cc115d40d7d Mon Sep 17 00:00:00 2001 From: A <258483684+la14-1@users.noreply.github.com> Date: Tue, 3 Mar 2026 12:48:10 -0800 Subject: [PATCH] test: Remove duplicate install-field test in manifest-type-contracts (#2150) The "install commands should be strings" test in the "Agent launch command consistency" describe block was a full duplicate of the per-agent "install should be a non-empty string" test already present in the "Agent required field types" loop. Co-authored-by: spawn-qa-bot Co-authored-by: Claude Sonnet 4.6 Co-authored-by: L <6723574+louisgv@users.noreply.github.com> --- .../cli/src/__tests__/manifest-type-contracts.test.ts | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/packages/cli/src/__tests__/manifest-type-contracts.test.ts b/packages/cli/src/__tests__/manifest-type-contracts.test.ts index 0b6d070c..bc3fa2f7 100644 --- a/packages/cli/src/__tests__/manifest-type-contracts.test.ts +++ b/packages/cli/src/__tests__/manifest-type-contracts.test.ts @@ -280,13 +280,8 @@ describe("Agent launch command consistency", () => { expect(agent.launch).not.toMatch(/\$\([^)]+\)/); } }); - - it("install commands should be strings (can contain pipe for curl|bash)", () => { - for (const [, agent] of allAgents) { - expect(typeof agent.install).toBe("string"); - expect(agent.install.trim().length).toBeGreaterThan(0); - } - }); + // Note: install field type/non-empty checks are covered by + // "Agent required field types" > "install should be a non-empty string" }); // ── Interactive prompts structure ─────────────────────────────────────────