vrr/spawn
2
0
Fork 0
mirror of https://github.com/OpenRouterTeam/spawn.git synced 2026-05-10 12:20:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

fix: aws safe_read calls discard user input, breaking CLI install flow (#1613)

Browse source 
safe_read() outputs via stdout and takes only one argument (the prompt).
Three call sites in aws/lib/common.sh incorrectly passed a variable name
as a second argument instead of using command substitution:

  safe_read "prompt" varname    # BUG: varname never assigned
  varname=$(safe_read "prompt") # CORRECT: captures stdout

This caused:
- Install prompt always defaulting to "y" (user's "n" was ignored)
- AWS credentials never being captured after CLI install, leaving
  AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY empty, so the
  install-then-configure code path always failed silently

Agent: code-health

Co-authored-by: B <6723574+louisgv@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
A 2026-02-21 14:08:50 -08:00 • committed by GitHub
parent 0f59f0e844
commit 53db26056c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
aws/lib/common.sh
View file

@ -232,7 +232,7 @@ ensure_aws_cli() {
if ! command -v aws &>/dev/null; then
log_warn "AWS CLI is not installed."
local install_choice
safe_read "Install AWS CLI now? [Y/n] " install_choice || install_choice="y"
install_choice=$(safe_read "Install AWS CLI now? [Y/n] ") || install_choice="y"
install_choice="${install_choice:-y}"
case "${install_choice}" in
@ -244,8 +244,8 @@ ensure_aws_cli() {
# Installed — now prompt for credentials
log_info "Run 'aws configure' to set your AWS credentials."
local access_key secret_key
safe_read "AWS Access Key ID: " access_key || return 1
safe_read "AWS Secret Access Key: " secret_key || return 1
access_key=$(safe_read "AWS Access Key ID: ") || return 1
secret_key=$(safe_read "AWS Secret Access Key: ") || return 1
export AWS_ACCESS_KEY_ID="${access_key}"
export AWS_SECRET_ACCESS_KEY="${secret_key}"
export AWS_DEFAULT_REGION="${region}"