vrr/sillytavern-character-memory
2
0
Fork 0
mirror of https://github.com/bal-spec/sillytavern-character-memory.git synced 2026-04-28 03:39:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: recompute targets dynamically in Data Bank auto-refresh

Browse source 
The previous auto-refresh captured targets/charName at modal-open time
(stale closure), so if the troubleshooter was opened before a character
context was available (e.g. before CHAT_CHANGED fired), the Data Bank
section would never populate.

Now rebuildDataBankList() calls getMemoryTargets()/getCharacterName()
fresh on each tick. Also fires immediately on modal open and whenever
the user navigates to the Data Bank tab, so there's no 2s wait for
the first render.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
bal-spec 2026-03-03 23:12:23 -08:00
parent 63cfa66267
commit 9f154199a4
1 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

16
index.js
View file

@ -5620,6 +5620,7 @@ async function showTroubleshooter(initialSection = 'health') {
$(this).addClass('active');
$modal.find('.charMemory_modalSection').removeClass('active');
$modal.find(`.charMemory_modalSection[data-section="${section}"]`).addClass('active');
if (section === 'databank') rebuildDataBankList();
});
// Re-run health checks
@ -5985,14 +5986,18 @@ async function showTroubleshooter(initialSection = 'health') {
await clearAllMemories();
});
// Auto-refresh the Data Bank file list every 2s while the databank section is active
// Auto-refresh the Data Bank file list every 2s while the databank section is active.
// Targets are recomputed each tick so the list updates if the character context changes
// after the modal was opened (e.g. chat loaded after the troubleshooter was opened).
const rebuildDataBankList = () => {
if (!$modal.find('.charMemory_modalSection[data-section="databank"]').hasClass('active')) return;
const currentTargets = getMemoryTargets();
const currentCharName = getCharacterName();
let newHtml = '';
if (!charName || !target) {
if (!currentCharName || !currentTargets.length) {
newHtml = '<div class="charMemory_diagEmpty">No character selected.</div>';
} else if (targets.length > 1) {
for (const t of targets) {
} else if (currentTargets.length > 1) {
for (const t of currentTargets) {
const avatarImg = `<img class="charMemory_groupAvatar" src="/thumbnail?type=avatar&file=${encodeURIComponent(t.avatar)}" alt="" onerror="this.style.display='none'" />`;
newHtml += `<div class="charMemory_tsMemberSection">
<div class="charMemory_tsMemberLabel">${avatarImg}${escapeHtml(t.name)}</div>
@ -6000,11 +6005,12 @@ async function showTroubleshooter(initialSection = 'health') {
</div>`;
}
} else {
newHtml = buildMemberFileList(target);
newHtml = buildMemberFileList(currentTargets[0]);
}
const $list = $('#cm_ts_dataBankList');
if ($list.html() !== newHtml) $list.html(newHtml);
};
rebuildDataBankList(); // Populate immediately so initial render reflects current state
autoRefreshInterval = setInterval(rebuildDataBankList, 2000);
return popup;