mirror of
https://github.com/QwenLM/qwen-code.git
synced 2026-08-07 07:45:54 +00:00
f3ad4fcffb
* fix(serve): allow bounded reads of large text files
* fix(serve): bound large-text reads by scan cost, not by which knob was set
Follow-up to the bounded large-text read path. Three changes:
Gate on any explicit window argument, not on `limit`. Gating on `limit`
had the cost model backwards in both directions: `{ line: 900_000_000,
limit: 20 }` was admitted despite walking the whole file, while
`{ maxBytes: 4096 }` — satisfiable from the first 4 KiB — was refused. A
read with no window argument at all still fails, since a caller that
believes it holds the whole file may write it back truncated.
Add MAX_TEXT_SCAN_BYTES (8 MiB). MAX_READ_BYTES caps what a read
returns; nothing capped what it cost. Line offsets are resolved by
scanning from byte 0, so a query param could turn into an
uninterruptible multi-second scan of an arbitrarily large file — and on
Windows hold a read handle for that span, blocking renames and deletes.
Past the budget the read is refused with `file_too_large` pointing at
readBytes, which reaches any offset in O(1).
Tolerate appends on streamed windows. Requiring whole-file size/mtime
stability after reading a prefix rejected reads whose returned bytes
were still valid, and the case it rejected — tailing a live log — is the
one this path exists for. Streamed windows now assert inode identity
plus "did not shrink"; truncation and replacement are still rejected.
Also: non-UTF-8 large text now returns `binary_file` rather than
`file_too_large`, so a client retrying on 413 with a smaller window
can't loop forever; and `readFileWithLineAndLimit` throws instead of
silently ignoring a caller-supplied `fileHandle` on the by-path
fallback.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* refactor(core): thread the descriptor instead of forking text-read helpers
PR #7947 pinned large-text reads to one inode by threading a caller-owned
FileHandle into readTextRange as an optional field, plus a second field,
forceStreaming, to suppress the buffering fast path. Two optional fields
produced four combinations: one meaningful, one used by a single test, one
unreachable, and — in readFileWithLineAndLimit — one that silently fell
through to a by-path read, defeating the reason the caller opened a handle.
Unify the two encoding detectors. detectFileEncoding now takes a path or a
borrowed handle, so detectFileHandleEncoding is deleted along with the
message discrepancy between them: an encoding iconv-lite cannot load now
raises LargeNonUtf8TextError naming that encoding rather than deferring to
the decoder's generic invalid-utf8 variant. Both still refuse the file, and
the Serve boundary maps both to binary_file.
Split the reader into readTextRange (path) and readTextRangeFromHandle
(always streams, both byte bounds required). The unreachable combination and
its untested readFileHandleBuffer are gone, and with no fileHandle parameter
left for readFileWithLineAndLimit to ignore, the RangeError guarding that
fallthrough is deleted too — the trap can no longer be expressed.
CoreReadTextFileHandleRequest drops its required stats field. Nothing
downstream read it, and because the ACP request type it extends permits
extra properties, TypeScript accepted the dead argument silently.
readFileHandleChunks becomes chunksFromHandle(fh, from) — the one seam
byte-cursor text paging needs.
No observable change at the Serve boundary: its 222 tests pass unmodified.
Two fileSystemService tests were deleted rather than repaired; they asserted
the arguments readFileWithLineAndLimit received, which is nothing once the
handle path stops calling it. Their coverage lives in read-text-range.test.ts
against real files and in workspace-file-system.test.ts at the real boundary.
258 production lines in core, net -71 overall.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* refactor(core): make CoreReadTextFileHandleRequest standalone
Self-audit follow-up to f55c867a. Two fields survived the reshape that the
handle path never reads:
- `stats` was documented as required ("must pass the Stats captured from that
handle") and nothing downstream read it. The handle path always streams, so
it never needs a size to choose a strategy, and the encoding probe does its
own fstat.
- `path` became dead once readTextRangeFromHandle replaced the path-plus-handle
call. Errors are labelled with the path by the Serve boundary that owns it.
Neither was caught by the compiler: the ACP ReadTextFileRequest the type
derived from permits extra properties, so the CLI kept passing both silently.
That is the argument for declaring the type standalone rather than Omit-ing
four of six inherited fields and quietly re-admitting the rest.
Also record the second behaviour delta of the detector merge in the design
doc: detectFileEncoding catches I/O errors and falls back to 'utf-8', where
detectFileHandleEncoding let them propagate. The failure is not lost — a handle
that fails the 8 KiB probe fails the streaming read immediately after — but a
different call now reports it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* feat(serve): page large text files by byte cursor
Line offsets address a byte stream, so `readText` resolves them by scanning
from byte 0. Paging a large log that way is O(n^2) across pages, and past
MAX_TEXT_SCAN_BYTES (8 MiB) a deep page is refused outright — agents had no
O(1) path short of dropping to GET /file/bytes and splitting lines themselves,
losing encoding handling, multibyte safety, and the binary_file refusal.
A response that leaves content behind now returns `hasMore`, and where a file
byte offset is derivable, an opaque `nextCursor`. Passing it back as `cursor`
resumes in O(1). Page 1 is an ordinary `limit` read, so clients never compute
byte offsets themselves, and a paging loop does not break when a file happens
to be small.
The cursor is unsigned base64url JSON carrying {off, size, dev, ino}, matching
encodeOrganizedCursor rather than the HMAC-signed transcript codec: the path is
re-resolved through the workspace boundary on every request, so a forged cursor
can only move the offset within a file the caller may already read — what
GET /file/bytes?offset= allows today. What the payload is for is staleness:
a replaced or truncated file yields hash_mismatch instead of bytes from the
wrong place, while an append leaves an outstanding cursor valid — the case the
feature exists for.
Every minted cursor points at the start of a line. When a single line exceeds
maxOutputBytes the reader emits a truncated prefix and skips to the next line
rather than resuming mid-line, because a mid-line cursor makes the following
page snap forward and silently drop the rest of that line at the seam. Windows
cut mid-line by a byte cap therefore report hasMore with no cursor, as do
non-UTF-8 snapshot reads whose decoded text is a UTF-8 re-encoding with no
mapping back to file offsets. That is why hasMore is a field rather than a
restatement of nextCursor.
Cursor reads branch before the size check, not by widening the window gate:
a cursor read of a file under MAX_READ_BYTES would otherwise land on the
snapshot path, which knows only line/limit, and silently return line 0.
Adds the workspace_file_read_cursor capability, per the convention that new
behavior gets a new tag, and retargets the scan-budget hint at cursor paging.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* fix(core): advance UTF-8 cursors after truncation
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
* docs(serve): clarify cursor bootstrap limits
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
* fix(sdk): raise daemon browser bundle budget
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
* test(serve): cover ACP cursor dispatch and cursor binary_file mapping (#8002)
* fix(core): only set sawCrlf for emitted lines in cursor paging (#8002)
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Co-authored-by: Qwen Code Bot <qwen-code-bot@users.noreply.github.com>
|
||
|---|---|---|
| .. | ||
| adaptive-output-token-escalation | ||
| assets | ||
| auth | ||
| auto-memory | ||
| channels | ||
| compact-mode | ||
| compaction-image-stripping | ||
| ctrl-o-detail-expand | ||
| customize-banner-area | ||
| daemon-acp-http | ||
| daemon-session-artifacts | ||
| daemon-sidechannel-coordination | ||
| daemon-transport-abstraction | ||
| fork-subagent | ||
| hot-reload | ||
| performance | ||
| prompt-cache | ||
| prompt-suggestion | ||
| rt-optimization | ||
| session-crash-recovery | ||
| session-idle-reaper | ||
| session-recap | ||
| session-title | ||
| skill-nudge | ||
| slash-command | ||
| standalone-clipboard-native-addon/assets | ||
| structured-output | ||
| tool-use-summary | ||
| tools | ||
| usage-only-stream-memory/assets | ||
| virtual-viewport | ||
| vp-mouse-selection | ||
| web-shell-pane-header-actions | ||
| 2026-05-15-async-memory-recall-design.md | ||
| 2026-05-21-memory-pressure-monitor-design.md | ||
| 2026-05-26-daemon-logger-design.md | ||
| 2026-05-27-daemon-workspace-service-design.md | ||
| 2026-06-12-session-shell-permission-policy.md | ||
| 2026-06-13-file-history-snapshot-persistence.md | ||
| 2026-06-15-simulated-sed-file-history.md | ||
| 2026-06-23-fix-conflicts-command.md | ||
| 2026-06-24-daemon-clientid-self-heal-design.md | ||
| 2026-06-24-stream-inactivity-timeout-design.md | ||
| 2026-06-30-unified-reasoning-effort-cli.md | ||
| 2026-07-01-channel-lifecycle-status-adapters.md | ||
| 2026-07-01-channel-lifecycle-status-umbrella.md | ||
| 2026-07-01-channel-p0-identity-task-lifecycle-design.md | ||
| 2026-07-05-large-frame-handling-measurement.md | ||
| 2026-07-06-session-start-profiler.md | ||
| 2026-07-07-bounded-replay-snapshot-window.md | ||
| 2026-07-09-webshell-user-message-input-annotations.md | ||
| 2026-07-11-daemon-persistent-workspace-registration.md | ||
| 2026-07-11-daemon-workspace-runtime-removal.md | ||
| 2026-07-11-managed-memory-microcompaction.md | ||
| 2026-07-11-tool-call-preparing-events.md | ||
| 2026-07-13-cold-first-session-support.md | ||
| 2026-07-13-pdf-vision-bridge-fallback.md | ||
| 2026-07-13-workspace-skills-installed-path.md | ||
| 2026-07-14-chat-record-daemon-transcript-block-projection.md | ||
| 2026-07-14-dingtalk-webhook-direct-message.md | ||
| 2026-07-14-silent-command-heartbeat.md | ||
| 2026-07-14-web-shell-readonly-daemon-transcript.md | ||
| 2026-07-15-daemon-log-stable-rotation.md | ||
| 2026-07-15-daemon-session-source-metadata.md | ||
| 2026-07-15-dingtalk-interactive-cards.md | ||
| 2026-07-16-default-background-subagents.md | ||
| 2026-07-16-subagent-prompt-guardrails.md | ||
| 2026-07-16-webshell-git-status-diff.md | ||
| 2026-07-16-webshell-transcript-batched-dispatch.md | ||
| 2026-07-17-adaptive-tool-call-cap.md | ||
| 2026-07-17-daemon-workspace-trust-hot-reload.md | ||
| 2026-07-17-observed-channel-delivery-targets.md | ||
| 2026-07-17-plan-mode-shell-routing.md | ||
| 2026-07-17-workspace-session-info.md | ||
| 2026-07-18-daemon-workspace-display-names.md | ||
| 2026-07-18-observed-channel-group-names.md | ||
| 2026-07-19-lazy-telemetry-sdk-loading.md | ||
| 2026-07-19-telemetry-protocol-split.md | ||
| 2026-07-19-webshell-git-log.md | ||
| 2026-07-19-webshell-worktree-sessions.md | ||
| 2026-07-20-background-agent-hot-continuation.md | ||
| 2026-07-20-plan-mode-mid-turn-guidance.md | ||
| 2026-07-20-skills-default-disabled.md | ||
| 2026-07-20-worktree-empty-state-toggle.md | ||
| 2026-07-21-headless-fork-subagents.md | ||
| 2026-07-21-lazy-undici-loading.md | ||
| 2026-07-21-tool-result-vision-bridge.md | ||
| 2026-07-22-background-agent-roster-restore.md | ||
| 2026-07-22-daemon-mcp-force-reconnect.md | ||
| 2026-07-22-lazy-google-genai-loading.md | ||
| 2026-07-22-webshell-session-git-mode.md | ||
| 2026-07-23-defer-acp-telemetry-initialization.md | ||
| 2026-07-24-generation-stats.md | ||
| 2026-07-24-webshell-git-status-fast-path.md | ||
| 2026-07-25-channel-interaction-presentation-contract.md | ||
| 2026-07-26-manual-plan-exit-notice-delivery.md | ||
| 2026-07-27-github-channel-reason-dispatch.md | ||
| 2026-07-27-revert-pattern-triage-gate.md | ||
| 2026-07-28-user-prompt-submit-context-provenance.md | ||
| 2026-07-28-web-shell-composer-intent-suggestions.md | ||
| 2026-07-29-github-channel-publication-contract.md | ||
| 2026-07-29-handle-bound-text-range-reads.md | ||
| 2026-07-30-web-shell-ask-user-question-submit-retry.md | ||
| acp-channel-initialize-profiling.md | ||
| acp-compile-cache-propagation.md | ||
| acp-model-route-identity.md | ||
| acp-preheat-contract.md | ||
| active-todo-context.md | ||
| auto-classifier-unavailable-fallback.md | ||
| auto-compaction-threshold-redesign.md | ||
| background-agent-status-and-details.md | ||
| certified-session-writer-handoff.md | ||
| channel-delivery-v1.md | ||
| channel-worker-startup-failures.md | ||
| chat-recording-failure-observability.md | ||
| conversation-branch-inspection.md | ||
| cua-driver-mcp-reliability.md | ||
| custom-api-key-auth-wizard-prd.md | ||
| daemon-archived-session-export.md | ||
| daemon-channel-runtime-control.md | ||
| daemon-extension-at-mention.md | ||
| daemon-extension-install-interactions.md | ||
| daemon-first-output-latency.md | ||
| daemon-generation-sse.md | ||
| daemon-global-deep-health.md | ||
| daemon-idle-detection-api.md | ||
| daemon-legacy-session-workspace-telemetry.md | ||
| daemon-multi-workspace-hardening.md | ||
| daemon-multi-workspace-phase1-registry.md | ||
| daemon-multi-workspace-phase2a-sessions.md | ||
| daemon-multi-workspace-phase4-acp.md | ||
| daemon-multi-workspace-phase4b-channel-workers.md | ||
| daemon-multi-workspace-phase4b-voice.md | ||
| daemon-multi-workspace-session-export.md | ||
| daemon-multi-workspace-session-file-ops.md | ||
| daemon-multi-workspace-session-organization-mutations.md | ||
| daemon-session-runtime-status.md | ||
| daemon-skill-toggle.md | ||
| daemon-todo-stop-guard-hardening.md | ||
| daemon-todo-stop-guard.md | ||
| daemon-untrusted-workspace-session-catalog.md | ||
| daemon-workspace-remember.md | ||
| declarative-agents-port.md | ||
| direct-external-context-auto-recall.md | ||
| direct-external-context-provider.md | ||
| dsw-swe-verified-release-pipeline.md | ||
| explicit-plan-exit-approval.md | ||
| extension-file-reload.md | ||
| extension-management-v2.md | ||
| f2-mcp-transport-pool.md | ||
| final-tool-response-budget.md | ||
| fork-resume-live-capabilities.md | ||
| full-turn-multimodal-routing.md | ||
| gen-ai-arms-field-alignment.md | ||
| goal-loop-input-control.md | ||
| issue-4479-token-usage-stats-coordination.md | ||
| java-daemon-sdk-alpha.md | ||
| lazy-first-use-dependencies.md | ||
| learn-video-input.md | ||
| lightweight-jsonc-settings-editor.md | ||
| managed-session-writer-shutdown.md | ||
| markdown-chart-skill-integration.md | ||
| markdown-syntax-extension.md | ||
| mcp-management-runtime-model.md | ||
| mcp-payload-filter.md | ||
| mcp-tool-name-provider-compatibility.md | ||
| monitor-cancel-notification.md | ||
| npm-background-auto-update.md | ||
| openrouter-auth-and-models.md | ||
| prompt-queue-backpressure.md | ||
| serve-large-text-range-consistency.md | ||
| serve-server-final-split.md | ||
| serve-server-split.md | ||
| session-group-custom-hex-colors.md | ||
| session-writer-lease-p0a.md | ||
| shell-safety-classification.md | ||
| shell-timeout-error-semantics.md | ||
| standalone-clipboard-native-addon.md | ||
| subagent-fork-turns.md | ||
| subagent-model-grade.md | ||
| submitted-prompt-provenance.md | ||
| task-notification-transcript-placement.md | ||
| telemetry-llm-request-timing-design.md | ||
| telemetry-outbound-propagation-design.md | ||
| telemetry-resource-attributes-design.md | ||
| telemetry-subagent-spans-design.md | ||
| toolsearch-preload-threshold.md | ||
| trusted-daemon-invocation-context.md | ||
| tui-spacing-density-pr1.md | ||
| tui-user-message-half-line-pr2.md | ||
| untrusted-persisted-transcript.md | ||
| usage-only-stream-memory.md | ||
| vscode-output-channel-logging.md | ||
| web-shell-advanced-table-controls.md | ||
| web-shell-bounded-transcript-and-subagent-details.md | ||
| web-shell-composer-performance.md | ||
| web-shell-composer-workspace-selector.md | ||
| web-shell-custom-slash-command-actions.md | ||
| web-shell-file-previews.md | ||
| web-shell-github-prs.md | ||
| web-shell-history-boundary-pagination.md | ||
| web-shell-history-pagination.md | ||
| web-shell-markdown-chart.md | ||
| web-shell-monitor-details.md | ||
| web-shell-non-primary-session-archive-hardening.md | ||
| web-shell-pane-header-actions.md | ||
| web-shell-plugin-shadow-surfaces.md | ||
| web-shell-prompt-send-failure-retry.md | ||
| web-shell-secondary-workspace-voice.md | ||
| web-shell-selective-shadow-dom.md | ||
| web-shell-session-created-callback.md | ||
| web-shell-session-source-filter.md | ||
| web-shell-skill-manager-page.md | ||
| web-shell-table-selection-statistics.md | ||
| web-shell-voice-mode.md | ||
| web-shell-workspace-history-session-drafts.md | ||
| webshell-composer-placeholders.md | ||
| webshell-mention-icon-chips.md | ||
| webshell-voice-button-visibility.md | ||
| workflow-tracing-gaps.md | ||
| workspace-agents-api.md | ||
| workspace-generation.md | ||
| worktree.md | ||
| yaml-parser-replacement.md | ||