Self-review found several sections of the banner customization design
doc still framed for the original three settings; bring them in line
with the four-setting reality landed in c7aa4a401:
- Region taxonomy ASCII diagram now shows four B-rows
(① title, ② subtitle, ③ status, ④ path).
- Resolution-pipeline ASCII diagram and step list pick up
customBannerSubtitle on the input side and the title/subtitle
sanitize step on the resolver side.
- "Settings schema additions" section lists the fourth entry,
customBannerSubtitle, and notes the customAsciiArt
jsonSchemaOverride that landed for VS Code schema reproducibility.
- "Wiring changes" section updates the Header prop list and the
HeaderProps interface, replaces the brittle line-number anchors
with file-level anchors, drops the obsolete `paths` second arg
from resolveCustomBanner, and adds the trust-gate sentence.
- "Security & failure handling" table replaces the
stripTerminalControlSequences shorthand with the actual
banner-specific stripper, splits the title/subtitle row to cover
both, and adds the untrusted-workspace gate as its own row.
- "Verification plan" gains two scenarios: the subtitle row, and
the untrusted-workspace check that the Critical reviewer comment
on the impl PR explicitly asked us to lock down.
Mirrored every edit in the zh-CN translation. The implementation
itself is unchanged.
Generated with AI
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
d4d315d3fe