mirror of
https://github.com/QwenLM/qwen-code.git
synced 2026-08-22 07:04:58 +00:00
* fix(web-shell): render a plain textarea composer on touch devices Mobile browsers could not type into the Web Shell composer (#5958): CodeMirror's contenteditable interacts poorly with virtual keyboards, and three non-gesture view.focus() calls claim activeElement on iOS without opening the keyboard, after which taps may never refocus the editor. On touch devices ('(hover: none) and (pointer: coarse)' plus maxTouchPoints > 0 — touch laptops keep the desktop editor) useComposerCore now skips creating an EditorView entirely and exposes a mobileComposer backend that ChatEditor renders as a controlled <textarea> at the same mount point. The internal submit pipeline was hoisted out of the editor-creation effect and accepts view: EditorView | null, so history, prompt building, tags, images, and slash/! text interpretation are shared unchanged between both backends. Enter inserts a newline natively; submission goes through the Send button. Programmatic (non-gesture) focus is additionally suppressed on coarse-pointer devices even when CodeMirror is forced, and ?composer=textarea|codemirror serves as a debugging and rollback escape hatch. The choice is frozen at mount so a mid-session flip cannot drop the draft. Known textarea-backend degradations (commands still work as typed text): no slash/@ completion menus, no inline tag chips (fall back to the top placement), no history arrow navigation, no large-paste placeholders, and no followup Tab-accept. Fixes #5958 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(web-shell): address review — textarea auto-grow, change notifications, caret restore Address the five inline review suggestions on #7587: - Auto-grow the mobile textarea with its content, capped by the computed CSS max-height (so --chat-editor-input-max-height overrides stay authoritative). Previously rows={1} plus resize:none meant multi-line drafts scrolled inside ~1.5 visible lines and the CSS max-height was dead. Asserted in the mobile e2e spec via bounding-box growth. - Fire onInputTextChange from setMobileText, matching the CodeMirror updateListener contract: programmatic draft changes (setText, history restore, post-submit clear) now notify parent trackers too. handleMobileChange delegates to setMobileText. - Restore the caret after mobile insertText: a controlled textarea resets the caret to the end on value change; setSelectionRange puts it back after React re-renders (rAF with a setTimeout fallback), matching the CodeMirror path's explicit selection anchor. - Cover the mobile submitSearchMatch path: select a history match, submit through the shared pipeline, draft cleared. - Cover the ChatEditor mobile quick-action gating: the history quick action opens the search UI (never dispatches into a missing EditorView) and the keyboard shortcut hints grid is hidden on the mobile composer with a desktop control. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(web-shell): decide the touch composer by media query alone Independent macOS verification on #7587 found that Playwright's stock WebKit iPhone profiles match '(hover: none) and (pointer: coarse)' but report navigator.maxTouchPoints === 0, so the automatic detection selected CodeMirror under unmodified WebKit emulation. The maxTouchPoints requirement added nothing the AND media query does not already provide: touch laptops are excluded by the query itself (their primary pointer hovers and is fine), and the only devices that match the query with zero touch points are emulated profiles and TV-style browsers, where the plain textarea is a safe fallback. Dropping it makes stock iPhone/WebKit Playwright runs exercise the automatic detection branch. Real-device behavior is unchanged: phones and tablets match the query and report touch points either way. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(web-shell): keep the mobile textarea scrollable past its height cap As .editorArea's last child the textarea inherited `overflow: clip` from the `.editorArea > :last-child` wrapper rule (written for the CodeMirror container, whose inner .cm-scroller does the scrolling). `clip` also forbids programmatic scrolling, so once auto-grow reached the CSS max-height, content beyond the cap was unreachable — scrollTop stayed pinned at 0. Override with `overflow-y: auto` via `.editorArea > textarea.mobileTextarea` (the extra type selector outweighs the wrapper rule's specificity). New mobile e2e regression fills 20 lines, asserts growth stops at the computed 300px cap, and verifies the overflow stays reachable: scrollHeight above clientHeight and scrollTop actually moving to the bottom — the exact probe from the review, which pinned at 0 before this fix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: ComplexSimply <rudy.arrowsong@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
65 lines
2.4 KiB
TypeScript
65 lines
2.4 KiB
TypeScript
/**
|
|
* @license
|
|
* Copyright 2025 Qwen Team
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
import { useState } from 'react';
|
|
|
|
/**
|
|
* Matches devices whose primary interaction is a touchscreen with no hover —
|
|
* phones and tablets. The AND of both features deliberately excludes touch
|
|
* laptops (hover-capable trackpad + touchscreen), which keep the desktop
|
|
* CodeMirror editor.
|
|
*/
|
|
export const TOUCH_COMPOSER_QUERY = '(hover: none) and (pointer: coarse)';
|
|
|
|
/**
|
|
* Raw device detection, ignoring the URL override. Used to gate programmatic
|
|
* (non-gesture) `view.focus()` calls: on iOS, focusing an editable element
|
|
* outside a user gesture does not open the keyboard but does claim
|
|
* `document.activeElement`, after which user taps may no longer fire a fresh
|
|
* focus event — the keyboard never appears. That must stay suppressed even
|
|
* when the user forces the CodeMirror path via `?composer=codemirror`.
|
|
*
|
|
* The media query alone decides — deliberately no `navigator.maxTouchPoints`
|
|
* requirement: Playwright's stock WebKit iPhone profiles (and some TV
|
|
* browsers) match the query while reporting zero touch points, and the
|
|
* textarea is a safe fallback wherever the primary pointer is coarse and
|
|
* cannot hover.
|
|
*/
|
|
export function isCoarsePointerDevice(): boolean {
|
|
if (
|
|
typeof window === 'undefined' ||
|
|
typeof window.matchMedia !== 'function'
|
|
) {
|
|
return false;
|
|
}
|
|
return window.matchMedia(TOUCH_COMPOSER_QUERY).matches;
|
|
}
|
|
|
|
function resolveTouchComposer(): boolean {
|
|
if (typeof window !== 'undefined') {
|
|
// Escape hatch for debugging and rollback: ?composer=textarea forces the
|
|
// mobile backend, ?composer=codemirror forces the desktop editor.
|
|
const override = new URLSearchParams(window.location.search).get(
|
|
'composer',
|
|
);
|
|
if (override === 'textarea') return true;
|
|
if (override === 'codemirror') return false;
|
|
}
|
|
return isCoarsePointerDevice();
|
|
}
|
|
|
|
/**
|
|
* Decides once, at mount, whether the composer should use the plain
|
|
* `<textarea>` backend instead of CodeMirror. Intentionally NOT reactive:
|
|
* swapping editor backends mid-session would drop the draft, tags, and
|
|
* pasted images, so the choice is frozen for the lifetime of the component.
|
|
* Degrades to `false` (CodeMirror) when `matchMedia` is unavailable
|
|
* (SSR / the jsdom test default).
|
|
*/
|
|
export function useIsTouchComposer(): boolean {
|
|
const [isTouch] = useState<boolean>(resolveTouchComposer);
|
|
return isTouch;
|
|
}
|