qwen-code/packages/web-shell/client/components/dialogs/DeleteSessionDialog.test.tsx
carffuca 5c9e73f371
feat(web-shell): overhaul list-dialog interaction, keyboard nav & a11y (#6128)
* feat(web-shell): add keyboard-nav and IME-safe filter hooks

Two reusable hooks for list-style dialogs:

- useListboxKeyboard: Arrow/Home/End/Enter navigation driven by an active
  index, with a "keyboard mode" flag to suppress hover. Yields modified-key
  combos (Cmd/Ctrl/Alt/Shift), Home/End in text inputs, and Enter on focused
  buttons/links to native handling.
- useFilterInput: IME-composition-safe search state so a filtered list does
  not refire on every intermediate pinyin character (commits on compositionend).

* feat(web-shell): DialogShell Escape/backdrop close and focus management

Give every dialog shared, accessible dismissal and focus behaviour:
- Escape closes (guarded during IME composition so it cancels the
  composition, not the dialog)
- click on the backdrop closes
- Tab is trapped within the panel, wrapping at both ends
- focus moves into the dialog on open and is restored to the opener on close

* feat(web-shell): overhaul list-dialog interaction and accessibility

Unify interaction across the model, theme, approval, resume, tools, delete,
release and rewind dialogs:

- keyboard navigation via useListboxKeyboard, with a roving highlight that
  opens on the current value and does not fight the mouse
- consistent selection visuals: a single roving highlight plus a persistent
  "current" accent bar + checkmark; options are role=option divs (no stray
  focus ring)
- IME-safe search via useFilterInput; fix Chinese-input jitter in the
  resume/delete/release search boxes
- accessibility: role=listbox/option, aria-activedescendant, and aria-selected
  bound to the current value rather than the roving highlight
- destructive dialogs keep Enter non-destructive where a confirm button is the
  commit (delete/release); rewind confirms on Enter like a single-select picker

Refactors:
- extract shared SessionRow used by resume/delete/release
- rename resume-picker-* CSS primitives to picker-* (they are shared by all
  list dialogs, not resume-specific)

Adds regression tests for the model duplicate-current fix, release hover
selection, rewind Enter, the listbox/aria wiring, and the shared hooks.

* fix(web-shell): address dialog interaction review feedback

Follow-up fixes from upstream review:
- DialogShell closes on completed backdrop clicks instead of mousedown, and its
  Tab trap now also catches the panel-focused fallback case
- ToolsDialog now has full listbox semantics (ids, aria-activedescendant,
  aria-expanded)
- Rewind keeps the roving cursor separate from the confirmed target; Enter only
  confirms, and the danger button executes the rewind
- Model/Approval aria-selected now reflects the actual current value; model
  highlights stay in bounds when the model list shrinks
- Home/End and modified arrow-key combos yield to native text navigation in
  search inputs; Escape yields to IME composition in DialogShell
- Dead picker CSS and duplicate declarations removed; extra regression tests
  added for reviewer-raised edge cases

* fix(web-shell): harden shared dialog keyboard and IME handling

* fix(web-shell): tighten dialog shell focus, stacking, and backdrop behavior

* fix(web-shell): align list dialog selection semantics and add coverage
2026-07-02 12:19:17 +00:00

255 lines
6.7 KiB
TypeScript

// @vitest-environment jsdom
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import { act } from 'react';
import { createRoot, type Root } from 'react-dom/client';
import { I18nProvider } from '../../i18n';
import { dp } from './dialogStyles';
Object.assign(globalThis, { IS_REACT_ACT_ENVIRONMENT: true });
if (!Element.prototype.scrollIntoView) {
Element.prototype.scrollIntoView = () => {};
}
let sessions = [
{
sessionId: 's0',
displayName: 'S0',
clientCount: 1,
updatedAt: '2026-01-01T00:00:00Z',
},
{
sessionId: 's1',
displayName: 'S1',
clientCount: 1,
updatedAt: '2026-01-01T00:00:00Z',
},
{
sessionId: 'me',
displayName: 'Current Session',
clientCount: 1,
updatedAt: '2026-01-01T00:00:00Z',
},
];
const deleteSessionMock = vi.fn();
const deleteSessionsMock = vi.fn();
const initialSessions = sessions.slice();
vi.mock('@qwen-code/webui/daemon-react-sdk', () => ({
useConnection: () => ({ sessionId: 'me' }),
useSessions: () => ({
sessions,
loading: false,
error: undefined,
deleteSession: deleteSessionMock,
deleteSessions: deleteSessionsMock,
}),
}));
const { DeleteSessionDialog } = await import('./DeleteSessionDialog');
let container: HTMLDivElement | null = null;
let root: Root | null = null;
let onDeleted: ReturnType<typeof vi.fn>;
let onError: ReturnType<typeof vi.fn>;
let onClose: ReturnType<typeof vi.fn>;
function renderDialog() {
root!.render(
<I18nProvider language="en">
<DeleteSessionDialog
onDeleted={onDeleted}
onError={onError}
onClose={onClose}
/>
</I18nProvider>,
);
}
function mount() {
onDeleted = vi.fn();
onError = vi.fn();
onClose = vi.fn();
container = document.createElement('div');
document.body.appendChild(container);
root = createRoot(container);
act(() => {
renderDialog();
});
}
function rerender() {
act(() => {
renderDialog();
});
}
function rows(): HTMLElement[] {
return Array.from(container!.querySelectorAll('[role="option"]'));
}
function dangerButton(): HTMLButtonElement {
return Array.from(container!.querySelectorAll('button')).find((b) =>
b.className.includes(dp('dialog-danger-button')),
) as HTMLButtonElement;
}
function press(key: string) {
act(() => {
window.dispatchEvent(
new KeyboardEvent('keydown', { key, bubbles: true, cancelable: true }),
);
});
}
function clickRow(index: number) {
act(() => {
rows()[index].dispatchEvent(new MouseEvent('click', { bubbles: true }));
});
}
const nativeInputValueSetter = Object.getOwnPropertyDescriptor(
window.HTMLInputElement.prototype,
'value',
)!.set!;
function typeFilter(value: string) {
act(() => {
const el = container!.querySelector('input')!;
nativeInputValueSetter.call(el, value);
el.dispatchEvent(new Event('input', { bubbles: true }));
});
}
const isCursor = (el: HTMLElement) => el.className.includes(dp('selected'));
const isChecked = (el: HTMLElement) => el.textContent?.includes('[x]') === true;
beforeEach(() => {
deleteSessionMock.mockReset();
deleteSessionsMock.mockReset();
});
afterEach(() => {
act(() => root?.unmount());
container?.remove();
root = null;
container = null;
sessions = initialSessions.slice();
});
describe('DeleteSessionDialog selection', () => {
it('keeps the keyboard cursor separate from the checked set; Enter only toggles', () => {
mount();
// Opens with no highlight and nothing checked; delete stays disabled.
expect(rows().some(isCursor)).toBe(false);
expect(rows().some(isChecked)).toBe(false);
expect(dangerButton().disabled).toBe(true);
// The first ArrowDown lands the cursor on row 0 without checking it.
press('ArrowDown');
expect(isCursor(rows()[0])).toBe(true);
expect(isChecked(rows()[0])).toBe(false);
expect(dangerButton().disabled).toBe(true);
// Enter toggles the cursor row's checkbox — it must not delete anything.
press('Enter');
expect(isChecked(rows()[0])).toBe(true);
expect(dangerButton().disabled).toBe(false);
expect(deleteSessionsMock).not.toHaveBeenCalled();
expect(deleteSessionMock).not.toHaveBeenCalled();
expect(onClose).not.toHaveBeenCalled();
// Moving the cursor keeps prior checks intact (multi-select).
press('ArrowDown');
expect(isCursor(rows()[1])).toBe(true);
expect(isChecked(rows()[0])).toBe(true);
expect(isChecked(rows()[1])).toBe(false);
press('Enter');
expect(isChecked(rows()[1])).toBe(true);
// Enter on an already-checked row unchecks it.
press('Enter');
expect(isChecked(rows()[1])).toBe(false);
expect(isChecked(rows()[0])).toBe(true);
});
it('does not check the current session row', () => {
mount();
clickRow(2);
expect(isChecked(rows()[2])).toBe(false);
expect(dangerButton().disabled).toBe(true);
// Keyboard Enter on the current session row must not check it either.
press('ArrowDown');
press('ArrowDown');
press('ArrowDown');
expect(isCursor(rows()[2])).toBe(true);
press('Enter');
expect(isChecked(rows()[2])).toBe(false);
expect(dangerButton().disabled).toBe(true);
});
it('clears checked rows and disarms delete when the filter changes', () => {
mount();
clickRow(0);
clickRow(1);
expect(isChecked(rows()[0])).toBe(true);
expect(isChecked(rows()[1])).toBe(true);
expect(dangerButton().disabled).toBe(false);
typeFilter('s1');
expect(rows()).toHaveLength(1);
expect(isChecked(rows()[0])).toBe(false);
expect(rows().some(isCursor)).toBe(false);
expect(dangerButton().disabled).toBe(true);
});
it('prunes stale checked ids after an unfiltered session refresh', async () => {
mount();
clickRow(0);
clickRow(1);
expect(dangerButton().disabled).toBe(false);
sessions = [
{
sessionId: 'me',
displayName: 'Current Session',
clientCount: 1,
updatedAt: '2026-01-01T00:00:00Z',
},
];
rerender();
expect(rows()).toHaveLength(1);
expect(isChecked(rows()[0])).toBe(false);
expect(dangerButton().disabled).toBe(true);
});
it('deletes the checked sessions via the batch API and closes', async () => {
deleteSessionsMock.mockResolvedValue({
removed: ['s0', 's1'],
notFound: [],
errors: [],
});
mount();
clickRow(0);
clickRow(1);
expect(dangerButton().disabled).toBe(false);
await act(async () => {
dangerButton().dispatchEvent(new MouseEvent('click', { bubbles: true }));
});
expect(deleteSessionsMock).toHaveBeenCalledWith(['s0', 's1']);
expect(onDeleted).toHaveBeenCalledWith(['s0', 's1']);
expect(onClose).toHaveBeenCalledTimes(1);
expect(onError).not.toHaveBeenCalled();
});
});