2 commits

Author	SHA1	Message	Date
Shaojin Wen	076427650d	feat(ci): auto-open a deflake fix issue for confirmed flaky tests (#7231) ... * feat(ci): auto-open a deflake fix issue for confirmed flaky tests The CI Failure Patrol reruns flaky failures but never fixes them, so the same tests flake forever on a rerun treadmill. This closes the loop: when the patrol classifies a rerun as a nondeterministic TEST (not infra), it now also opens ONE deflake issue that the existing autofix issue pipeline develops into a reviewable stabilization PR. - ci-flaky-patrol SKILL: a rerun decision whose cause is a specific named flaky test carries an optional flakyTest {file, name}; infra reruns (ENOSPC, network, runner death) never do. - ci-flaky-rerun.mjs: validates flakyTest (malformed → the whole decision is rejected, so a bad classification can't open a bogus issue); after a rerun, ensureDeflakeIssue upserts a deflake issue deduped by a stable (file, name) marker — one open issue per flaky test across all PRs — labeled status/ready-for-agent + autofix/ approved so the scheduled autofix scan picks it up. - .qwen/skills/deflake/SKILL.md: constrains the fix to four assertion-preserving patterns (raise timeout/poll budget, stabilize timing/waiting, make randomness/time deterministic, isolate interference) and forbids skipping/deleting/loosening the check; write failure.md if none applies or the failure looks like a real bug. The produced PR is reviewable, never auto-merged. Tests: deflakeKey stability/collision-freedom, the bilingual issue body, one-issue-per-test dedup, no issue for infra reruns, and malformed-flakyTest rejection. 34/34 across both patrol suites. * fix(ci): deflake review hardening — rerun survives bad metadata, no markup injection Addresses the two Criticals + suggestions on #7231: - **Critical: a malformed/over-length flakyTest no longer kills the rerun.** flakyTest validation is removed from validDecision (which gated the PRIMARY action on secondary metadata — a >200-char nested test name or a null silently dropped a valid rerun). Well-formedness is now checked in ensureDeflakeIssue, which simply skips the deflake issue when the metadata is bad; the rerun always stands. - **Critical: markup/mention injection via the test path/name.** file and name are code-span-stripped of backticks (which cannot be escaped inside a span and would break out into live Markdown, turning into a mention in a bot-created issue) and both now sit in code spans. safeReason alone did not close this (it does not touch backticks). - Best-effort deflake: ensureDeflakeIssue is wrapped in try/catch so a transient createIssue failure — after the marker is already posted — no longer surfaces as a misleading "skipping PR" and permanently suppresses the deflake; it retries on the next flaky occurrence. - Run link uses the patrol's own repo (client.repo) instead of the dead target.repo, so deflake issues on a fork don't 404. - Body reworded: it no longer claims the rerun already passed (it runs right after the rerun is triggered) — it says a real deterministic failure is NOT flakiness and must not be stabilized. - SKILL: bound file/name to 200 chars, and note a malformed one is ignored (never drops the rerun). Tests: malformed flakyTest keeps rerun (no createIssue); long title truncates ≤240; backtick path/name cannot inject; run link honors the repo; a throwing createIssue leaves the rerun intact. 38/38. --------- Co-authored-by: wenshao <wenshao@example.com>	2026-07-19 16:49:29 +00:00
易良	d4c15f05c5	feat(ci): add automated PR failure patrol (#6766) ... * feat(ci): add stale failure patrol * fix(ci): harden failure patrol * refactor(ci): simplify flaky rerun patrol * docs(ci): clarify flaky patrol skill boundary * feat(ci): patrol stale PR failures * fix(ci): prefilter failed PRs * fix(ci): isolate patrol classification * fix(ci): revalidate stale patrol actions * fix(ci): verify main before branch update * fix(ci): classify all stale PR failures * fix(ci): bound patrol batches * fix(ci): persist patrol failure state * fix(ci): harden patrol state transitions * fix(ci): harden stale failure patrol * fix(ci): continue patrol after expired logs * fix(ci): tighten patrol guardrails * fix(ci): preserve failure context in patrol logs * fix(ci): harden stale patrol closeout * fix(ci): paginate patrol marker comments * fix(ci): harden patrol action guards * test(ci): cover patrol guard rails * fix(ci): harden patrol marker parsing * fix(ci): address patrol review followups * test(ci): cover patrol review edges * fix(ci): record patrol rerun marker first * fix(ci): harden patrol review edge cases * fix(ci): tighten stale failure patrol markers * refactor(ci): simplify flaky rerun patrol (2838→1258 lines) - Remove classification guards from actOnDecision (confidence check, action enum validation, boundedReason, update_branch multi-guard chain) - Move classification rules to SKILL.md prompt - Delete 40 source-code text matching tests, keep 20 behavior tests - Merge identity job into classify, remove SHA verification - Change scan sort order from oldest-first to newest-first - Remove unused functions: writeSkillInputs, failureKey, boundedReason, canAct, skillCandidate, mainRunSucceeded * fix(ci): show gh stderr in top-level error output When gh CLI returns non-zero exit, execFile rejects with an error whose .stderr contains the actual GitHub API diagnostic. Previously only one of stderr or message was shown; now both are printed. * fix(ci): address patrol review findings * fix(ci): make stale patrol actions recoverable * refactor(ci): simplify flaky rerun patrol * fix(ci): close flaky patrol review gaps * fix(ci): restore PR failure patrol actions * fix(ci): harden failure patrol scanning * fix(ci): address patrol review follow-ups * fix(ci): harden patrol parsing and coverage * fix(ci): classify failures against PR changes * fix(ci): harden patrol script input handling * fix(ci): remove unsafe auto branch update * test(ci): exercise patrol action limit * fix(ci): bind patrol actions to current evidence * fix(ci): count patrol actions per PR * fix(ci): redact quoted secret labels --------- Co-authored-by: Shaojin Wen <shaojin.wensj@alibaba-inc.com>	2026-07-15 00:51:11 +00:00