4 commits

Author	SHA1	Message	Date
Shaojin Wen	93ccdf4070	feat(web-shell): maximize a single split pane (#6951) ... * feat(web-shell): maximize a single split pane Add a per-pane maximize/restore toggle to the split view. Clicking it makes one pane fill the whole split and hides the others; the hidden panes stay mounted so their sessions keep streaming (a purely visual solo). Restore via the header button or Escape — Escape defers to the composer, the add-session picker, and open dialogs so it never steals their key. The toggle only appears with 2+ panes, adding a session exits maximize to reveal the new pane, and the maximize is dropped whenever its pane leaves the set or the split shrinks to a single pane. * refactor(web-shell): use lucide icons for the maximize toggle; cover switch + picker-Escape Address review on #6951: - Swap the hand-written Maximize2/Minimize2 SVG paths for the named lucide-react components, per the web-shell icon convention (README) and matching DialogShell. - Add tests for moving maximize between panes (guards the toggle's switch branch) and for Escape closing the add-session picker without un-maximizing (guards the pickerOpen deferral). --------- Co-authored-by: wenshao <wenshao@example.com>	2026-07-15 12:10:29 +00:00
Shaojin Wen	720d26b1bb	feat(web-shell): flesh out the multi-workspace split view (cross-workspace sessions, workspace labels, responsive layout) (#6746) ... * fix(web-shell): surface cross-workspace sessions in split view & overview The split-view "add session" picker and the Session Overview only listed the primary workspace's sessions, so on a multi-workspace daemon (`qwen serve --workspace A --workspace B …`) sessions in non-primary workspaces could not be picked into a split pane or triaged from the overview — even though the sidebar already lists them and the load path already drives them. Both surfaces now merge the primary workspace's sessions with the live sessions of every other trusted workspace, label each session by its workspace, and — in the split view — attach each pane under its session's own workspace so a non-primary session no longer 409s against the primary cwd. On a single-workspace daemon the behavior is unchanged. - add useOtherWorkspaceSessions: fans out listWorkspaceSessions over the non-primary trusted workspaces in capabilities.workspaces (Promise.allSettled, tolerant of one failing), and empty on a single-workspace daemon - SplitView: merge the lists, tag picker items by workspace, and pass each pane's workspaceCwd to its DaemonSessionProvider - SessionOverviewPanel: merge the lists and add a per-card workspace badge - add utils/workspace helpers, plus unit tests across all four surfaces * fix(web-shell): repair stale composerTagIcons import that broke the build ScheduledTasksDialog imported getComposerTagIconUrl from `../composerTagIcons`, a module deleted when the helper was consolidated into `utils/composerTag.ts`. The stale path failed `vite build` (and the web-shell browser-regression e2e). Point it at the current location. * fix(web-shell): address review feedback for cross-workspace sessions - useOtherWorkspaceSessions: return the shared EMPTY sentinel when every workspace responds empty (skip a no-op re-render), guard the load effect against a stale in-flight fetch overwriting a newer one, and keep the single-workspace path fully synchronous (no fetch, no post-render setState) - fetch non-primary workspaces at the primary list's page size so a busy workspace is not truncated at the daemon's smaller default - split picker: tag primary sessions with the same localized "primary" label the Session Overview uses, so both surfaces read consistently - tests: cover reload(), the poll re-query, empty-primary merge, and the primary badge render; quieten the act() warnings * feat(web-shell): show each split pane's workspace in its composer placeholder In a multi-workspace split, once a session becomes a pane there was nothing indicating which workspace it belongs to. Name the pane's own workspace in the composer placeholder ("Message this session in <workspace>…"), so it's clear which workspace a message is going to before you send it. Single-workspace daemons are unchanged. * Revert "feat(web-shell): show each split pane's workspace in its composer placeholder" This reverts commit c58e667127. * feat(web-shell): label each split pane's workspace in its composer toolbar On a multi-workspace daemon, split-view panes can hold sessions from different workspaces, but nothing showed which workspace a pane's message would go to. Add a compact, non-interactive workspace chip to the pane composer toolbar (next to where the git-branch chip sits), mirroring GitBranchIndicator. The chip renders only on a multi-workspace daemon, is fed each pane's workspace explicitly by the split view (which knows it per session), and keeps its label visible as panes narrow — only tightening and truncating rather than collapsing to an icon — since it is the pane's identity. * feat(web-shell): show the workspace chip in the main composer too Extend the per-pane workspace label to the main (single-session) chat composer: on a multi-workspace daemon the composer toolbar now names the current session's workspace, so it is always clear which workspace a message targets — not only in split view. Place the workspace chip before the git-branch chip. Reuses the existing WorkspaceIndicator and `workspace` toolbar action, fed from the active connection's capabilities and workspace cwd. * fix(web-shell): keep a session when a shrink closes the split view When the viewport shrinks below the large-screen breakpoint the split view auto-closes and folds back to the single chat. If that chat had no session of its own — the common case when the split was opened straight from the Session Overview or a `?split=a,b` link — the user was stranded on an empty "new chat". Fall back to the split's first pane instead. Best-effort and gated to the uncontrolled (standalone) split: a load failure (e.g. a non-primary-workspace session the single connection cannot own) simply leaves the empty chat, i.e. the previous behavior. * fix(web-shell): restore the split view when the screen grows back A shrink below the large-screen breakpoint folds the split view down to the single chat (its entry points are hidden on small screens). That fold used to be permanent — widening the window back left the user on a single chat with their panes gone. Fold it away only temporarily instead: remember that a shrink folded it, and restore the same split once the screen grows back past the breakpoint, so a transient resize is lossless. Standalone/uncontrolled split only; a controlled host still owns its own split lifecycle. While folded, the narrow chat still falls back to the split's first pane so it isn't an empty new chat. * fix(web-shell): keep the chat's git branch when folding the split on shrink Folding the split on a shrink no longer switches the single chat's session. The previous shrink-time loadSession(firstPane) re-pointed the main connection at the split's first pane; when that pane lived in a different (e.g. git-less) workspace it wiped the chat's git branch — and more broadly changed the session/URL the user drops back to. Fold the split away without touching the chat's connection, so its session, git branch and URL are exactly what they were once the screen grows back. * feat(web-shell): auto-collapse the sidebar in a narrow split view In split view the session sidebar competes with the panes for width. Below 1200px it now auto-collapses to its icon rail so the panes get the room, and expands again once the window grows back — the session list and the "New chat" label no longer eat space a narrow split needs. A wide split (>= 1200px) keeps the full sidebar and the user's own collapse preference; nothing changes outside split view. * test(web-shell): cover the cross-workspace fetch race, quiet split-picker act() warnings Address review suggestions on the cross-workspace session listing: - useOtherWorkspaceSessions: add a test that a stale in-flight fetch is discarded by the `cancelled` guard when the target workspace set changes mid-flight (a workspace registered/unregistered while a list is loading). - SplitView: flush after opening the picker so the reload()/reloadOther() the picker-open effect fires no longer leak act() warnings in the two cross-workspace tests. * test(web-shell): use a valid DaemonMode and assert the pane workspace prop Two review suggestions on the cross-workspace tests: - workspace.test.ts: the caps() mock used `mode: 'workspace'`, not a valid DaemonMode (`'http-bridge' | 'native'`) — use `'native'`. - SplitView.test.tsx: the ChatPane mock now captures `workspaceCwd`, and the cross-workspace attach test asserts the pane receives it (for the composer chip) — so dropping that prop pass-through would now fail the test rather than only the provider's `data-workspace`. * perf(web-shell): memoize pane toolbar actions; cover chip tooltip fallback & deep-link remount Address review suggestions on the composer workspace chip: - ChatPane: memoize `paneToolbarActions` so its array identity is stable — ChatEditor is `React.memo`, and a fresh `[...]` each render defeated it, re-rendering the composer on every pane render. - ChatEditor.test: cover the `workspaceTitle ?? workspaceName` tooltip fallback (chip rendered with a name but no explicit title). - SplitView.test: cover the deep-link remount path — a pane mounted before the other-workspace fan-out resolves remounts under its own workspace once `workspaceCwdById` populates (pane key `b1:` → `b1:/wsB`). --------- Co-authored-by: qwen-code-dev-bot <qwen-code-dev-bot@users.noreply.github.com>	2026-07-12 11:55:21 +00:00
ytahdn	6e096cf16c	fix(web-shell): align split view chat interactions (#6633) ... * fix(web-shell): align split chat interactions * fix(web-shell): preserve split pane drafts on send failure --------- Co-authored-by: ytahdn <ytahdn@gmail.com>	2026-07-10 04:19:42 +00:00
Shaojin Wen	f41e95ac18	feat(web-shell): add Session Overview panel and in-window split view (#6400) ... * feat(web-shell): add Session Overview panel and in-window split view Add a large-screen "Session Overview" mission-control panel and an in-window split view so users can monitor and drive multiple daemon sessions at once. - SessionOverviewPanel: ranked live cards (needs-approval -> running -> idle) merging the workspace session list with the detail=full status report. Multi-select opens the selected sessions as a split view in the current tab ("Open in split") or in a new browser tab ("Open in new tab", via a ?split=a,b URL). - SplitView + ChatPane: one DaemonWorkspaceProvider hosting N DaemonSessionProvider panes, each a self-contained interactive chat (transcript, composer, streaming, tool/ask approvals). Browser focus scopes the keyboard per pane, so panes never contend over approvals. - Sidebar entry points gated to large screens; the split view's Back returns to the Session Overview. * refactor(web-shell): address review feedback on the session overview / split view - SessionOverviewPanel: prune the selection Set when a session leaves the list (so a reappearing session isn't silently reselected) and make select-all use the intersection rather than prev.size. - Extract isAskUserPermission into a shared util so App.tsx and ChatPane.tsx no longer keep verbatim copies that can drift. - SplitView: dismiss the "add session" picker on Escape or a click outside it. - Tests: MAX_PANES cap, popup-blocked path, checkbox-selects-without-navigating, stale-selection pruning, and a direct test for the extracted util. * fix(web-shell): address /review findings on the split view - ToolApproval: add a `keyboardActive` prop; split panes pass false so global Enter/Escape/digit shortcuts can't confirm the wrong session's approval, and the outer session's approval overlay is no longer rendered behind the split (where it would keep its global shortcuts while hidden). - ChatPane: defer the composer commit until sendPrompt resolves, so a rejected prompt (transcript loading / disconnected / turn active) preserves the draft instead of silently dropping it. - SplitView: include a per-mount nonce in each pane's clientId so two tabs opening the same split don't share a client id — which suppressOwnUserEcho would treat as a self-echo and drop from the transcript. - SessionOverviewPanel: cap the split selection to MAX_SPLIT_PANES before building the ?split= URL or opening the in-window split, with a hint when more are selected; also dismiss the split picker on Escape / click-outside. - Tests covering each. * fix(web-shell): address second /review round on the split view - SplitView: wrap each pane in its own ErrorBoundary, so a render crash in one pane (malformed block, unexpected tool shape) shows an inline fallback with a close action instead of white-screening the whole split. - splitUrl / overview: carry the daemon token into the new-tab split URL's fragment. The current tab has already stripped the token from its URL, so a token-auth (`serve --open`) deployment would otherwise open the split tab unauthenticated. The token rides the hash (never sent to the server / logs). - Tests: per-pane error isolation, token-in-fragment (and none without a token), and the overview polling effects (interval fires, document.hidden skips, and the in-flight guard prevents overlapping polls). * fix(web-shell): hide the outer chat under the split and share app-level contexts - App: hide (display:none) + aria-hide the outer chat subtree whenever mainView !== 'chat', not only when a panel is open. Previously the outer chat/composer/toolbar stayed reachable by keyboard/AT behind the full-page split (it was only covered visually). State is preserved (node stays mounted). - App: wrap SplitView in the app-level WebShellCustomizationProvider and CompactModeContext so split panes render markdown / tool-headers / thinking the same way the single-session chat does. Todo contexts stay chat-only — they belong to the outer session, not the panes. * refactor(web-shell): address review suggestions — coverage, dedup, split UX - ToolApproval: add a dedicated test on the real component that the global keyboard shortcut is armed by default and NOT armed when keyboardActive=false (the cross-pane approval safety mechanism). - SplitView: auto-exit to the Session Overview when the last pane is closed (guarded so an initial empty seed doesn't bounce straight back out). - ChatPane: add tests for the cancel action, the empty/whitespace submit guard, and error routing to the onError prop. - Extract the shared session-list page size + organization feature flag into constants/sessions.ts, used by the overview, split view, and sidebar, so the values can't drift between the three. * fix(web-shell): surface outer approval + failed refresh in overview/split - Split view: when the outer (main) session is waiting on an approval that's hidden behind the split, show a non-blocking notice banner with a "Go to it" button that returns to the chat where the approval lives. - Auto-close the split (like the overview panel) when the viewport shrinks below the large-screen breakpoint, so users aren't stranded. - Session Overview: surface a failed refresh inline (keeping the last-good cards) instead of silently swallowing it once cards are on screen. - Tests: status-report poll cadence, picker dismiss (Escape / outside / inside click), inline refresh-failure banner. * fix(web-shell): sever window.opener on split tab; tighten hidden-chat test - openSelectedInNewTab now clears win.opener (the split tab carries a daemon token in its URL fragment) to prevent reverse tabnabbing, matching the existing bug-report window.open path. - Strengthen the split-view App test so a missing outer-chat subtree fails instead of passing vacuously through an optional chain. * fix(web-shell): split-view focus/stability/robustness follow-ups - Refocus the composer after a shrink-driven split close so keyboard users aren't dropped onto <body> (skips when an approval or panel takes over). - Stabilize SplitView onExit via useCallback so its last-pane-close effect doesn't re-fire on every App re-render. - ChatPane: surface a per-pane connection-loss banner instead of silently showing stale messages when a pane's daemon connection drops. - ChatPane: anchor the streaming timer to the active turn's start (last user message timestamp) so a pane opened mid-turn shows real elapsed time. - Tests: split auto-close on shrink, outer-approval split notice + return-to- chat, connection banner, and streaming-timer anchoring.	2026-07-07 02:44:18 +00:00