vrr/qwen-code
2
0
Fork 0
mirror of https://github.com/QwenLM/qwen-code.git synced 2026-04-29 12:11:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 31

code review followup for compress command (#1097)

Browse source 
Followup to https://github.com/google-gemini/gemini-cli/pull/986
This commit is contained in:
Jacob MacDonald 2025-06-17 08:44:54 -07:00 • committed by GitHub
parent c3971754bf
commit e59c872b3d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 39 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

29
packages/cli/src/ui/hooks/slashCommandProcessor.test.ts
View file

@ -159,8 +159,8 @@ describe('useSlashCommandProcessor', () => {
process.env = { ...globalThis.process.env };
});
const getProcessor = (showToolDescriptions: boolean = false) => {
const { result } = renderHook(() =>
const getProcessorHook = (showToolDescriptions: boolean = false) =>
renderHook(() =>
useSlashCommandProcessor(
mockConfig,
[],
@ -178,8 +178,9 @@ describe('useSlashCommandProcessor', () => {
mockSetQuittingMessages,
),
);
return result.current;
};
const getProcessor = (showToolDescriptions: boolean = false) =>
getProcessorHook(showToolDescriptions).result.current;
describe('/memory add', () => {
it('should return tool scheduling info on valid input', async () => {
@ -1132,10 +1133,20 @@ Add any other context about the problem here.
describe('/compress command', () => {
it('should call tryCompressChat(true)', async () => {
const { handleSlashCommand } = getProcessor();
const hook = getProcessorHook();
mockTryCompressChat.mockImplementationOnce(async (force?: boolean) => {
// TODO: Check that we have a pending compression item in the history.
expect(force).toBe(true);
await act(async () => {
hook.rerender();
});
expect(hook.result.current.pendingHistoryItems).toContainEqual({
type: MessageType.COMPRESSION,
compression: {
isPending: true,
originalTokenCount: null,
newTokenCount: null,
},
});
return {
originalTokenCount: 100,
newTokenCount: 50,
@ -1143,8 +1154,12 @@ Add any other context about the problem here.
});
await act(async () => {
handleSlashCommand('/compress');
hook.result.current.handleSlashCommand('/compress');
});
await act(async () => {
hook.rerender();
});
expect(hook.result.current.pendingHistoryItems).toEqual([]);
expect(mockGeminiClient.tryCompressChat).toHaveBeenCalledWith(true);
expect(mockAddItem).toHaveBeenNthCalledWith(
2,