diff --git a/.qwen/skills/triage/references/pr-workflow.md b/.qwen/skills/triage/references/pr-workflow.md index 6891394248..29f5349434 100644 --- a/.qwen/skills/triage/references/pr-workflow.md +++ b/.qwen/skills/triage/references/pr-workflow.md @@ -83,8 +83,9 @@ curl -s https://raw.githubusercontent.com/anthropics/claude-code/main/CHANGELOG. - If we cut 80% of the scope, would the remaining 20% already solve the problem? - Could we achieve the same goal by modifying something that already exists, instead of adding something new? - Can the complexity live outside the codebase (user config, external tool) instead of inside it? +- **Minimal change:** is every edit in the diff needed for the stated goal, or does it carry unrelated changes, drive-by refactors, formatting churn, or scope creep that should be split into a separate PR? A focused PR that does one thing is easier to review, revert, and reason about. -If you spot a materially simpler path, raise it — not as a blocker, but as a genuine question the contributor should think about before the code review. +If you spot a materially simpler path, or changes that go beyond the minimal set needed for the stated goal, raise it — not as a blocker, but as a genuine question the contributor should think about before the code review. Implementation-level concerns (over-abstraction, code duplication, "10 lines vs 10 files") belong in Stage 2a code review — you need to see the code for those. @@ -99,7 +100,7 @@ Template looks good ✓ On direction: . CHANGELOG . -On approach: . +On approach: . Moving on to code review. 🔍 Flagging these for discussion before diving deeper. @@ -113,7 +114,7 @@ On approach: 。 -方案:<范围合理 / 感觉可以大幅简化 / 建议砍掉的部分>。<如果看到更简路径,点名:有没有考虑过直接 X?可能用很小的复杂度覆盖大部分场景。> +方案:<范围合理 / 感觉可以大幅简化 / 建议砍掉的部分>。<如果看到更简路径,点名:有没有考虑过直接 X?可能用很小的复杂度覆盖大部分场景。><如果 diff 夹带了无关改动或顺手重构,点名并建议拆成单独 PR。> <如果通过:> 进入代码审查 🔍 <如果有顾虑:> 先提出来讨论,再深入看代码。 @@ -217,6 +218,7 @@ Step back and look at the whole picture — the motivation, the implementation, - Does the PR's approach match or exceed my independent proposal? Or did I find a simpler path it missed? - Does this solve something users actually care about? - Is the code straightforward, or does it feel like it's trying too hard? +- Is every change in the diff necessary, or did unrelated edits / drive-by refactors bloat it beyond the minimal change the goal needs? - After seeing it run, do the results match what the PR promised? - If I had to maintain this in six months, would I curse the author or thank them? - Am I approving this because it's genuinely good, or because I ran out of reasons to say no?