vrr/qwen-code
2
0
Fork 0
mirror of https://github.com/QwenLM/qwen-code.git synced 2026-04-26 10:41:41 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

fix(review): respect /language output setting for local reviews (#3611)

Browse source 
The /review skill's language rule "match the language of the PR" has no
applicable target during local reviews (no PR exists). When a user sets
an output language via /language, local review output now honors that
preference instead of defaulting to English.

PR reviews remain unchanged — they continue matching the PR's language
since findings may be published as inline comments visible to all
collaborators.

Closes #3594
This commit is contained in:
易良 2026-04-25 22:27:30 +08:00 • committed by GitHub
parent c406c73509
commit b127258328
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
packages/core/src/skills/bundled/review/SKILL.md
View file

@ -17,7 +17,7 @@ You are an expert code reviewer. Your job is to review code changes and provide
**Critical rules (most commonly violated — read these first):**
1. **Match the language of the PR.** If the PR is in English, ALL your output (terminal + PR comments) MUST be in English. If in Chinese, use Chinese. Do NOT switch languages.
1. **Match the language of the PR.** If the PR is in English, ALL your output (terminal + PR comments) MUST be in English. If in Chinese, use Chinese. Do NOT switch languages. For **local reviews** (no PR), if the system prompt includes an output language preference, use that language; otherwise follow the user's input language.
2. **Step 9: use Create Review API** with `comments` array for inline comments. Do NOT use `gh api .../pulls/.../comments` to post individual comments. See Step 9 for the JSON format.
**Design philosophy: Silence is better than noise.** Every comment you make should be worth the reader's time. If you're unsure whether something is a problem, DO NOT MENTION IT. Low-quality feedback causes "cry wolf" fatigue — developers stop reading all AI comments and miss real issues.
@ -528,4 +528,4 @@ These criteria apply to both Step 4 (review agents) and Step 5 (verification age
- Flag any exposed secrets, credentials, API keys, or tokens in the diff as **Critical**.
- Silence is better than noise. If you have nothing important to say, say nothing.
- **Do NOT use `#N` notation** (e.g., `#1`, `#2`) in PR comments or summaries — GitHub auto-links these to issues/PRs. Use `(1)`, `[1]`, or descriptive references instead.
- **Match the language of the PR.** Write review comments, findings, and summaries in the same language as the PR title/description/code comments. If the PR is in English, write in English. If in Chinese, write in Chinese. Do NOT switch languages.
- **Match the language of the PR.** Write review comments, findings, and summaries in the same language as the PR title/description/code comments. If the PR is in English, write in English. If in Chinese, write in Chinese. Do NOT switch languages. For **local reviews** (no PR), respect the user's output language preference if set; otherwise follow the user's input language.