vrr/qwen-code
2
0
Fork 0
mirror of https://github.com/QwenLM/qwen-code.git synced 2026-04-29 20:20:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 24

fix: tool calls ui issues (#590)
Some checks failed
Qwen Code CI / Lint (GitHub Actions) (push) Has been cancelled
Details
Qwen Code CI / Lint (Javascript) (push) Has been cancelled
Details
Qwen Code CI / Lint (Shell) (push) Has been cancelled
Details
Qwen Code CI / Lint (YAML) (push) Has been cancelled
Details
Qwen Code CI / CodeQL (push) Has been cancelled
Details
E2E Tests / E2E Test (Linux) - sandbox:docker (push) Has been cancelled
Details
E2E Tests / E2E Test (Linux) - sandbox:docker-1 (push) Has been cancelled
Details
E2E Tests / E2E Test (Linux) - sandbox:none-1 (push) Has been cancelled
Details
E2E Tests / E2E Test (Linux) - sandbox:docker-2 (push) Has been cancelled
Details
E2E Tests / E2E Test (Linux) - sandbox:none (push) Has been cancelled
Details
E2E Tests / E2E Test (Linux) - sandbox:none-2 (push) Has been cancelled
Details
E2E Tests / E2E Test - macOS (push) Has been cancelled
Details
Qwen Code CI / Lint (push) Has been cancelled
Details
Qwen Code CI / Test (push) Has been cancelled
Details
Qwen Code CI / Test-1 (push) Has been cancelled
Details
Qwen Code CI / Test-2 (push) Has been cancelled
Details
Qwen Code CI / Test-3 (push) Has been cancelled
Details
Qwen Code CI / Test-4 (push) Has been cancelled
Details
Qwen Code CI / Test-5 (push) Has been cancelled
Details
Qwen Code CI / Test-6 (push) Has been cancelled
Details
Qwen Code CI / Test-7 (push) Has been cancelled
Details
Qwen Code CI / Test-8 (push) Has been cancelled
Details
Qwen Code CI / Post Coverage Comment (push) Has been cancelled
Details

Browse source
This commit is contained in:
Mingholy 2025-09-12 17:52:23 +08:00 • committed by GitHub
parent 67e2e270bd
commit b01ddf0aed
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 23 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

1
packages/cli/src/ui/components/messages/ToolGroupMessage.tsx
View file

@ -80,6 +80,7 @@ export const ToolGroupMessage: React.FC<ToolGroupMessageProps> = ({
marginLeft={1}
borderDimColor={hasPending}
borderColor={borderColor}
gap={1}
>
{toolCalls.map((tool) => {
const isConfirming = toolAwaitingApproval?.callId === tool.callId;

12
packages/cli/src/ui/components/messages/ToolMessage.test.tsx
View file

@ -84,19 +84,19 @@ describe('<ToolMessage />', () => {
StreamingState.Idle,
);
const output = lastFrame();
expect(output).toContain('✔'); // Success indicator
expect(output).toContain('✓'); // Success indicator
expect(output).toContain('test-tool');
expect(output).toContain('A tool for testing');
expect(output).toContain('MockMarkdown:Test result');
});
describe('ToolStatusIndicator rendering', () => {
it('shows ✔ for Success status', () => {
it('shows ✓ for Success status', () => {
const { lastFrame } = renderWithContext(
<ToolMessage {...baseProps} status={ToolCallStatus.Success} />,
StreamingState.Idle,
);
expect(lastFrame()).toContain('✔');
expect(lastFrame()).toContain('✓');
});
it('shows o for Pending status', () => {
@ -138,7 +138,7 @@ describe('<ToolMessage />', () => {
);
expect(lastFrame()).toContain('⊷');
expect(lastFrame()).not.toContain('MockRespondingSpinner');
expect(lastFrame()).not.toContain('✔');
expect(lastFrame()).not.toContain('✓');
});
it('shows paused spinner for Executing status when streamingState is WaitingForConfirmation', () => {
@ -148,7 +148,7 @@ describe('<ToolMessage />', () => {
);
expect(lastFrame()).toContain('⊷');
expect(lastFrame()).not.toContain('MockRespondingSpinner');
expect(lastFrame()).not.toContain('✔');
expect(lastFrame()).not.toContain('✓');
});
it('shows MockRespondingSpinner for Executing status when streamingState is Responding', () => {
@ -157,7 +157,7 @@ describe('<ToolMessage />', () => {
StreamingState.Responding, // Simulate app still responding
);
expect(lastFrame()).toContain('MockRespondingSpinner');
expect(lastFrame()).not.toContain('✔');
expect(lastFrame()).not.toContain('✓');
});
});

2
packages/cli/src/ui/components/messages/ToolMessage.tsx
View file

@ -269,7 +269,7 @@ const ToolStatusIndicator: React.FC<ToolStatusIndicatorProps> = ({
/>
)}
{status === ToolCallStatus.Success && (
<Text color={Colors.AccentGreen}>✔</Text>
<Text color={Colors.AccentGreen}>✓</Text>
)}
{status === ToolCallStatus.Confirming && (
<Text color={Colors.AccentYellow}>?</Text>