vrr/qwen-code
2
0
Fork 0
mirror of https://github.com/QwenLM/qwen-code.git synced 2026-09-10 19:01:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 23

fix(scripts): gate dep-only core subpath exports in the check

Browse source 
The exports check collected specifiers only from packages/cli/src, but
acp-bridge and sdk-typescript are runtime dependencies of the cli whose
compiled dist keeps core subpath specifiers verbatim. Entries named only
by those packages (./goalWire, ./transcriptRecords, ./subSessionConstants)
were therefore ungated: deleting one kept every gate green while
`node packages/cli` died with ERR_MODULE_NOT_FOUND on the serve/replay
path. Extend the source scan to packages/acp-bridge/src and
packages/sdk-typescript/src so all 95 collected specifiers resolve
through the exports map. Verified: removing ./goalWire or
./transcriptRecords from packages/core/package.json now makes the check
exit 1 (entries restored after the mutation probe).

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
Patrol-Run: qwen-pr-closeout/jmtmxfessij
This commit is contained in:
jinjing.zzj 2026-09-04 21:00:30 +08:00
parent ccbc6ac6d7
commit a18ffebb88
1 changed files with 24 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

33
scripts/check-core-subpath-exports.mjs
View file

@ -7,11 +7,13 @@
/**
* @fileoverview Checks that a compiled cli can still reach core by module path.
*
* The cli's own sources say `@qwen-code/qwen-code-core/config/storage.js` and
* the like. Inside the repo those resolve through tsconfig `paths` (for tsc and
* esbuild) or through vitest aliases (for the suites) — three mechanisms, none
* of which the published package has. There, the emitted JS keeps the specifier
* verbatim and Node resolves it against core's `exports` map.
* The cli's own sources — and the workspace packages its runtime graph pulls in
* (acp-bridge, sdk-typescript) — say
* `@qwen-code/qwen-code-core/config/storage.js` and the like. Inside the repo
* those resolve through tsconfig `paths` (for tsc and esbuild) or through
* vitest aliases (for the suites) — three mechanisms, none of which the
* published package has. There, the emitted JS keeps the specifier verbatim
* and Node resolves it against core's `exports` map.
*
* Nothing else exercises that entry. Remove it, rename the `dist/src` root, or
* add a pattern that shadows it, and every suite stays green while `qwen` dies
@ -31,11 +33,24 @@ const EXPORT_PROBES = new Map([
['@qwen-code/qwen-code-core/noFollowOpen', 'openSyncNoFollow'],
]);
const specifiers = new Set(EXPORT_PROBES.keys());
const cliSrc = path.join(root, 'packages', 'cli', 'src');
// acp-bridge and sdk-typescript are runtime dependencies of the cli, and their
// compiled dist keeps core subpath specifiers verbatim just like the cli's own
// dist. Scanning them too gates entries that only a dependency names (e.g.
// ./goalWire, ./transcriptRecords, ./subSessionConstants); without this, those
// exports entries could be deleted while every gate stays green.
const scannedSources = [
path.join(root, 'packages', 'cli', 'src'),
path.join(root, 'packages', 'acp-bridge', 'src'),
path.join(root, 'packages', 'sdk-typescript', 'src'),
];
const coreSpecifier = /['"](@qwen-code\/qwen-code-core\/[^'"]+)['"]/g;
for (const relativePath of globSync('**/*.{ts,tsx}', { cwd: cliSrc })) {
const source = readFileSync(path.join(cliSrc, relativePath), 'utf8');
for (const match of source.matchAll(coreSpecifier)) specifiers.add(match[1]);
for (const sourceDir of scannedSources) {
for (const relativePath of globSync('**/*.{ts,tsx}', { cwd: sourceDir })) {
const source = readFileSync(path.join(sourceDir, relativePath), 'utf8');
for (const match of source.matchAll(coreSpecifier)) {
specifiers.add(match[1]);
}
}
}
const coreDist = path.join(root, 'packages', 'core', 'dist', 'src');