From 7b628d7003d4e8d2ea34f4c0761ba8ab4607b579 Mon Sep 17 00:00:00 2001 From: "jinye.djy" Date: Sun, 26 Apr 2026 00:44:41 +0800 Subject: [PATCH] fix(core): shallow-clone savedApiKeySource to avoid mutation risk Copy the ConfigSource object before applyResolvedModelDefaults runs, so a future refactor that mutates source objects in place won't break the save/restore logic. Co-authored-by: Qwen-Coder --- packages/core/src/models/modelsConfig.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/core/src/models/modelsConfig.ts b/packages/core/src/models/modelsConfig.ts index 1c1569f42..d34cc08c6 100644 --- a/packages/core/src/models/modelsConfig.ts +++ b/packages/core/src/models/modelsConfig.ts @@ -905,6 +905,8 @@ export class ModelsConfig { : undefined; const savedApiKeySource = isUnchanged ? this.generationConfigSources['apiKey'] + ? { ...this.generationConfigSources['apiKey'] } + : undefined : undefined; this.applyResolvedModelDefaults(resolved);