vrr/qwen-code
2
0
Fork 0
mirror of https://github.com/QwenLM/qwen-code.git synced 2026-07-09 17:19:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

fix(test): isolate ACP integration agents via QWEN_HOME to end parallel-settings race (#5724)

Browse source 
The ACP test `supports session/set_config_option for mode and model` flakes in
CI at acp-integration.test.ts:516 (`expect(openaiModel).toBeDefined()`).

Root cause: `globalSetup` does not sandbox HOME, so every integration test
shares the real `$HOME/.qwen`, and `vitest.config.ts` runs test files with
`fileParallelism: true` (up to 4 at once). The ACP `authenticate` / `setModel`
handlers persist `security.auth.selectedType` (and `model.name`) to User scope.
A concurrent test (e.g. system-control's `setModel('qwen3-...')`) can clobber
the persisted auth type in the window between this agent's
`authenticate({ methodId: 'openai' })` and its `session/new`; the new session
then resolves a non-openai auth, the openai runtime model is never captured, and
it drops out of `availableModels`.

Spawn each ACP agent with a per-agent `QWEN_HOME` so `getGlobalQwenDir()` points
at an isolated dir and the authenticate -> session/new round-trip reads back
exactly what this agent wrote. Test-only; no runtime code changes.
This commit is contained in:
Shaojin Wen 2026-06-23 08:23:12 +08:00 • committed by GitHub
parent 9993c6f413
commit 6fa13206ab
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 20 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

21
integration-tests/cli/acp-integration.test.ts
View file

@ -5,7 +5,8 @@
*/
import { spawn } from 'node:child_process';
import { readFileSync, writeFileSync } from 'node:fs';
import { mkdirSync, readFileSync, writeFileSync } from 'node:fs';
import { join } from 'node:path';
import { createInterface } from 'node:readline';
import { setTimeout as delay } from 'node:timers/promises';
import { describe, expect, it } from 'vitest';
@ -101,12 +102,30 @@ function setupAcpTest(
const acpFlag =
options?.useNewFlag !== false ? '--acp' : '--experimental-acp';
// Isolate this agent's GLOBAL (User-scope) qwen config dir via QWEN_HOME.
// `globalSetup` does not sandbox HOME, so every integration test shares the
// real `$HOME/.qwen`, and `vitest.config.ts` runs test files with
// `fileParallelism: true` (up to 4 at once). The ACP `authenticate` /
// `setModel` handlers persist `security.auth.selectedType` (and `model.name`)
// to User scope, so a concurrent test (e.g. `system-control`'s
// `setModel('qwen3-...')`) can clobber the persisted auth type in the window
// between this agent's `authenticate({ methodId: 'openai' })` and its
// `session/new`. When that happens the new session config resolves a
// non-openai auth, the openai runtime model is never captured, and it drops
// out of `availableModels` — flaking `expect(openaiModel).toBeDefined()` in
// the `set_config_option` test (acp-integration.test.ts:516). A per-agent
// QWEN_HOME redirects `getGlobalQwenDir()` so the authenticate -> session/new
// round-trip reads back exactly what this agent wrote.
const qwenHome = join(rig.testDir!, '.qwen-home');
mkdirSync(qwenHome, { recursive: true });
const agent = spawn(
'node',
[rig.bundlePath, acpFlag, '--no-chat-recording'],
{
cwd: rig.testDir!,
stdio: ['pipe', 'pipe', 'pipe'],
env: { ...process.env, QWEN_HOME: qwenHome },
},
);