From 5aa7110e4018428276fe0bbab6ced64e3d5ddeb2 Mon Sep 17 00:00:00 2001 From: doudouOUC Date: Thu, 21 May 2026 19:56:56 +0800 Subject: [PATCH] docs(verification): sync automated-results with current state MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two doc fixes the reviewer flagged: - migration-completeness.txt was a 0-byte file with a confusing cross-reference. Populated with the actual grep command + its "(no output)" result so the empty-output state is explicit. - automated-results.md still referenced combinedAbortSignal.test.ts (8 tests, @deprecated shim) — both files were deleted in 94e8c5812 when httpHookRunner.ts migrated to combineAbortSignals directly. Replaced the line with a reference to httpHookRunner.test.ts. Also updated the test counts to reflect current state (26 abortController, 13 warningHandler — both grew with the review cycle) and removed the stale combinedAbortSignal.ts entry from the prettier-check command. Refs PR #4366. --- .../abort-controller-refactor/automated-results.md | 9 ++++----- .../abort-controller-refactor/migration-completeness.txt | 3 +++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/docs/verification/abort-controller-refactor/automated-results.md b/docs/verification/abort-controller-refactor/automated-results.md index 4ee3c63d24..ebe5627b05 100644 --- a/docs/verification/abort-controller-refactor/automated-results.md +++ b/docs/verification/abort-controller-refactor/automated-results.md @@ -51,9 +51,9 @@ that requires `--expose-gc`, 2 are pre-existing skips in the headless suite). Coverage: -- `packages/core/src/utils/abortController.test.ts` — 19 tests: factory cap, child propagation, reverse cleanup, fast path, undefined parent, `combineAbortSignals` semantics, GC safety. -- `packages/cli/src/utils/warningHandler.test.ts` — 9 tests: idempotency, AbortSignal suppression (including `[AbortSignal{...}]` shape), generic EventTarget NOT suppressed, debug-mode passthrough. -- `packages/core/src/hooks/combinedAbortSignal.test.ts` — 8 existing tests pass against the new `@deprecated` shim, proving wire compatibility with `httpHookRunner.ts:202`. +- `packages/core/src/utils/abortController.test.ts` — 26 tests: factory cap (default + custom), child propagation, reverse cleanup, fast path, undefined parent, custom-maxListeners passthrough, `combineAbortSignals` semantics (incl. cleanup-cancels-timeout, timeout-cleans-input-listeners, `timeoutMs <= 0` boundary, mid-iteration defensive check), GC safety (best-effort). +- `packages/cli/src/utils/warningHandler.test.ts` — 13 tests: idempotency, AbortSignal suppression (including `[AbortSignal{...}]` shape), generic EventTarget NOT suppressed, debug-mode passthrough, fan-out to prior listeners, spawned-child end-to-end stderr integration. +- `packages/core/src/hooks/httpHookRunner.test.ts` — covers the migrated `combineAbortSignals` consumer (the deprecated `createCombinedAbortSignal` shim plus its test file were removed once the lone caller migrated). - `packages/core/src/agents/runtime/{agent-core,agent-interactive,agent-headless,agent-context,agent-statistics}.test.ts` — 102 tests covering the high-impact migrated files. - `packages/core/src/core/openaiContentGenerator/**` — 280+ tests including the pipeline that lost the `raiseAbortListenerCap` band-aid. - `packages/core/src/followup/**` — 100+ tests including the migrated speculation controller. @@ -77,8 +77,7 @@ $ node_modules/.bin/prettier --check packages/core/src/agents/runtime/agent-core packages/cli/src/utils/warningHandler.ts \ packages/cli/src/utils/warningHandler.test.ts \ packages/core/src/utils/abortController.ts \ - packages/core/src/utils/abortController.test.ts \ - packages/core/src/hooks/combinedAbortSignal.ts + packages/core/src/utils/abortController.test.ts Checking formatting... All matched files use Prettier code style! ``` diff --git a/docs/verification/abort-controller-refactor/migration-completeness.txt b/docs/verification/abort-controller-refactor/migration-completeness.txt index e69de29bb2..59e5392404 100644 --- a/docs/verification/abort-controller-refactor/migration-completeness.txt +++ b/docs/verification/abort-controller-refactor/migration-completeness.txt @@ -0,0 +1,3 @@ +$ grep -rn "new AbortController" packages/core/src --include="*.ts" \ + | grep -v test | grep -v abortController.ts +(no output)