vrr/qwen-code
2
0
Fork 0
mirror of https://github.com/QwenLM/qwen-code.git synced 2026-04-28 11:41:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 14

fix(review): clarify Critical vs Suggestion severity boundary

Browse source 
Logic errors causing incorrect behavior (wrong return values, skipped
code paths) were being classified as Suggestion instead of Critical.
Added explicit examples: "if code does something wrong, it's Critical
— not Suggestion."

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
wenshao 2026-04-08 04:16:33 +08:00
parent 3982df56bc
commit 5a41e17b2b
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
packages/core/src/skills/bundled/review/SKILL.md
View file

@ -324,8 +324,8 @@ For **PR comments** (Step 9): do NOT include internal stats (agent count, raw/co
Use severity levels:
- **Critical** — Must fix before merging. Bugs, security issues, data loss risks, build/test failures.
- **Suggestion** — Recommended improvement. Better patterns, clearer code, potential issues.
- **Critical** — Must fix before merging. Bugs that cause incorrect behavior (e.g., logic errors, wrong return values, skipped code paths), security vulnerabilities, data loss risks, build/test failures. If code does something wrong, it's Critical — not Suggestion.
- **Suggestion** — Recommended improvement. Better patterns, clearer code, potential issues that don't cause incorrect behavior today but may in the future.
- **Nice to have** — Optional optimization. Minor style tweaks, small performance gains.
For each **individual** finding, include: