From 48340c3acfaa3db25ee89291aa32a9a99ad4e447 Mon Sep 17 00:00:00 2001 From: wenshao Date: Mon, 6 Apr 2026 23:01:59 +0800 Subject: [PATCH] fix(review): preserve highest severity during dedup merge When deduplication merges findings with different severities (e.g., a Critical typecheck error with a Suggestion from LLM review), the merged finding now uses the highest severity. Deterministic severity is treated as authoritative and cannot be downgraded. Co-Authored-By: Claude Opus 4.6 (1M context) --- packages/core/src/skills/bundled/review/SKILL.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/skills/bundled/review/SKILL.md b/packages/core/src/skills/bundled/review/SKILL.md index 458e8c223..ad7a12684 100644 --- a/packages/core/src/skills/bundled/review/SKILL.md +++ b/packages/core/src/skills/bundled/review/SKILL.md @@ -204,7 +204,7 @@ In addition to their primary focus, each review agent (1-4) MUST perform cross-f ### Deduplication -Before verification, merge findings that refer to the same issue (same file, same line range, same root cause) even if reported by different agents. Keep the most detailed description and note which agents flagged it. **If a merged finding includes any deterministic source** (`[linter]`, `[typecheck]`, `[build]`, `[test]`), treat the entire merged finding as pre-confirmed — retain all source tags for reporting but skip verification. +Before verification, merge findings that refer to the same issue (same file, same line range, same root cause) even if reported by different agents. Keep the most detailed description and note which agents flagged it. When severities differ across merged items, use the **highest severity** — never let deduplication downgrade severity. **If a merged finding includes any deterministic source** (`[linter]`, `[typecheck]`, `[build]`, `[test]`), treat the entire merged finding as pre-confirmed — retain all source tags for reporting, preserve deterministic severity as authoritative, and skip verification. ### Independent verification