From 30ac136a9371e32f8d3ef235147dcef30fae444a Mon Sep 17 00:00:00 2001 From: Alexander Farber Date: Wed, 24 Dec 2025 11:16:22 +0100 Subject: [PATCH] Check disableUpdateNag before making network request --- packages/cli/src/utils/handleAutoUpdate.test.ts | 8 -------- packages/cli/src/utils/handleAutoUpdate.ts | 4 ---- 2 files changed, 12 deletions(-) diff --git a/packages/cli/src/utils/handleAutoUpdate.test.ts b/packages/cli/src/utils/handleAutoUpdate.test.ts index d448b9e7b..8f038d7f8 100644 --- a/packages/cli/src/utils/handleAutoUpdate.test.ts +++ b/packages/cli/src/utils/handleAutoUpdate.test.ts @@ -94,14 +94,6 @@ describe('handleAutoUpdate', () => { expect(mockSpawn).not.toHaveBeenCalled(); }); - it('should do nothing if update nag is disabled', () => { - mockSettings.merged.general!.disableUpdateNag = true; - handleAutoUpdate(mockUpdateInfo, mockSettings, '/root', mockSpawn); - expect(mockGetInstallationInfo).not.toHaveBeenCalled(); - expect(mockUpdateEventEmitter.emit).not.toHaveBeenCalled(); - expect(mockSpawn).not.toHaveBeenCalled(); - }); - it('should emit "update-received" but not update if auto-updates are disabled', () => { mockSettings.merged.general!.disableAutoUpdate = true; mockGetInstallationInfo.mockReturnValue({ diff --git a/packages/cli/src/utils/handleAutoUpdate.ts b/packages/cli/src/utils/handleAutoUpdate.ts index 21ff7be63..676aa981a 100644 --- a/packages/cli/src/utils/handleAutoUpdate.ts +++ b/packages/cli/src/utils/handleAutoUpdate.ts @@ -24,10 +24,6 @@ export function handleAutoUpdate( return; } - if (settings.merged.general?.disableUpdateNag) { - return; - } - const installationInfo = getInstallationInfo( projectRoot, settings.merged.general?.disableAutoUpdate ?? false,