vrr/qwen-code
2
0
Fork 0
mirror of https://github.com/QwenLM/qwen-code.git synced 2026-05-04 06:30:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Refactor ShellTool: remove ping hack and timeout, optimize cleanup

Browse source
This commit is contained in:
xuewenjie 2025-12-10 13:49:51 +08:00
parent 6fc09a82fb
commit 16939c0bc8
3 changed files with 26 additions and 37 deletions
Download patch file Download diff file Expand all files Collapse all files

6
packages/core/src/tools/shell.test.ts
View file

@ -833,12 +833,12 @@ describe('ShellTool', () => {
});
describe('Windows background execution', () => {
it('should append keep-alive ping with && on Windows for background tasks', async () => {
it('should clean up trailing ampersand on Windows for background tasks', async () => {
vi.mocked(os.platform).mockReturnValue('win32');
const mockAbortSignal = new AbortController().signal;
const invocation = shellTool.build({
command: 'npm start',
command: 'npm start &',
is_background: true,
});
@ -859,7 +859,7 @@ describe('ShellTool', () => {
await promise;
expect(mockShellExecutionService).toHaveBeenCalledWith(
expect.stringContaining('npm start && ping -n 86400 127.0.0.1 >nul'),
'npm start',
expect.any(String),
expect.any(Function),
expect.any(AbortSignal),