fix(ci): add always() to delay-automatic-review and ack-review-request (#6260)

These jobs transitively depend on precheck-pr via authorize. precheck-pr
is intentionally skipped for same-repo PRs (only runs for forks). Without
always(), GitHub Actions' default behavior propagates the skipped upstream
job, causing delay-automatic-review to be skipped even when authorize
succeeds. This breaks the entire review chain for same-repo PRs on
opened/synchronize events.

Fixes PR #5629 review not triggering.
This commit is contained in:
Shaojin Wen 2026-07-03 19:47:28 +08:00 committed by GitHub
parent fe3dd93e8f
commit 081c46c5bc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -77,6 +77,7 @@ jobs:
# this `if` only matches the /review command shape.
needs: ['authorize']
if: |-
always() &&
needs.authorize.outputs.should_review == 'true' &&
((github.event_name == 'issue_comment' &&
github.event.issue.pull_request &&
@ -154,6 +155,7 @@ jobs:
delay-automatic-review:
needs: ['authorize']
if: |-
always() &&
github.event_name == 'pull_request_target' &&
(github.event.action == 'opened' ||
github.event.action == 'synchronize') &&