mirror of
https://github.com/razzant/ouroboros.git
synced 2026-08-31 18:44:50 +00:00
fca3dcee5b
Adversarial review of the handoff, four accepted findings. Artifact paths (real bug): --output and --drive-root were forwarded verbatim while the base-side run executes with cwd set to the temporary trusted checkout, so a relative path resolved inside that checkout and was deleted with it when the review returned. Both are absolutized against the invoking cwd before the child argv is built. Argv robustness: the forwarded options move to equals form (--base-ref=/--head-ref=/--goal=/--scope=/--output=/--drive-root=). A goal, scope or title beginning with "-" was parsed as a flag by the child, whose argparse error surfaced as exit 2 — the code this script reserves for an empty diff. Test strength: the contract pin called the helper directly, so deleting the main() hook kept it green. A new end-to-end test invokes the REAL wrapper as a process from a checkout that is not the base and proves the base-side probe executed; removing the hook fails it (verified by mutation). The seeded repo gains a real (non-namespace) ouroboros package and the repository's own __pycache__ ignores, so an out-of-repo wrapper resolves its import there and importing does not dirty the tree. A second test pins the artifact-path and flag-shaped-value behavior through the same probe. Honesty: the guarantee is scoped wherever it is claimed (module and function docstrings, packet trust text, CONTRIBUTING, DEVELOPMENT, ARCHITECTURE). The handoff removes the dependency on which checkout the operator happened to stand in; the wrapper performing it is still read from the invoking checkout, so that checkout must be trusted — the same trust root as before, now stated instead of assumed. The stale D31 legend in scripts/v7_migration.py and the stale contributor-trust-boundary line in docs/ARCHITECTURE.md are synced to the new contract, and the MIGRATION_v7.md row no longer claims the replacement test covers eleven paths: it parametrizes three representative proposals. Co-authored-by: Ouroboros <311266734+ouroboros-agent@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| bench_delegated_snapshot.py | ||
| build_appimage.sh | ||
| build_linux_packages.sh | ||
| build_repo_bundle.py | ||
| carrier_rebase_helper.py | ||
| claudexor_platform_smoke.py | ||
| cleanup_test_pollution.py | ||
| contributor_review_evidence.py | ||
| download_node_standalone.ps1 | ||
| download_node_standalone.sh | ||
| download_python_standalone.ps1 | ||
| download_python_standalone.sh | ||
| download_ripgrep_standalone.ps1 | ||
| download_ripgrep_standalone.sh | ||
| fetch_claudexor_runtime.py | ||
| pyi_rth_pythonnet.py | ||
| regenerate_size_ratchet.py | ||
| release_proof.py | ||
| run_external_review.py | ||
| run_plan_review.py | ||
| smoke_linux_packages.sh | ||
| v7_evidence.py | ||
| v7_migration.py | ||