mirror of
https://github.com/razzant/ouroboros.git
synced 2026-10-03 20:27:56 +00:00
16b8895ced
The combined tree's full serial suite ended with 30 failures; 21 of them were static string contracts and source pins that still described the sticky card-presence machinery WP-G deleted (taskUiStates, forceCard/forceTaskCard, markTaskToolCall, markAssistantReply, scheduleTaskUiCleanup, retiredTaskIds, the cardVisible latch, the replay `needsVisibleTerminal` branch, the applyEventTelemetry closure and the HTML-template conversion button). Every one of them is now pinned on the mechanism that replaced it, so the contracts say what the code does instead of guarding a deleted symbol: - presence is ONE predicate (`blockVisible`) whose inputs are record facts, including that the completion note is not content and that a terminal outcome other than Done keeps the block; - `ensureLiveCardVisible` both mounts and unmounts from that predicate, and the rebuild sweep re-runs it for every record instead of reading a latch; - tool rows are content keyed `tool:<group>:<call id>`, so a failure or timeout evolves its own call's row, and replay shows the one summary row `noteToolMetrics` derives from the recorded per-tool counts; - the refetch after a lost task_done is owed only by a visible block; - a lineage-known child is minted as its parent's nested card by whichever path reaches it first, and the conversion button carries the design-system role and marker on the node the chrome sync builds. Two fixture group ids and one test name that named the retirement/force writers were renamed to the behaviour they now pin; the `retiredTaskIds.clear` row is dropped because the stronger `retiredTaskIds`-absent pin owns that fact. Co-authored-by: Ouroboros <311266734+ouroboros-agent@users.noreply.github.com>
102 lines
5.4 KiB
Python
102 lines
5.4 KiB
Python
"""Regression tests for subagent-reliability fixes (PR-D).
|
|
|
|
* #18 — child artifact rebasing no longer fails silently: an unreachable source
|
|
is flagged (copy_status=failed) instead of keeping a broken parent path.
|
|
* #1/#2/#20 — on reload/reconnect the chat replay reconstructs subagent
|
|
lineage + terminal state from durable history, so finished child cards
|
|
finalize instead of sticking on "working".
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pathlib
|
|
|
|
REPO = pathlib.Path(__file__).resolve().parents[1]
|
|
|
|
|
|
def _read(rel: str) -> str:
|
|
return (REPO / rel).read_text(encoding="utf-8")
|
|
|
|
|
|
# ───────────────────────── #18: artifact rebase failure ─────────────────────
|
|
|
|
def test_artifact_rebase_flags_missing_source(tmp_path):
|
|
from ouroboros.headless import _copy_child_artifacts_to_parent
|
|
|
|
parent = tmp_path / "parent"
|
|
child = tmp_path / "child"
|
|
parent.mkdir(parents=True)
|
|
child.mkdir(parents=True)
|
|
real = child / "out.txt"
|
|
real.write_text("hello", encoding="utf-8")
|
|
|
|
artifacts = [
|
|
{"path": str(real), "name": "out.txt"},
|
|
{"path": "does_not_exist.txt", "name": "ghost"},
|
|
]
|
|
out = _copy_child_artifacts_to_parent(parent, "task1234", child, artifacts)
|
|
|
|
# A real child-drive file is rebased into the parent store (path changes).
|
|
real_item = next(a for a in out if a["name"] == "out.txt")
|
|
assert real_item.get("copy_status") != "failed"
|
|
assert real_item["path"] != str(real)
|
|
|
|
# An unreachable source is FLAGGED, not silently kept with a broken path.
|
|
ghost = next(a for a in out if a["name"] == "ghost")
|
|
assert ghost.get("copy_status") == "failed"
|
|
assert ghost.get("copy_error")
|
|
|
|
|
|
# ──────────────── #1/#2/#20: subagent lineage rebuilt on replay ──────────────
|
|
|
|
def test_replay_learns_subagent_lineage_before_merging_card_rows():
|
|
src = _read("web/modules/chat.js")
|
|
# One helper learns lineage from both replay rows and live final frames.
|
|
assert "function learnSubagentLineage(msg)" in src
|
|
assert "for (const msg of messages) learnSubagentLineage(msg);" in src
|
|
history = src[src.index("function applyHistoryMessages"):src.index("async function syncHistory")]
|
|
assert history.index("for (const msg of messages) learnSubagentLineage(msg);") < history.index("handleCardReference(msg)")
|
|
# A page may contain a child whose parent is already represented elsewhere.
|
|
# Keep those bindings during replay; only final instance disposal clears them.
|
|
for collection in ("subagentChildParents", "subagentTerminalChildren"):
|
|
assert f"{collection}.clear();" not in history
|
|
assert f"{collection}.clear();" in src[src.index("destroy() {"):]
|
|
fanout = src[src.index("onWs('chat'"):src.index("onWs('message_annotation'")]
|
|
# Live lineage must be known before progress or a final can resolve a
|
|
# child card; ephemeral registration now lives in the early reference seam.
|
|
assert fanout.index("learnSubagentLineage(msg);") < fanout.index("updateLiveCardFromProgressMessage(msg,")
|
|
assert fanout.index("learnSubagentLineage(msg);") < fanout.index("routeSubagentFinalMessageToCard(explicitTaskId, msg)")
|
|
# A lineage-known child is minted as its parent's nested card by whichever
|
|
# path reaches it first (#636) — no sticky force writer: the parent's anchor
|
|
# follows the child's frame and the predicate always admits a child block.
|
|
assert "reanchorTaskCard(getLiveCardRecord(parentId), rawTs);" in src
|
|
assert "const record = getSubagentCardRecord(childId, parentId, role);" in src
|
|
assert "if (!record || record.isSubagent) return true;" in src
|
|
# A child is locked terminal from EITHER a terminal subagent event OR a
|
|
# genuinely-settled server task_terminal_status; interrupted stays retryable.
|
|
assert "const replayTerminal = msg.task_terminal_status" in src
|
|
assert "const replayTerminal = msg.task_terminal_status && taskDoneIsTerminal(msg);" in src
|
|
assert "if (replayTerminal || ['completed', 'completed_warn', 'failed', 'cancelled', 'rejected'].includes(event)) {" in src
|
|
assert "subagentTerminalChildren.add(childId);" in src
|
|
|
|
|
|
def test_progress_dedup_uses_full_array_not_last_item():
|
|
"""applyLiveCardState must dedup a progress line against the WHOLE card, not
|
|
just the last item — otherwise a background syncHistory re-feeds historical
|
|
progress and the 'Notes' count grows without bound (BUGREPORT-panic-working-notes).
|
|
"""
|
|
chat = _read("web/modules/chat.js")
|
|
assert "updateLiveTimelineItem(record, summary," in chat
|
|
source = _read("web/modules/chat_render_batch.js")
|
|
src = source[source.index("export function updateLiveTimelineItem"):]
|
|
# full-array dedup
|
|
assert "const existingIdx = record.items.findIndex((it) => it.dedupeKey === syntheticKey);" in src
|
|
# the old last-item-only check is gone
|
|
assert "record.items[lastIdx].dedupeKey === syntheticKey ? lastIdx : -1" not in src
|
|
# a historical re-feed (found, not the last item) is skipped, not re-appended
|
|
assert "timelineUpdate = 'duplicate-skip';" in src
|
|
# Historical frames use their physical source identities and independently
|
|
# reject replayed duplicates before creating another item.
|
|
history = _read("web/modules/chat_history_replay.js")
|
|
assert "entry.dedupeKey === key" in history
|
|
assert "if (item?.historyId === identity) return false;" in history
|