mirror of
https://github.com/anomalyco/opencode.git
synced 2026-07-11 03:28:28 +00:00
ShellSelect.args() ran zsh/bash with -l and explicitly sourced .zshrc/.bashrc, loading user functions and aliases that can shadow builtins and return non-zero exit codes, breaking && chains. Match the old tool behavior: plain non-login non-interactive shell -c command with cwd passed via spawn options.
106 lines
3.8 KiB
TypeScript
106 lines
3.8 KiB
TypeScript
import { describe, expect, test } from "bun:test"
|
|
import path from "path"
|
|
import { ShellSelect } from "@opencode-ai/core/shell/select"
|
|
import { FSUtil } from "@opencode-ai/core/fs-util"
|
|
import { which } from "@opencode-ai/core/util/which"
|
|
|
|
const withShell = async (shell: string | undefined, fn: () => void | Promise<void>) => {
|
|
const prev = process.env.SHELL
|
|
if (shell === undefined) delete process.env.SHELL
|
|
else process.env.SHELL = shell
|
|
ShellSelect.acceptable.reset()
|
|
ShellSelect.preferred.reset()
|
|
try {
|
|
await fn()
|
|
} finally {
|
|
if (prev === undefined) delete process.env.SHELL
|
|
else process.env.SHELL = prev
|
|
ShellSelect.acceptable.reset()
|
|
ShellSelect.preferred.reset()
|
|
}
|
|
}
|
|
|
|
describe("shell", () => {
|
|
test("normalizes shell names", () => {
|
|
expect(ShellSelect.name("/bin/bash")).toBe("bash")
|
|
if (process.platform === "win32") {
|
|
expect(ShellSelect.name("C:/tools/NU.EXE")).toBe("nu")
|
|
expect(ShellSelect.name("C:/tools/PWSH.EXE")).toBe("pwsh")
|
|
}
|
|
})
|
|
|
|
test("detects login shells", () => {
|
|
expect(ShellSelect.login("/bin/bash")).toBe(true)
|
|
expect(ShellSelect.login("C:/tools/pwsh.exe")).toBe(false)
|
|
})
|
|
|
|
test("detects posix shells", () => {
|
|
expect(ShellSelect.posix("/bin/bash")).toBe(true)
|
|
expect(ShellSelect.posix("/bin/fish")).toBe(false)
|
|
expect(ShellSelect.posix("C:/tools/pwsh.exe")).toBe(false)
|
|
})
|
|
|
|
test("falls back when configured shell cannot be resolved", async () => {
|
|
await withShell(undefined, async () => {
|
|
const preferred = ShellSelect.preferred()
|
|
const acceptable = ShellSelect.acceptable()
|
|
expect(ShellSelect.preferred("opencode-missing-shell")).toBe(preferred)
|
|
expect(ShellSelect.acceptable("opencode-missing-shell")).toBe(acceptable)
|
|
})
|
|
})
|
|
|
|
test("falls back for terminal-only acceptable shells", () => {
|
|
expect(ShellSelect.name(ShellSelect.acceptable("fish"))).not.toBe("fish")
|
|
expect(ShellSelect.name(ShellSelect.acceptable("nu"))).not.toBe("nu")
|
|
})
|
|
|
|
test("builds command args per shell family", () => {
|
|
expect(ShellSelect.args("/bin/sh", "echo hi")).toEqual(["-c", "echo hi"])
|
|
expect(ShellSelect.args("/usr/bin/fish", "echo hi")).toEqual(["-c", "echo hi"])
|
|
expect(ShellSelect.args("/bin/zsh", "echo hi")).toEqual(["-c", "echo hi"])
|
|
expect(ShellSelect.args("/bin/bash", "echo hi")).toEqual(["-c", "echo hi"])
|
|
})
|
|
|
|
if (process.platform === "win32") {
|
|
test("rejects blacklisted shells case-insensitively", async () => {
|
|
await withShell("NU.EXE", async () => {
|
|
expect(ShellSelect.name(ShellSelect.acceptable())).not.toBe("nu")
|
|
})
|
|
})
|
|
|
|
test("normalizes Git Bash shell paths from env", async () => {
|
|
const shell = "/cygdrive/c/Program Files/Git/bin/bash.exe"
|
|
await withShell(shell, async () => {
|
|
expect(ShellSelect.preferred()).toBe(FSUtil.windowsPath(shell))
|
|
})
|
|
})
|
|
|
|
test("resolves /usr/bin/bash from env to Git Bash", async () => {
|
|
const bash = ShellSelect.gitbash()
|
|
if (!bash) return
|
|
await withShell("/usr/bin/bash", async () => {
|
|
expect(ShellSelect.acceptable()).toBe(bash)
|
|
expect(ShellSelect.preferred()).toBe(bash)
|
|
})
|
|
})
|
|
|
|
test("resolves bare bash to Git Bash before PATH", async () => {
|
|
const bash = ShellSelect.gitbash()
|
|
if (!bash) return
|
|
expect(ShellSelect.acceptable("bash")).toBe(bash)
|
|
expect(ShellSelect.preferred("bash")).toBe(bash)
|
|
await withShell("bash", async () => {
|
|
expect(ShellSelect.acceptable()).toBe(bash)
|
|
expect(ShellSelect.preferred()).toBe(bash)
|
|
})
|
|
})
|
|
|
|
test("resolves bare PowerShell shells", async () => {
|
|
const shell = which("pwsh") || which("powershell")
|
|
if (!shell) return
|
|
await withShell(path.win32.basename(shell), async () => {
|
|
expect(ShellSelect.preferred()).toBe(shell)
|
|
})
|
|
})
|
|
}
|
|
})
|