diff --git a/packages/tui/src/component/dialog-config.tsx b/packages/tui/src/component/dialog-config.tsx index 710c2d7713c..94bd68c4f00 100644 --- a/packages/tui/src/component/dialog-config.tsx +++ b/packages/tui/src/component/dialog-config.tsx @@ -55,7 +55,7 @@ export const settings: Setting[] = [ title: "Terminal", category: "Session", path: ["session", "terminal"], - default: false, + default: true, values: [false, true], labels: ["off", "on"], keywords: ["pty", "shell", "terminal pane"], diff --git a/packages/tui/src/config/index.tsx b/packages/tui/src/config/index.tsx index 2ab0e1a01cd..ac2b7594fc5 100644 --- a/packages/tui/src/config/index.tsx +++ b/packages/tui/src/config/index.tsx @@ -265,12 +265,6 @@ export type Resolved = Omite", "Open external editor"), - "theme.switch": keybind("t", "List available themes"), + "theme.switch": keybind("none", "List available themes"), "theme.switch_mode": keybind("none", "Switch between light and dark theme mode"), "theme.mode.lock": keybind("none", "Lock or unlock theme mode"), "session.sidebar.toggle": keybind("b", "Toggle sidebar"), "pane.focus.left": keybind("left", "Focus session pane"), "pane.focus.right": keybind("right", "Focus terminal pane"), "terminal.select": keybind("down", "Select terminal"), - "terminal.toggle": keybind("none", "Toggle terminal pane"), + "terminal.toggle": keybind("t", "Toggle terminal pane"), "terminal.close": keybind("up", "Close terminal pane"), "session.toggle.scrollbar": keybind("none", "Toggle session scrollbar"), "opencode.status": keybind("s", "View status"), diff --git a/packages/tui/test/cli/tui/composer-keymap.test.tsx b/packages/tui/test/cli/tui/composer-keymap.test.tsx index cbec4d0bd27..0c473d95d7c 100644 --- a/packages/tui/test/cli/tui/composer-keymap.test.tsx +++ b/packages/tui/test/cli/tui/composer-keymap.test.tsx @@ -93,7 +93,7 @@ async function renderComposer( const app = await testRender( () => ( - + diff --git a/packages/tui/test/cli/tui/data.test.tsx b/packages/tui/test/cli/tui/data.test.tsx index bc6dd58f266..59c5f5c4820 100644 --- a/packages/tui/test/cli/tui/data.test.tsx +++ b/packages/tui/test/cli/tui/data.test.tsx @@ -41,7 +41,7 @@ function emitEvent(events: ReturnType, event: OpenCode events.emit({ ...event, location: { directory } }) } -const config = createTuiResolvedConfig() +const config = createTuiResolvedConfig({ session: { terminal: false } }) function DataProvider(props: ParentProps) { return ( diff --git a/packages/tui/test/config-v2.test.tsx b/packages/tui/test/config-v2.test.tsx index 664ae4bd293..ac725f3ad63 100644 --- a/packages/tui/test/config-v2.test.tsx +++ b/packages/tui/test/config-v2.test.tsx @@ -106,29 +106,6 @@ test("validates terminal copy behavior", () => { expect(setting?.default).toBe(process.platform === "win32" ? "manual" : "select") }) -test("keeps persistent terminals disabled until explicitly enabled", () => { - const disabled = resolve({}, { terminalSuspend: true }) - expect(disabled.session.terminal ?? false).toBe(false) - expect(disabled.keybinds.get("theme.switch")).toMatchObject([{ key: "t" }]) - expect(disabled.keybinds.get("terminal.toggle")).toEqual([]) - expect(settings.find((setting) => setting.path.join(".") === "session.terminal")?.default).toBe(false) - expect(settings.filter((setting) => setting.category === "Terminal").map((setting) => setting.title)).toEqual([ - "Window title", - "Copy behavior", - ]) - - const enabled = resolve({ session: { terminal: true } }, { terminalSuspend: true }) - expect(enabled.keybinds.get("terminal.toggle")).toMatchObject([{ key: "t" }]) - expect(enabled.keybinds.get("theme.switch")).toEqual([]) - - const customized = resolve( - { session: { terminal: true }, keybinds: { "theme.switch": "t", "terminal.toggle": "p" } }, - { terminalSuspend: true }, - ) - expect(customized.keybinds.get("theme.switch")).toMatchObject([{ key: "t" }]) - expect(customized.keybinds.get("terminal.toggle")).toMatchObject([{ key: "p" }]) -}) - test("uses command IDs as keybind keys", () => { const config = resolve({ keybinds: { "session.list": "ctrl+l" } }, { terminalSuspend: true }) diff --git a/packages/tui/test/fixture/tui-client.ts b/packages/tui/test/fixture/tui-client.ts index c29c424a8f1..2a157caeb82 100644 --- a/packages/tui/test/fixture/tui-client.ts +++ b/packages/tui/test/fixture/tui-client.ts @@ -145,6 +145,7 @@ export function createFetch(override?: FetchHandler, events?: ReturnType