From f29bb4078b486d2ad13a8592b57fd22708bf036f Mon Sep 17 00:00:00 2001 From: David Hill <1879069+iamdavidhill@users.noreply.github.com> Date: Tue, 1 Sep 2026 00:03:43 +0000 Subject: [PATCH] fix(session-ui): reduce inline code height --- .../session-ui/component-tests/markdown.spec.ts | 13 +++++++++++++ packages/session-ui/src/components/markdown.css | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/packages/session-ui/component-tests/markdown.spec.ts b/packages/session-ui/component-tests/markdown.spec.ts index 84699cf5a25..2ed9b93cc7c 100644 --- a/packages/session-ui/component-tests/markdown.spec.ts +++ b/packages/session-ui/component-tests/markdown.spec.ts @@ -153,6 +153,19 @@ story("mounts cached completed Markdown with sanitized HTML and decorations", as await expect(markdown).toHaveAttribute("data-markdown-ready", "") }) +story("keeps inline code backgrounds 18px tall", async ({ page }) => { + await page.evaluate(async (fixture) => { + const { mountMarkdown } = await import(fixture) + await mountMarkdown({ text: "`value` and `src/file.ts`" }) + }, fixture) + const code = page.getByTestId("markdown-fixture").locator(":not(pre) > code") + await expect(code).toHaveCount(2) + await expect(code.nth(1)).toHaveAttribute("data-inline-code-kind", "path") + expect( + await code.evaluateAll((elements) => elements.map((element) => element.getBoundingClientRect().height)), + ).toEqual([18, 18]) +}) + story("shares in-flight Markdown rendering without overwriting a reclaimed cache entry", async ({ page }) => { const result = await page.evaluate(async (fixture) => { const { getCachedMarkdown, renderCachedMarkdown } = await import(fixture) diff --git a/packages/session-ui/src/components/markdown.css b/packages/session-ui/src/components/markdown.css index 6a53aabb803..f0e91e35eb8 100644 --- a/packages/session-ui/src/components/markdown.css +++ b/packages/session-ui/src/components/markdown.css @@ -283,7 +283,7 @@ font-feature-settings: var(--font-family-mono--font-feature-settings); color: var(--v2-text-text-base); font-weight: var(--font-weight-medium); - padding: 2px 4px; + padding: 0 4px; border-radius: 4px; background: color-mix(in oklch, var(--v2-text-text-base) var(--markdown-inline-code-bg-mix), transparent); }