From f06b78751e08ca38dc50da7f7ca1c408e6ad6298 Mon Sep 17 00:00:00 2001 From: Luke Parker <10430890+Hona@users.noreply.github.com> Date: Mon, 18 May 2026 09:23:32 +1000 Subject: [PATCH] fix(desktop): install the latest available update (#27953) --- packages/desktop/src/main/updater.ts | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/packages/desktop/src/main/updater.ts b/packages/desktop/src/main/updater.ts index b7f4bce785..ec66e4f963 100644 --- a/packages/desktop/src/main/updater.ts +++ b/packages/desktop/src/main/updater.ts @@ -6,8 +6,6 @@ import { initLogging } from "./logging" const logger = initLogging() const { autoUpdater } = pkg -let downloadedUpdateVersion: string | undefined - export function setupAutoUpdater() { if (!UPDATER_ENABLED) return autoUpdater.logger = logger @@ -26,12 +24,6 @@ export function setupAutoUpdater() { export async function checkUpdate() { if (!UPDATER_ENABLED) return { updateAvailable: false } - if (downloadedUpdateVersion) { - logger.log("returning cached downloaded update", { - version: downloadedUpdateVersion, - }) - return { updateAvailable: true, version: downloadedUpdateVersion } - } logger.log("checking for updates", { currentVersion: app.getVersion(), channel: autoUpdater.channel, @@ -57,7 +49,6 @@ export async function checkUpdate() { logger.log("update available", { version }) await autoUpdater.downloadUpdate() logger.log("update download completed", { version }) - downloadedUpdateVersion = version return { updateAvailable: true, version } } catch (error) { logger.error("update check failed", error) @@ -66,14 +57,15 @@ export async function checkUpdate() { } export async function installUpdate(killSidecar: () => Promise) { - if (!downloadedUpdateVersion) { + const result = await checkUpdate() + if (!result.updateAvailable) { logger.log("install update skipped", { - reason: "no downloaded update ready", + reason: result.failed ? "update check failed" : "no update available", }) return } logger.log("installing downloaded update", { - version: downloadedUpdateVersion, + version: result.version ?? null, }) await killSidecar() autoUpdater.quitAndInstall()