From ce005ce0023a6fdc33b17f5ff59cdc685d4f353c Mon Sep 17 00:00:00 2001 From: Kit Langton Date: Fri, 28 Aug 2026 16:44:27 -0400 Subject: [PATCH] refactor(core): remove unused result plumbing (#45695) --- packages/core/src/bus.ts | 6 +----- packages/core/src/ripgrep.ts | 14 +++++--------- packages/core/src/session/stats.ts | 2 +- 3 files changed, 7 insertions(+), 15 deletions(-) diff --git a/packages/core/src/bus.ts b/packages/core/src/bus.ts index efd00328f27..4d3f7965326 100644 --- a/packages/core/src/bus.ts +++ b/packages/core/src/bus.ts @@ -859,16 +859,12 @@ export function configured(options?: Options) { aggregateID: input.aggregateID, ...(target >= 0 ? { seq: Event.Seq.make(target) } : {}), } - const replay: Stream.Stream = readThrough(target).pipe( - Stream.map((event): LogItem => event), - Stream.concat(Stream.make(marker)), - ) + const replay: Stream.Stream = readThrough(target).pipe(Stream.concat(Stream.make(marker))) if (!wakes) return replay const live: Stream.Stream = Stream.fromSubscription(wakes).pipe( Stream.mapEffect(() => latestSequence(db, input.aggregateID)), Stream.filter((target) => target > sequence), Stream.flatMap((target) => readThrough(target)), - Stream.map((event): LogItem => event), ) return Stream.concat(replay, live) }), diff --git a/packages/core/src/ripgrep.ts b/packages/core/src/ripgrep.ts index 0b092fe51b7..669982f236f 100644 --- a/packages/core/src/ripgrep.ts +++ b/packages/core/src/ripgrep.ts @@ -134,10 +134,9 @@ const layer = Layer.effect( }), Stream.take(input.limit + 1), Stream.runCollect, - Effect.map((chunk) => [...chunk]), ) const truncated = rows.length > input.limit - if (truncated) return { items: rows.slice(0, input.limit), truncated, partial: false } + if (truncated) return rows.slice(0, input.limit) const code = yield* handle.exitCode const stderr = yield* Fiber.join(stderrFiber) @@ -147,7 +146,7 @@ const layer = Layer.effect( if (code !== 0 && code !== 1 && code !== 2) { return yield* failure(stderr.trim() || `ripgrep failed with code ${code}`) } - return { items: code === 1 ? [] : rows, truncated: false, partial: code === 2 } + return code === 1 ? [] : rows }), ) const abortable = input.signal ? program.pipe(Effect.raceFirst(waitForAbort(input.signal))) : program @@ -178,7 +177,7 @@ const layer = Layer.effect( parse: (line) => Effect.succeed(normalizePath(line)), }).pipe( Effect.map((result) => - result.items.map((relative) => + result.map((relative) => Entry.make({ path: RelativePath.make(relative), type: "file", @@ -212,10 +211,7 @@ const layer = Layer.effect( ) }, onItem: input.onEntry, - }).pipe( - Effect.map((result) => result.items), - Effect.catchTag("Ripgrep.InvalidPatternError", (cause) => Effect.fail(failure(cause.message, cause))), - ), + }).pipe(Effect.catchTag("Ripgrep.InvalidPatternError", (cause) => Effect.fail(failure(cause.message, cause)))), grep: (input) => run({ ...input, @@ -248,7 +244,7 @@ const layer = Layer.effect( ), }).pipe( Effect.map((result) => - result.items.map((match) => + result.map((match) => Match.make({ entry: Entry.make({ path: RelativePath.make(match.path.text), diff --git a/packages/core/src/session/stats.ts b/packages/core/src/session/stats.ts index 0086668ad79..057ca61fe44 100644 --- a/packages/core/src/session/stats.ts +++ b/packages/core/src/session/stats.ts @@ -287,7 +287,7 @@ export const get = Effect.fn("SessionStats.get")(function* (input: Input = {}) { batches(ids.map((row) => row.id)), (batch) => db - .select({ created: EventTable.created, data: EventTable.data }) + .select({ data: EventTable.data }) .from(EventTable) .where( and(