From baf476f4317f941d1ef07f4780bf09fccc2a2209 Mon Sep 17 00:00:00 2001 From: LukeParkerDev <10430890+Hona@users.noreply.github.com> Date: Fri, 3 Apr 2026 14:29:04 +1000 Subject: [PATCH] test(shell): handle nullable exit metadata Make the shell exit assertions typecheck cleanly while keeping the PowerShell regression coverage. Remove the accidentally committed .opencode package-lock so generated state does not ship in the branch. --- packages/opencode/.opencode/package-lock.json | 31 ------------------- packages/opencode/test/tool/shell.test.ts | 10 +++--- 2 files changed, 5 insertions(+), 36 deletions(-) delete mode 100644 packages/opencode/.opencode/package-lock.json diff --git a/packages/opencode/.opencode/package-lock.json b/packages/opencode/.opencode/package-lock.json deleted file mode 100644 index c36f597373..0000000000 --- a/packages/opencode/.opencode/package-lock.json +++ /dev/null @@ -1,31 +0,0 @@ -{ - "name": ".opencode", - "lockfileVersion": 3, - "requires": true, - "packages": { - "": { - "dependencies": { - "@opencode-ai/plugin": "*" - } - }, - "node_modules/@opencode-ai/plugin": { - "version": "1.2.24", - "license": "MIT", - "dependencies": { - "@opencode-ai/sdk": "1.2.24", - "zod": "4.1.8" - } - }, - "node_modules/@opencode-ai/sdk": { - "version": "1.2.24", - "license": "MIT" - }, - "node_modules/zod": { - "version": "4.1.8", - "license": "MIT", - "funding": { - "url": "https://github.com/sponsors/colinhacks" - } - } - } -} diff --git a/packages/opencode/test/tool/shell.test.ts b/packages/opencode/test/tool/shell.test.ts index 39b54a7a26..224e4d6fc5 100644 --- a/packages/opencode/test/tool/shell.test.ts +++ b/packages/opencode/test/tool/shell.test.ts @@ -155,7 +155,7 @@ describe("tool.shell", () => { }, ctx, ) - expect(result.metadata.exit).toBe(0) + expect(result.metadata.exit ?? -1).toBe(0) expect(result.metadata.output).toContain("test") }, }) @@ -1005,7 +1005,7 @@ describe("tool.shell runtime", () => { ) expect(result.output).toContain("333") expect(result.output).toContain("444") - expect(result.metadata.exit).toBe(0) + expect(result.metadata.exit ?? -1).toBe(0) }, }) }) @@ -1022,7 +1022,7 @@ describe("tool.shell runtime", () => { }, ctx, ) - expect(result.metadata.exit).toBe(42) + expect(result.metadata.exit ?? -1).toBe(42) }, }) }) @@ -1039,7 +1039,7 @@ describe("tool.shell runtime", () => { }, ctx, ) - expect(result.metadata.exit).toBe(42) + expect(result.metadata.exit ?? -1).toBe(42) }, }) }) @@ -1056,7 +1056,7 @@ describe("tool.shell runtime", () => { }, ctx, ) - expect(result.metadata.exit).toBe(1) + expect(result.metadata.exit ?? -1).toBe(1) }, }) })