vrr/opencode
2
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-05-17 12:42:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 17

docs(server): explain why HTTP API PTY handler has no early-frame buffer (#26464)

Browse source
This commit is contained in:
Kit Langton 2026-05-08 23:58:33 -04:00 • committed by GitHub
parent dcb8ed8eb0
commit 96bde05f6e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
packages/opencode/src/server/routes/instance/httpapi/handlers/pty.ts
View file

@ -153,6 +153,12 @@ export const ptyConnectRoute = HttpRouter.use((router) =>
return HttpServerResponse.empty()
}
// No `pending[]`-style early-frame buffer (the legacy Hono handler had one).
// `request.upgrade` returns a Socket without running the WS handshake; the
// handshake fires inside `socket.runRaw` below, AFTER `pty.connect` resolves
// and the message callback is registered. The client therefore can't fire
// `open` and start sending until the listener is already wired. Don't move
// `runRaw` ahead of `pty.connect` without re-introducing a buffer.
yield* socket
.runRaw((message) => handlePtyInput(handler, message))
.pipe(