From 93e8b75ccac0ae0a5579d91372893de2f83d5af2 Mon Sep 17 00:00:00 2001 From: Aiden Cline <63023139+rekram1-node@users.noreply.github.com> Date: Mon, 3 Aug 2026 15:58:08 -0500 Subject: [PATCH] refactor(schema): rename agent default constructor (#40324) --- packages/core/src/agent.ts | 2 +- packages/core/test/agent.test.ts | 2 +- packages/core/test/mcp-instructions.test.ts | 2 +- packages/core/test/shared-schema.test.ts | 2 +- packages/core/test/skill/instructions.test.ts | 14 +++++++------- packages/schema/src/agent.ts | 2 +- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/packages/core/src/agent.ts b/packages/core/src/agent.ts index 548dcdb2aa6..13cdca22291 100644 --- a/packages/core/src/agent.ts +++ b/packages/core/src/agent.ts @@ -61,7 +61,7 @@ const layer = Layer.effect( draft.default = id }, update: (id, fn) => { - const current = draft.agents.get(id) ?? (Info.empty(id) as Types.DeepMutable) + const current = draft.agents.get(id) ?? (Info.default(id) as Types.DeepMutable) if (!draft.agents.has(id)) draft.agents.set(id, current) fn(current) current.id = id diff --git a/packages/core/test/agent.test.ts b/packages/core/test/agent.test.ts index 41aeee99eca..645db471d79 100644 --- a/packages/core/test/agent.test.ts +++ b/packages/core/test/agent.test.ts @@ -120,7 +120,7 @@ describe("Agent", () => { const id = Agent.ID.make("custom") yield* agent.transform((editor) => editor.update(id, () => {})) - expect(yield* agent.get(id)).toEqual(Agent.Info.empty(id)) + expect(yield* agent.get(id)).toEqual(Agent.Info.default(id)) yield* agent.transform((editor) => editor.remove(id)) expect(yield* agent.get(id)).toBeUndefined() diff --git a/packages/core/test/mcp-instructions.test.ts b/packages/core/test/mcp-instructions.test.ts index 44efd76b241..9543a10fac0 100644 --- a/packages/core/test/mcp-instructions.test.ts +++ b/packages/core/test/mcp-instructions.test.ts @@ -12,7 +12,7 @@ import { readInitial, readUpdate } from "./lib/instructions" const build = Agent.ID.make("build") const selection = (permissions: Permission.Ruleset = []) => { - const info = Agent.Info.make({ ...Agent.Info.empty(build), permissions }) + const info = Agent.Info.make({ ...Agent.Info.default(build), permissions }) return { id: info.id, info } } diff --git a/packages/core/test/shared-schema.test.ts b/packages/core/test/shared-schema.test.ts index 9f30aca2faf..ac57342e8db 100644 --- a/packages/core/test/shared-schema.test.ts +++ b/packages/core/test/shared-schema.test.ts @@ -166,7 +166,7 @@ test("Core reuses the canonical shared schemas", async () => { ] for (const [core, shared] of schemas) expect(core).toBe(shared) - expect(Agent.Info.empty(Agent.ID.make("test"))).toEqual(Agent.Info.empty(Agent.ID.make("test"))) + expect(Agent.Info.default(Agent.ID.make("test"))).toEqual(Agent.Info.default(Agent.ID.make("test"))) expect(coreModel.Info.default(coreProvider.ID.make("test"), coreModel.ID.make("model"))).toEqual( Model.Info.default(Provider.ID.make("test"), Model.ID.make("model")), ) diff --git a/packages/core/test/skill/instructions.test.ts b/packages/core/test/skill/instructions.test.ts index a062c10f6ad..dcb54d478ed 100644 --- a/packages/core/test/skill/instructions.test.ts +++ b/packages/core/test/skill/instructions.test.ts @@ -47,7 +47,7 @@ const layer = (list: () => Skill.Info[]) => describe("SkillInstructions", () => { it.effect("renders described agent skills and updates the complete available list", () => { const agent = Agent.Info.make({ - ...Agent.Info.empty(build), + ...Agent.Info.default(build), permissions: [{ action: "skill", resource: "denied", effect: "deny" }], }) let skills = [hidden, denied, manual, effect] @@ -80,7 +80,7 @@ describe("SkillInstructions", () => { }) it.effect("announces added and removed skills as deltas without restating the list", () => { - const agent = Agent.Info.make(Agent.Info.empty(build)) + const agent = Agent.Info.make(Agent.Info.default(build)) const debugging = Skill.Info.make({ id: Skill.ID.make("debugging"), name: Skill.Name.make("Debugging"), @@ -117,7 +117,7 @@ describe("SkillInstructions", () => { }) it.effect("restates the full skill list when a description changes", () => { - const agent = Agent.Info.make(Agent.Info.empty(build)) + const agent = Agent.Info.make(Agent.Info.default(build)) let skills = [effect] return Effect.gen(function* () { const instructions = yield* SkillInstructions.Service @@ -138,7 +138,7 @@ describe("SkillInstructions", () => { it.effect("omits instructions when the selected agent denies all skills", () => { const agent = Agent.Info.make({ - ...Agent.Info.empty(build), + ...Agent.Info.default(build), permissions: [{ action: "skill", resource: "*", effect: "deny" }], }) return Effect.gen(function* () { @@ -149,7 +149,7 @@ describe("SkillInstructions", () => { it.effect("omits instructions when a resource-specific denial follows the global denial", () => { const agent = Agent.Info.make({ - ...Agent.Info.empty(build), + ...Agent.Info.default(build), permissions: [ { action: "skill", resource: "*", effect: "deny" }, { action: "skill", resource: "hidden", effect: "deny" }, @@ -163,7 +163,7 @@ describe("SkillInstructions", () => { it.effect("retains specifically allowed skills after a global denial", () => { const agent = Agent.Info.make({ - ...Agent.Info.empty(build), + ...Agent.Info.default(build), permissions: [ { action: "skill", resource: "*", effect: "deny" }, { action: "skill", resource: "effect", effect: "allow" }, @@ -179,7 +179,7 @@ describe("SkillInstructions", () => { it.effect("omits instructions when a specifically allowed skill is denied again", () => { const agent = Agent.Info.make({ - ...Agent.Info.empty(build), + ...Agent.Info.default(build), permissions: [ { action: "skill", resource: "*", effect: "deny" }, { action: "skill", resource: "effect", effect: "allow" }, diff --git a/packages/schema/src/agent.ts b/packages/schema/src/agent.ts index 8001a2967ee..3bde5a1facb 100644 --- a/packages/schema/src/agent.ts +++ b/packages/schema/src/agent.ts @@ -36,7 +36,7 @@ export const Info = Schema.Struct({ .annotate({ identifier: "Agent.Info" }) .pipe( statics(() => ({ - empty: (id: ID) => + default: (id: ID) => ({ id, name: Name.make(id),