vrr/opencode
2
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-07-10 05:08:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

fix(tui): keep session running until execution settles (#35136)

Browse source
This commit is contained in:
Shoubhit Dash 2026-07-03 17:23:30 +05:30 • committed by GitHub
parent b62d24e40b
commit 8d790a9ed5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 35 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
packages/tui/src/context/data.tsx
View file

@ -344,7 +344,7 @@ export const { use: useData, provider: DataProvider } = createSimpleContext({
})
break
case "session.next.step.ended":
setStore("session", "status", event.data.sessionID, event.data.finish === "tool-calls" ? "running" : "idle")
setStore("session", "status", event.data.sessionID, "running")
message.update(event.data.sessionID, (draft, index) => {
const currentAssistant = message.assistant(draft, index, event.data.assistantMessageID)
if (!currentAssistant) return
@ -357,7 +357,6 @@ export const { use: useData, provider: DataProvider } = createSimpleContext({
})
break
case "session.next.step.failed":
setStore("session", "status", event.data.sessionID, "idle")
message.update(event.data.sessionID, (draft, index) => {
const currentAssistant = message.assistant(draft, index, event.data.assistantMessageID)
if (!currentAssistant) return
@ -527,6 +526,9 @@ export const { use: useData, provider: DataProvider } = createSimpleContext({
case "session.next.compaction.started":
setStore("session", "status", event.data.sessionID, "running")
break
case "session.next.execution.settled":
setStore("session", "status", event.data.sessionID, "idle")
break
case "session.next.revert.staged":
if (store.session.info[event.data.sessionID])
setStore("session", "info", event.data.sessionID, "revert", event.data.revert)

31
packages/tui/test/cli/tui/data.test.tsx
View file

@ -283,6 +283,21 @@ test("tracks session status from active sessions and execution events", async ()
tokens: { input: 0, output: 0, reasoning: 0, cache: { read: 0, write: 0 } },
},
})
await wait(() => {
const assistant = data.session.message.get("session-live", "message-live")
return assistant?.type === "assistant" && assistant.finish === "stop"
})
expect(data.session.status("session-live")).toBe("running")
emitEvent(events, {
id: "evt_execution_settled",
type: "session.next.execution.settled",
data: {
sessionID: "session-live",
timestamp: 3,
outcome: "success",
},
})
await wait(() => data.session.status("session-live") === "idle")
emitEvent(events, {
@ -308,6 +323,22 @@ test("tracks session status from active sessions and execution events", async ()
error: { type: "unknown", message: "Provider unavailable" },
},
})
await wait(() => {
const assistant = data.session.message.get("session-failed", "message-failed")
return assistant?.type === "assistant" && assistant.finish === "error"
})
expect(data.session.status("session-failed")).toBe("running")
emitEvent(events, {
id: "evt_failed_execution_settled",
type: "session.next.execution.settled",
data: {
sessionID: "session-failed",
timestamp: 5,
outcome: "failure",
error: { type: "unknown", message: "Provider unavailable" },
},
})
await wait(() => data.session.status("session-failed") === "idle")
} finally {
app.renderer.destroy()