From 686127f809e386dad1115e04357ea32b7a04a8ff Mon Sep 17 00:00:00 2001 From: Kit Langton Date: Wed, 5 Aug 2026 14:30:29 -0400 Subject: [PATCH] refactor(core): remove unreachable repository validation (#40700) --- packages/core/src/repository-cache.ts | 17 ----------------- packages/core/src/repository.ts | 10 ---------- packages/core/test/repository-cache.test.ts | 5 +---- 3 files changed, 1 insertion(+), 31 deletions(-) diff --git a/packages/core/src/repository-cache.ts b/packages/core/src/repository-cache.ts index 77bd868e01c..8b78d9914f5 100644 --- a/packages/core/src/repository-cache.ts +++ b/packages/core/src/repository-cache.ts @@ -31,14 +31,6 @@ export type EnsureInput = { readonly branch?: string } -export class InvalidRepositoryError extends Schema.TaggedErrorClass()( - "RepositoryCacheInvalidRepositoryError", - { - repository: Schema.String, - message: Schema.String, - }, -) {} - export class InvalidBranchError extends Schema.TaggedErrorClass()( "RepositoryCacheInvalidBranchError", { @@ -86,7 +78,6 @@ export class CacheOperationError extends Schema.TaggedErrorClass()("@opencode/Re export function isError(error: unknown): error is Error { return ( - error instanceof InvalidRepositoryError || error instanceof InvalidBranchError || error instanceof CloneFailedError || error instanceof FetchFailedError || @@ -114,13 +104,6 @@ export function isError(error: unknown): error is Error { ) } -export const parseRemote = Effect.fn("RepositoryCache.parseRemote")(function* (repository: string) { - return yield* Effect.try({ - try: () => Repository.parseRemote(repository), - catch: (error) => new InvalidRepositoryError({ repository, message: errorMessage(error) }), - }) -}) - export const validateBranch = Effect.fn("RepositoryCache.validateBranch")(function* (branch: string) { return yield* Effect.try({ try: () => Repository.validateBranch(branch), diff --git a/packages/core/src/repository.ts b/packages/core/src/repository.ts index 8ee5be600e3..1e84bf828d6 100644 --- a/packages/core/src/repository.ts +++ b/packages/core/src/repository.ts @@ -44,16 +44,6 @@ export class InvalidBranchError extends Schema.TaggedErrorClass { ), ) - it.live("returns typed validation and clone failures", () => + it.live("returns typed branch validation and clone failures", () => withRemote((fixture) => Effect.gen(function* () { const cache = yield* RepositoryCache.Service - const invalidRepository = yield* Effect.flip(RepositoryCache.parseRemote("not-a-repo")) - expect(invalidRepository).toBeInstanceOf(RepositoryCache.InvalidRepositoryError) - const invalidBranch = yield* Effect.flip(cache.ensure({ reference: fixture.reference, branch: "../unsafe" })) expect(invalidBranch).toBeInstanceOf(RepositoryCache.InvalidBranchError)