vrr/opencode
2
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-05-17 12:42:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 17

perf(app): unmount closed review panel (#27221)

Browse source
This commit is contained in:
Luke Parker 2026-05-13 12:09:34 +10:00 • committed by GitHub
parent 0879f5e22d
commit 0f8517208b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
packages/app/src/pages/session/review-tab.tsx
View file

@ -32,7 +32,7 @@ export interface SessionReviewTabProps {
focusedComment?: { file: string; id: string } | null
onFocusedCommentChange?: (focus: { file: string; id: string } | null) => void
focusedFile?: string
onScrollRef?: (el: HTMLDivElement) => void
onScrollRef?: (el: HTMLDivElement | undefined) => void
commentMentions?: {
items: (query: string) => string[] | Promise<string[]>
}
@ -126,6 +126,7 @@ export function SessionReviewTab(props: SessionReviewTabProps) {
onCleanup(() => {
if (restoreFrame !== undefined) cancelAnimationFrame(restoreFrame)
props.onScrollRef?.(undefined)
})
return (

8
packages/app/src/pages/session/session-side-panel.tsx
View file

@ -221,7 +221,8 @@ export function SessionSidePanel(props: {
}}
style={{ width: panelWidth() }}
>
<div class="size-full flex border-l border-border-weaker-base">
<Show when={open()}>
<div class="size-full flex border-l border-border-weaker-base">
<div
aria-hidden={!reviewOpen()}
inert={!reviewOpen()}
@ -313,7 +314,7 @@ export function SessionSidePanel(props: {
<Show when={reviewTab() && props.canReview()}>
<Tabs.Content value="review" class="flex flex-col h-full overflow-hidden contain-strict">
<Show when={activeTab() === "review"}>{props.reviewPanel()}</Show>
<Show when={reviewOpen() && activeTab() === "review"}>{props.reviewPanel()}</Show>
</Tabs.Content>
</Show>
@ -453,7 +454,8 @@ export function SessionSidePanel(props: {
</Show>
</div>
</Show>
</div>
</div>
</Show>
</aside>
</Show>
)