mirror of
https://github.com/openclaw/openclaw.git
synced 2026-10-03 17:53:39 +00:00
Cancellation did not prove an infrastructure error or absence of executed and failed tests, yet the sweeper automatically replayed whole workflows. The three-day census found nine such reruns, including five CI workflows. Remove canceled-run revival. Keep bounded recovery for missing or startup-failed CI before tests execute, with infrastructure warnings and the existing live head/PR checks. The actual sweeper boundary changed from one canceled-run replay to zero without a PR mutation. Both shared-fixture importers passed 20 standalone runs and three replays under their CI configs on Testbox.
363 lines
14 KiB
JavaScript
363 lines
14 KiB
JavaScript
// Repairs missing pull_request CI and GitHub startup_failure runs via bounded
|
|
// close/reopen after the merge ref settles. Executed or cancelled workflows are
|
|
// never automatically rerun. The GitHub App token lets the reopen trigger CI;
|
|
// GITHUB_TOKEN-authored events would not start new workflows.
|
|
//
|
|
// Observability contract: the re-fire lane logs a decision for every scanned
|
|
// PR, including ci-attached skips with the attached run ids. A PR absent from
|
|
// the log was outside the scan (created before the lookback), never silently
|
|
// classified — silent skips previously made a correctly-skipped PR look like a
|
|
// missed dropped-CI PR (2026-07-24, #113355).
|
|
|
|
const CI_WORKFLOW_FILE = "ci.yml";
|
|
const LOOKBACK_MS = 24 * 60 * 60 * 1000;
|
|
// Give GitHub time to settle merge-ref computation and late run attachment
|
|
// before judging a head SHA as dropped.
|
|
const MIN_QUIET_MS = 10 * 60 * 1000;
|
|
// Two bot closes per PR: a head that still has no CI after two re-fires needs
|
|
// a human, not an hourly close/reopen loop.
|
|
const MAX_BOT_CLOSES = 2;
|
|
const MAX_REFIRES_PER_SWEEP = 10;
|
|
// Known sweeper identities for the close budget. The fallback app's login is
|
|
// only recognized while it is the active identity, so an auth failover can at
|
|
// worst double the budget to four re-fires — still bounded, and the
|
|
// newest-close ownership check keeps human closes authoritative regardless.
|
|
const KNOWN_SWEEPER_LOGINS = ["openclaw-barnacle[bot]"];
|
|
const REOPEN_DELAY_MS = 5_000;
|
|
|
|
const sleep = (ms) =>
|
|
new Promise((resolve) => {
|
|
setTimeout(resolve, ms);
|
|
});
|
|
|
|
/**
|
|
* @param {{
|
|
* pr: {
|
|
* draft?: boolean;
|
|
* created_at: string;
|
|
* updated_at: string;
|
|
* mergeable?: boolean | null;
|
|
* auto_merge?: object | null;
|
|
* };
|
|
* ciRuns: Array<{ conclusion: string | null }>;
|
|
* botCloseCount: number;
|
|
* now: number;
|
|
* }} params
|
|
* @returns {{ action: "refire" | "skip"; reason: string }}
|
|
*/
|
|
export function classifyPrForSweep({ pr, ciRuns, botCloseCount, now }) {
|
|
if (pr.draft) {
|
|
return { action: "skip", reason: "draft" };
|
|
}
|
|
if (now - Date.parse(pr.updated_at) < MIN_QUIET_MS) {
|
|
return { action: "skip", reason: "recently-updated" };
|
|
}
|
|
// A conflicted PR legitimately has no merge ref; CI cannot attach until the
|
|
// author resolves, so re-firing would loop forever. Null/unknown mergeability
|
|
// is NOT skipped: live testing showed dropped-CI PRs stay mergeable=null
|
|
// indefinitely (the stuck merge-ref computation IS the pathology), and
|
|
// close/reopen is what un-sticks it. A not-yet-computed conflict costs at
|
|
// most one budgeted re-fire before the recomputed false skips it.
|
|
if (pr.mergeable === false) {
|
|
return { action: "skip", reason: "merge-conflict" };
|
|
}
|
|
// Closing a PR silently cancels enabled auto-merge and reopening does not
|
|
// restore it; preserve the operator's auto-merge preference.
|
|
if (pr.auto_merge) {
|
|
return { action: "skip", reason: "auto-merge-enabled" };
|
|
}
|
|
// Queued and in-progress runs have a null conclusion and count as attached.
|
|
if (ciRuns.some((run) => run.conclusion !== "startup_failure")) {
|
|
return { action: "skip", reason: "ci-attached" };
|
|
}
|
|
if (botCloseCount >= MAX_BOT_CLOSES) {
|
|
return { action: "skip", reason: "refire-budget-exhausted" };
|
|
}
|
|
return {
|
|
action: "refire",
|
|
reason: ciRuns.length === 0 ? "ci-run-missing" : "ci-startup-failure",
|
|
};
|
|
}
|
|
|
|
async function listRecentOpenPrs({ github, owner, repo, now }) {
|
|
// Sort by creation time, which is immutable: updated-sort pagination shifts
|
|
// items between page fetches whenever bot activity bumps a PR mid-scan, and a
|
|
// boundary PR can silently drop out of the listing. Only act on PRs created
|
|
// within the lookback, so stop fetching once a page crosses that
|
|
// horizon instead of listing every open PR (~2900 at last count, hourly).
|
|
return await github.paginate(
|
|
github.rest.pulls.list,
|
|
{ owner, repo, state: "open", sort: "created", direction: "desc", per_page: 100 },
|
|
(response, done) => {
|
|
if (response.data.some((item) => now - Date.parse(item.created_at) > LOOKBACK_MS)) {
|
|
done();
|
|
}
|
|
return response.data;
|
|
},
|
|
);
|
|
}
|
|
|
|
async function listPullRequestCiRuns({ github, owner, repo, headSha }) {
|
|
// Manual dispatches or other events against the same SHA neither prove nor
|
|
// repair the dropped pull_request run; judge only pull_request-event runs,
|
|
// filtered server-side and paginated so unrelated runs cannot crowd them out.
|
|
// Accepted tradeoff: a SHA shared by two PRs can mask one PR's dropped run
|
|
// behind the other's — a skip-only miss. Matching run.pull_requests instead
|
|
// would misclassify fork PRs, where GitHub leaves that array empty.
|
|
return await github.paginate(github.rest.actions.listWorkflowRuns, {
|
|
owner,
|
|
repo,
|
|
workflow_id: CI_WORKFLOW_FILE,
|
|
head_sha: headSha,
|
|
event: "pull_request",
|
|
per_page: 100,
|
|
});
|
|
}
|
|
|
|
// Our close call succeeded against a verified-open PR, so the sweeper owns the
|
|
// transition unless a newer close event by someone else is positively visible
|
|
// (a human close in the millisecond race window makes our update an eventless
|
|
// no-op). Stale or lagging event reads must therefore default to "ours".
|
|
async function someoneElseClosed({
|
|
github,
|
|
owner,
|
|
repo,
|
|
pullNumber,
|
|
sweeperLogins,
|
|
knownCloseIds,
|
|
}) {
|
|
const events = await github.paginate(github.rest.issues.listEvents, {
|
|
owner,
|
|
repo,
|
|
issue_number: pullNumber,
|
|
per_page: 100,
|
|
});
|
|
const newClose = events.findLast(
|
|
(event) => event.event === "closed" && !knownCloseIds.has(event.id),
|
|
);
|
|
if (!newClose?.actor) {
|
|
return false;
|
|
}
|
|
return !(newClose.actor.type === "Bot" && sweeperLogins.has(newClose.actor.login));
|
|
}
|
|
|
|
async function reopenWithRetry({ github, core, owner, repo, pullNumber }) {
|
|
let lastError;
|
|
for (let attempt = 1; attempt <= 3; attempt += 1) {
|
|
try {
|
|
await github.rest.pulls.update({ owner, repo, pull_number: pullNumber, state: "open" });
|
|
return true;
|
|
} catch (error) {
|
|
lastError = error;
|
|
if (attempt < 3) {
|
|
core.warning(
|
|
`pr-ci-sweeper: GitHub reopen failed for #${pullNumber}; retrying infrastructure recovery (${attempt}/3)`,
|
|
);
|
|
}
|
|
await sleep(REOPEN_DELAY_MS * attempt);
|
|
}
|
|
}
|
|
// Never leave a swept PR closed silently: surface on the PR and fail the run.
|
|
await github.rest.issues
|
|
.createComment({
|
|
owner,
|
|
repo,
|
|
issue_number: pullNumber,
|
|
body: "PR CI Sweeper closed this PR to re-fire a dropped CI run but could not reopen it. Please reopen manually.",
|
|
})
|
|
.catch(() => undefined);
|
|
core.setFailed(`pr-ci-sweeper: failed to reopen #${pullNumber}: ${String(lastError)}`);
|
|
return false;
|
|
}
|
|
|
|
/**
|
|
* @param {{
|
|
* github: Record<string, unknown>;
|
|
* context: Record<string, unknown>;
|
|
* core: Pick<Console, "info"> & { warning: (message: string) => void; setFailed: (message: string) => void };
|
|
* dryRun?: boolean;
|
|
* appSlug?: string;
|
|
* now?: number;
|
|
* }} params
|
|
* @returns {Promise<Array<{
|
|
* number: number;
|
|
* sha: string;
|
|
* action: "refire" | "skip";
|
|
* reason: string;
|
|
* }>>}
|
|
*/
|
|
export async function runPrCiSweeper({
|
|
github,
|
|
context,
|
|
core,
|
|
dryRun = false,
|
|
appSlug = "",
|
|
// Injectable clock: fixture-based tests pin a fixed instant so lookback
|
|
// classification cannot rot as wall-clock time passes the fixture dates.
|
|
now = Date.now(),
|
|
}) {
|
|
const sweeperLogins = new Set(KNOWN_SWEEPER_LOGINS);
|
|
if (appSlug) {
|
|
sweeperLogins.add(`${appSlug}[bot]`);
|
|
}
|
|
const { owner, repo } = context.repo;
|
|
const results = [];
|
|
let refires = 0;
|
|
const openPrs = await listRecentOpenPrs({ github, owner, repo, now });
|
|
|
|
for (const listed of openPrs) {
|
|
if (now - Date.parse(listed.created_at) > LOOKBACK_MS) {
|
|
break;
|
|
}
|
|
if (listed.draft) {
|
|
results.push({
|
|
number: listed.number,
|
|
sha: listed.head.sha.slice(0, 12),
|
|
action: "skip",
|
|
reason: "draft",
|
|
});
|
|
core.info(`pr-ci-sweeper: skip #${listed.number} (draft)`);
|
|
continue;
|
|
}
|
|
const ciRuns = await listPullRequestCiRuns({ github, owner, repo, headSha: listed.head.sha });
|
|
// Classify on cheap list data first so most PRs (usually ci-attached) skip
|
|
// without the authoritative pulls.get + close-history reads, but still log
|
|
// the decision with the attached run ids as evidence: the silent skip here
|
|
// previously made "sweeper judged CI attached" indistinguishable from
|
|
// "sweeper never saw the PR".
|
|
const preliminary = classifyPrForSweep({ pr: listed, ciRuns, botCloseCount: 0, now });
|
|
if (preliminary.action !== "refire") {
|
|
const attachedRuns = ciRuns
|
|
.filter((run) => run.conclusion !== "startup_failure")
|
|
.map((run) => `${run.id ?? "?"}:${run.status ?? "?"}/${run.conclusion ?? "pending"}`);
|
|
const detail = preliminary.reason === "ci-attached" ? `: ${attachedRuns.join(", ")}` : "";
|
|
results.push({ number: listed.number, sha: listed.head.sha.slice(0, 12), ...preliminary });
|
|
core.info(`pr-ci-sweeper: skip #${listed.number} (${preliminary.reason}${detail})`);
|
|
continue;
|
|
}
|
|
// Past the cap, keep classifying (so every scanned PR still gets a logged
|
|
// decision) but convert would-be re-fires into skips instead of mutating.
|
|
if (refires >= MAX_REFIRES_PER_SWEEP) {
|
|
results.push({
|
|
number: listed.number,
|
|
sha: listed.head.sha.slice(0, 12),
|
|
action: "skip",
|
|
reason: "refire-cap-reached",
|
|
});
|
|
core.info(`pr-ci-sweeper: skip #${listed.number} (refire-cap-reached)`);
|
|
continue;
|
|
}
|
|
// Candidate: fetch authoritative state (mergeable, current head) and the
|
|
// close history so a racing push or human action wins over the sweep.
|
|
const { data: pr } = await github.rest.pulls.get({ owner, repo, pull_number: listed.number });
|
|
if (pr.state !== "open" || pr.head.sha !== listed.head.sha) {
|
|
results.push({
|
|
number: listed.number,
|
|
sha: listed.head.sha.slice(0, 12),
|
|
action: "skip",
|
|
reason: "changed-during-sweep",
|
|
});
|
|
core.info(`pr-ci-sweeper: #${listed.number} changed during sweep; leaving it alone`);
|
|
continue;
|
|
}
|
|
const events = await github.paginate(github.rest.issues.listEvents, {
|
|
owner,
|
|
repo,
|
|
issue_number: pr.number,
|
|
per_page: 100,
|
|
});
|
|
// Budget counts only this sweeper's own closes so unrelated bot
|
|
// automation cannot exhaust a PR's re-fire allowance.
|
|
const botCloseCount = events.filter(
|
|
(event) =>
|
|
event.event === "closed" &&
|
|
event.actor?.type === "Bot" &&
|
|
sweeperLogins.has(event.actor.login),
|
|
).length;
|
|
const verdict = classifyPrForSweep({ pr, ciRuns, botCloseCount, now });
|
|
if (verdict.action !== "refire") {
|
|
results.push({ number: pr.number, sha: pr.head.sha.slice(0, 12), ...verdict });
|
|
core.info(`pr-ci-sweeper: skip #${pr.number} (${verdict.reason})`);
|
|
continue;
|
|
}
|
|
if (dryRun) {
|
|
refires += 1;
|
|
results.push({ number: pr.number, sha: pr.head.sha.slice(0, 12), ...verdict });
|
|
core.info(`pr-ci-sweeper: dry-run, would re-fire #${pr.number} (${verdict.reason})`);
|
|
continue;
|
|
}
|
|
// Revalidate immediately before mutating: changed PR eligibility or a fresh
|
|
// push in the classify gap must win over the sweep.
|
|
const { data: fresh } = await github.rest.pulls.get({ owner, repo, pull_number: pr.number });
|
|
if (
|
|
fresh.state !== "open" ||
|
|
fresh.draft ||
|
|
fresh.head.sha !== pr.head.sha ||
|
|
fresh.auto_merge ||
|
|
fresh.mergeable === false
|
|
) {
|
|
results.push({
|
|
number: pr.number,
|
|
sha: pr.head.sha.slice(0, 12),
|
|
action: "skip",
|
|
reason: "changed-during-sweep",
|
|
});
|
|
core.info(`pr-ci-sweeper: #${pr.number} changed during sweep; leaving it alone`);
|
|
continue;
|
|
}
|
|
// CI can attach late during the scan's own API calls; closing then would
|
|
// cancel a live run. Re-check the head immediately before mutating.
|
|
const latestRuns = await listPullRequestCiRuns({
|
|
github,
|
|
owner,
|
|
repo,
|
|
headSha: fresh.head.sha,
|
|
});
|
|
if (latestRuns.some((run) => run.conclusion !== "startup_failure")) {
|
|
results.push({
|
|
number: pr.number,
|
|
sha: pr.head.sha.slice(0, 12),
|
|
action: "skip",
|
|
reason: "ci-attached",
|
|
});
|
|
core.info(`pr-ci-sweeper: #${pr.number} CI attached during sweep; leaving it alone`);
|
|
continue;
|
|
}
|
|
// Spend the bounded repair budget only after the exact head still needs a close/reopen.
|
|
refires += 1;
|
|
results.push({ number: pr.number, sha: pr.head.sha.slice(0, 12), ...verdict });
|
|
core.warning(
|
|
`pr-ci-sweeper: re-firing CI for #${pr.number} (${verdict.reason}; GitHub startup recovery)`,
|
|
);
|
|
const knownCloseIds = new Set(
|
|
events.filter((event) => event.event === "closed").map((event) => event.id),
|
|
);
|
|
await github.rest.pulls.update({ owner, repo, pull_number: pr.number, state: "closed" });
|
|
await sleep(REOPEN_DELAY_MS);
|
|
// Skip the reopen only on positive evidence that someone else performed a
|
|
// newer close. Verification errors and stale event reads fail toward
|
|
// reopening: stranding our own close is the worse outcome.
|
|
let humanClosed = false;
|
|
try {
|
|
humanClosed = await someoneElseClosed({
|
|
github,
|
|
owner,
|
|
repo,
|
|
pullNumber: pr.number,
|
|
sweeperLogins,
|
|
knownCloseIds,
|
|
});
|
|
} catch (error) {
|
|
core.info(`pr-ci-sweeper: close-ownership check failed (${String(error)}); reopening`);
|
|
}
|
|
if (humanClosed) {
|
|
core.info(`pr-ci-sweeper: #${pr.number} was closed by someone else; not reopening`);
|
|
continue;
|
|
}
|
|
await reopenWithRetry({ github, core, owner, repo, pullNumber: pr.number });
|
|
}
|
|
core.info(
|
|
`pr-ci-sweeper: scanned ${openPrs.length} open PRs, ${results.length} classified, ${refires} re-fire${refires === 1 ? "" : "s"}${dryRun ? " (dry-run)" : ""}`,
|
|
);
|
|
return results;
|
|
}
|