openclaw/test/scripts/plugin-npm-runtime-assets.test.ts
Peter Steinberger 5e81e62b87
perf(build): avoid duplicate isolated asset generation (#162997)
* perf(build): generate isolated plugin assets once

* fix(build): bound isolated plugin asset execution

* test(ui): inherit model picker readiness fix

Apply the existing fixture correction from dd2a7baba6 (#162869). The picker can be visible while its controls still await catalog hydration; assert readiness before interacting.

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-10-01 23:29:41 -05:00

184 lines
7.3 KiB
TypeScript

import { execFileSync } from "node:child_process";
import fs from "node:fs";
import path from "node:path";
import { pathToFileURL } from "node:url";
import { describe, expect, it, vi } from "vitest";
import * as managedCommands from "../../scripts/lib/managed-child-process.mts";
import { buildPluginNpmRuntime } from "../../scripts/lib/plugin-npm-runtime-build.mts";
import { awaitGateBeforeSettlement, createDeferred } from "../helpers/promise.js";
import { createScriptTestHarness } from "./test-helpers.js";
const { createTempDir } = createScriptTestHarness();
function createAssetFixture(
options: {
tracked?: boolean;
missing?: boolean;
generated?: boolean;
dependency?: string;
localDependency?: boolean;
} = {},
) {
const repoRoot = createTempDir("openclaw-selected-plugin-assets-");
const packageDir = path.join(repoRoot, "extensions", "demo");
const source = options.dependency
? `node_modules/${options.dependency}/private/message.txt`
: "assets/message.txt";
fs.mkdirSync(path.join(packageDir, "assets"), { recursive: true });
fs.writeFileSync(path.join(repoRoot, "package.json"), '{"name":"openclaw","version":"1.0.0"}');
execFileSync("git", ["init", "--quiet"], { cwd: repoRoot });
fs.writeFileSync(
path.join(packageDir, "package.json"),
JSON.stringify({
name: "@fixture/demo",
version: "1.0.0",
type: "module",
...(options.dependency ? { dependencies: { [options.dependency]: "1.0.0" } } : {}),
openclaw: {
extensions: ["./index.ts"],
build: {
runtimeFormat: "esm",
staticAssets: [{ source: `./${source}`, output: "assets/message.txt" }],
},
...(options.generated ? { assetScripts: { build: "node build-assets.cjs" } } : {}),
},
}),
);
fs.writeFileSync(path.join(packageDir, "openclaw.plugin.json"), '{"id":"demo"}');
fs.writeFileSync(
path.join(packageDir, "index.ts"),
'import { readFileSync } from "node:fs"; export const message = readFileSync(new URL("./assets/message.txt", import.meta.url), "utf8");',
);
if (options.dependency) {
for (const base of options.localDependency ? [repoRoot, packageDir] : [repoRoot]) {
const dependencyDir = path.join(base, "node_modules", options.dependency);
fs.mkdirSync(path.join(dependencyDir, "private"), { recursive: true });
fs.writeFileSync(
path.join(dependencyDir, "package.json"),
JSON.stringify({
name: options.dependency,
exports: { "./message": "./private/message.txt" },
}),
);
if (!(options.missing && base === packageDir)) {
fs.writeFileSync(
path.join(dependencyDir, "private/message.txt"),
options.localDependency && base === repoRoot
? "wrong ancestor version"
: "selected asset",
);
}
}
} else if (options.generated) {
fs.writeFileSync(
path.join(packageDir, "build-assets.cjs"),
'require("node:fs").writeFileSync("assets/message.txt", "selected asset");',
);
} else if (!options.missing) {
fs.writeFileSync(path.join(packageDir, "assets", "message.txt"), "selected asset");
}
if (options.tracked) {
execFileSync("git", ["add", "extensions/demo/package.json"], { cwd: repoRoot });
}
return { repoRoot, packageDir, source };
}
describe("selected plugin runtime assets", () => {
it("awaits bounded asset execution before publishing package assets", async () => {
const fixture = createAssetFixture({ generated: true });
fs.writeFileSync(path.join(fixture.packageDir, fixture.source), "previous source asset");
const started = createDeferred<Parameters<typeof managedCommands.runManagedCommand>[0]>();
const command = createDeferred<number>();
const runner = vi
.spyOn(managedCommands, "runManagedCommand")
.mockImplementationOnce((options) => {
started.resolve(options);
return command.promise;
});
const building = buildPluginNpmRuntime({ ...fixture, logLevel: "silent" });
const built = building.then(
() => ({ kind: "completed" as const }),
(error: unknown) => ({ kind: "failed" as const, error }),
);
try {
const options = await awaitGateBeforeSettlement(
started.promise,
building,
"Package builder completed without bounded asset execution",
);
expect(options.timeoutMs).toBe(600_000);
expect(options.requireProcessTreeExit).toBe(process.platform !== "win32");
const output = path.join(fixture.packageDir, "dist/assets/message.txt");
expect(fs.existsSync(output)).toBe(false);
const failure = Object.assign(new Error("joined asset timeout"), {
code: "ETIMEDOUT",
processTreeState: "terminated",
});
command.reject(failure);
expect(await built).toMatchObject({
kind: "failed",
error: {
code: "ETIMEDOUT",
message: "Plugin asset build hook timed out after 600000ms: demo",
cause: failure,
},
});
expect(fs.existsSync(output)).toBe(false);
expect(fs.readFileSync(path.join(fixture.packageDir, fixture.source), "utf8")).toBe(
"previous source asset",
);
} finally {
command.resolve(0);
await built;
runner.mockRestore();
}
});
it.each([
{ name: "untracked package", options: {} },
{ name: "tracked package with a malformed unrelated manifest", options: { tracked: true } },
{ name: "asset generated after compilation", options: { generated: true } },
{ name: "hoisted dependency", options: { dependency: "engine" } },
{ name: "hoisted scoped dependency", options: { dependency: "@fixture/engine" } },
{
name: "plugin-local dependency before hoisted version",
options: { dependency: "@fixture/engine", localDependency: true },
},
])("builds loadable assets for $name", async ({ options }) => {
const fixture = createAssetFixture(options);
if (options.tracked) {
const other = path.join(fixture.repoRoot, "extensions", "other");
fs.mkdirSync(other);
fs.writeFileSync(path.join(other, "package.json"), "{");
execFileSync("git", ["add", "extensions/other/package.json"], { cwd: fixture.repoRoot });
}
const result = await buildPluginNpmRuntime({ ...fixture, logLevel: "silent" });
expect(result?.copiedStaticAssets).toEqual(["dist/assets/message.txt"]);
const entry = pathToFileURL(path.join(fixture.packageDir, "dist", "index.js")).href;
expect(
execFileSync(
process.execPath,
[
"--input-type=module",
"--eval",
`process.stdout.write((await import(${JSON.stringify(entry)})).message);`,
],
{ encoding: "utf8" },
),
).toBe("selected asset");
});
it.each([
{ name: "package-relative file", options: {} },
{
name: "local dependency asset despite an ancestor version containing it",
options: { dependency: "@fixture/engine", localDependency: true },
},
])("reports a missing $name instead of publishing an incomplete package", async ({ options }) => {
const fixture = createAssetFixture({ ...options, tracked: true, missing: true });
await expect(buildPluginNpmRuntime({ ...fixture, logLevel: "silent" })).rejects.toThrow(
`demo missing static asset source(s): extensions/demo/${fixture.source}`,
);
});
});