vrr/openclaw
2
0
Fork 0
mirror of https://github.com/openclaw/openclaw.git synced 2026-10-03 09:39:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 30

fix(test): keep artifact lock fixtures out of ancestor checkouts (#161998)

Browse source 
Give temporary cancellation fixtures their own checkout boundary. Preserve lock ownership and cancellation assertions, and correct existing same-file lint findings.

Co-authored-by: steipete <58493+steipete@users.noreply.github.com>
This commit is contained in:
RoboClaw 2026-09-30 10:12:43 -07:00 • committed by GitHub
parent ab793c8fe1
commit f4ae411b99
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

23
test/scripts/dist-artifact-lock.test.ts
View file

@ -25,12 +25,17 @@ afterEach(async () => {
vi.restoreAllMocks();
await fixture.cleanup();
});
const createRoot = () => fs.realpathSync(fixture.createTempDir("openclaw-lock-cancel-"));
const createRoot = () => {
const root = fs.realpathSync(fixture.createTempDir("openclaw-lock-cancel-"));
// Keep checkout discovery from selecting an ancestor of the temporary fixture.
fs.mkdirSync(path.join(root, ".git"));
return root;
};
it("cancels an already contended same-process waiter without disturbing the owner", async () => {
const root = createRoot();
const enteredOwner = createDeferred<void>();
const releaseOwner = createDeferred<void>();
const enteredOwner = createDeferred();
const releaseOwner = createDeferred();
const owner = withDistArtifactOwnership(root, async () => {
enteredOwner.resolve();
await releaseOwner.promise;
@ -38,7 +43,7 @@ it("cancels an already contended same-process waiter without disturbing the owne
await enteredOwner.promise;
const ownerPath = path.join(resolveDistArtifactLockPath(root), "owner.json");
const originalOwner = fs.readFileSync(ownerPath, "utf8");
const attempted = createDeferred<void>();
const attempted = createDeferred();
const acquire = actual.acquireFileLock;
vi.mocked(fileLock.acquireFileLock).mockImplementation(async (...args) => {
try {
@ -79,17 +84,19 @@ it.for([
"joins acquisition-race release before rejecting (direct=$direct, release fails=$fails)",
async ({ direct, fails }) => {
const root = createRoot();
const entered = createDeferred<void>();
const entered = createDeferred();
const acquired = createDeferred<fileLock.FileLockHandle>();
const releasing = createDeferred<void>();
const released = createDeferred<void>();
const releasing = createDeferred();
const released = createDeferred();
const failure = new Error("release failed");
const controller = new AbortController();
const callback = vi.fn();
const release = vi.fn(async () => {
releasing.resolve();
await released.promise;
if (fails) throw failure;
if (fails) {
throw failure;
}
});
vi.mocked(fileLock.acquireFileLock).mockImplementation(async () => {
entered.resolve();