From bda05dbc2f156f4fb46761263fd7b17dc88367cd Mon Sep 17 00:00:00 2001 From: Vincent Koc Date: Sun, 21 Jun 2026 20:05:22 +0200 Subject: [PATCH] fix(release): reject validation flag values --- scripts/full-release-validation-at-sha.mjs | 2 +- test/scripts/full-release-validation-at-sha.test.ts | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/full-release-validation-at-sha.mjs b/scripts/full-release-validation-at-sha.mjs index e0bc71b2a7f..61f34544ac5 100755 --- a/scripts/full-release-validation-at-sha.mjs +++ b/scripts/full-release-validation-at-sha.mjs @@ -44,7 +44,7 @@ function runStatus(command, args, options = {}) { function readOptionValue(argv, index, optionName) { const value = argv[index + 1]; - if (value === undefined || value === "" || value.startsWith("--")) { + if (value === undefined || value === "" || value.startsWith("-")) { throw new Error(`${optionName} requires a value`); } return value; diff --git a/test/scripts/full-release-validation-at-sha.test.ts b/test/scripts/full-release-validation-at-sha.test.ts index b9cb4251815..8aff12eece3 100644 --- a/test/scripts/full-release-validation-at-sha.test.ts +++ b/test/scripts/full-release-validation-at-sha.test.ts @@ -30,7 +30,10 @@ describe("full-release-validation-at-sha", () => { it("rejects missing option values", () => { expect(() => parseArgs(["--sha", "--dry-run"])).toThrow("--sha requires a value"); + expect(() => parseArgs(["--sha", "-h"])).toThrow("--sha requires a value"); expect(() => parseArgs(["--branch"])).toThrow("--branch requires a value"); + expect(() => parseArgs(["--branch", "-h"])).toThrow("--branch requires a value"); expect(() => parseArgs(["-f", "--dry-run"])).toThrow("-f requires a value"); + expect(() => parseArgs(["-f", "-h"])).toThrow("-f requires a value"); }); });