vrr/open5gs
2
0
Fork 0
mirror of https://github.com/open5gs/open5gs.git synced 2026-04-28 03:19:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

[SMF] Fix Packet Filter Identifier handling in SMF (#3505)

Browse source 
Decrement the Packet Filter Identifier by 1 before sending it to the UE
during GSM message construction. This correction ensures proper synchronization
between the UE and SMF, allowing `smf_pf_find_by_identifier()` to accurately
locate the corresponding `pf` context without adjusting the identifier
during the search.

This fix aligns the 5GC implementation with the EPC behavior,
where the identifier was correctly decremented before transmission to the UE,
preventing mismatches and synchronization issues.
This commit is contained in:
Sukchan Lee 2024-10-15 17:54:31 +09:00
parent 606788361c
commit f82fc85cc2
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/smf/gsm-build.c
View file

@ -113,7 +113,7 @@ ogs_pkbuf_t *gsm_build_pdu_session_establishment_accept(smf_sess_t *sess)
qos_rule[0].num_of_packet_filter = 1;
qos_rule[0].pf[0].direction = OGS_NAS_QOS_DIRECTION_BIDIRECTIONAL;
qos_rule[0].pf[0].identifier = 1;
qos_rule[0].pf[0].identifier = 0;
qos_rule[0].pf[0].content.length = 1;
qos_rule[0].pf[0].content.num_of_component = 1;
qos_rule[0].pf[0].content.component[0].type = OGS_PACKET_FILTER_MATCH_ALL;
@ -299,7 +299,7 @@ static void encode_qos_rule_packet_filter(
ogs_list_for_each_entry(&qos_flow->pf_to_add_list, pf, to_add_node) {
ogs_assert(i < OGS_MAX_NUM_OF_FLOW_IN_NAS);
qos_rule->pf[i].direction = pf->direction;
qos_rule->pf[i].identifier = pf->identifier;
qos_rule->pf[i].identifier = pf->identifier-1;
ogs_pf_content_from_ipfw_rule(
pf->direction, &qos_rule->pf[i].content, &pf->ipfw_rule,

2
src/smf/gsm-handler.c
View file

@ -410,7 +410,7 @@ int gsm_handle_pdu_session_modification_request(
if (pf) {
qos_flow->pf_to_delete
[qos_flow->num_of_pf_to_delete++] =
qos_rule[i].pf[j].identifier;
qos_rule[i].pf[j].identifier-1;
smf_pf_remove(pf);
}
}

2
tests/app/5gc-init.c
View file

@ -129,7 +129,7 @@ int app_initialize(const char *const argv[])
*
* If freeDiameter is not used, it uses a delay of less than 4 seconds.
*/
ogs_msleep(1000);
ogs_msleep(2000);
return OGS_OK;
}