[DIAM] Fix the crash when terminating Diameter

When exiting a diameter interface, the session state data could be NULL.
So we added code to check the session state data
to prevent SIGSEGV occurring.

src/hss/hss-s6a-path.c

@@ -49,6 +49,11 @@ struct sess_state {
 
 static void state_cleanup(struct sess_state *sess_data, os0_t sid, void *opaque)
 {
+    if (!sess_data) {
+        ogs_error("No session state");
+        return;
+    }
+
     ogs_free(sess_data);
 }
 

src/mme/mme-fd-path.c

@@ -45,6 +45,11 @@ static void mme_s6a_pua_cb(void *data, struct msg **msg);
 
 static void state_cleanup(struct sess_state *sess_data, os0_t sid, void *opaque)
 {
+    if (!sess_data) {
+        ogs_error("No session state");
+        return;
+    }
+
     ogs_free(sess_data);
 }
 

src/pcrf/pcrf-gx-path.c

@@ -180,7 +180,10 @@ static struct rx_sess_state *find_rx_state(struct sess_state *gx, os0_t sid)
 
 static void state_cleanup(struct sess_state *sess_data, os0_t sid, void *opaque)
 {
-    ogs_assert(sess_data);
+    if (!sess_data) {
+        ogs_error("No session state");
+        return;
+    }
 
     if (sess_data->peer_host)
         ogs_free(sess_data->peer_host);

src/pcrf/pcrf-rx-path.c

@@ -73,7 +73,10 @@ static __inline__ struct sess_state *new_state(os0_t sid)
 
 static void state_cleanup(struct sess_state *sess_data, os0_t sid, void *opaque)
 {
-    ogs_assert(sess_data);
+    if (!sess_data) {
+        ogs_error("No session state");
+        return;
+    }
 
     if (sess_data->rx_sid)
         ogs_free((char *)sess_data->rx_sid);

src/smf/gx-path.c

@@ -76,6 +76,11 @@ static __inline__ struct sess_state *new_state(os0_t sid)
 
 static void state_cleanup(struct sess_state *sess_data, os0_t sid, void *opaque)
 {
+    if (!sess_data) {
+        ogs_error("No session state");
+        return;
+    }
+
     if (sess_data->gx_sid)
         ogs_free(sess_data->gx_sid);
 

src/smf/gy-path.c

@@ -80,6 +80,11 @@ static __inline__ struct sess_state *new_state(os0_t sid)
 
 static void state_cleanup(struct sess_state *sess_data, os0_t sid, void *opaque)
 {
+    if (!sess_data) {
+        ogs_error("No session state");
+        return;
+    }
+
     if (sess_data->gy_sid)
         ogs_free(sess_data->gy_sid);
 

src/smf/s6b-path.c

@@ -64,6 +64,11 @@ static __inline__ struct sess_state *new_state(os0_t sid)
 
 static void state_cleanup(struct sess_state *sess_data, os0_t sid, void *opaque)
 {
+    if (!sess_data) {
+        ogs_error("No session state");
+        return;
+    }
+
     if (sess_data->s6b_sid)
         ogs_free(sess_data->s6b_sid);
 

tests/non3gpp/diameter-s6b-path.c

@@ -66,7 +66,10 @@ static __inline__ struct sess_state *new_state(os0_t sid)
 
 static void state_cleanup(struct sess_state *sess_data, os0_t sid, void *opaque)
 {
-    ogs_assert(sess_data);
+    if (!sess_data) {
+        ogs_error("No session state");
+        return;
+    }
 
     if (sess_data->sid)
         ogs_free(sess_data->sid);

tests/non3gpp/diameter-swx-path.c

@@ -48,6 +48,11 @@ static void test_swx_saa_cb(void *data, struct msg **msg);
 
 static void state_cleanup(struct sess_state *sess_data, os0_t sid, void *opaque)
 {
+    if (!sess_data) {
+        ogs_error("No session state");
+        return;
+    }
+
     if (sess_data->user_name)
         ogs_free(sess_data->user_name);
 

tests/volte/diameter-cx-path.c

@@ -52,6 +52,11 @@ static void test_cx_lia_cb(void *data, struct msg **msg);
 
 static void state_cleanup(struct sess_state *sess_data, os0_t sid, void *opaque)
 {
+    if (!sess_data) {
+        ogs_error("No session state");
+        return;
+    }
+
     if (sess_data->user_name)
         ogs_free(sess_data->user_name);
     if (sess_data->public_identity)

tests/volte/diameter-rx-path.c

@@ -51,6 +51,11 @@ static __inline__ struct sess_state *new_state(os0_t sid)
 
 static void state_cleanup(struct sess_state *sess_data, os0_t sid, void *opaque)
 {
+    if (!sess_data) {
+        ogs_error("No session state");
+        return;
+    }
+
     if (sess_data->sid)
         ogs_free(sess_data->sid);